Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: examples
    • Labels:
      None

      Description

      DBCount uses ACCESS as table name which is not supported for Oracle DBs since it is a keyword in Oracle as per http://docs.oracle.com/cd/B10501_01/appdev.920/a42525/apb.htm

      Also, BIGINT isn't supported.

      I will shortly post a patch to address this.

        Activity

        Hide
        viji_r Viji added a comment -
        • Changed table name Access to HAccess.
        • Included an 'if' statement to the create statements to allow for proper datatype usage based on DB used.
        Show
        viji_r Viji added a comment - Changed table name Access to HAccess. Included an 'if' statement to the create statements to allow for proper datatype usage based on DB used.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12546673/MAPREDUCE-4685.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-examples.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2884//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2884//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546673/MAPREDUCE-4685.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-examples. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2884//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2884//console This message is automatically generated.
        Hide
        qwertymaniac Harsh J added a comment -

        -1 tests included.

        Doesn't look like we can test this change specific to Oracle. The changes look good to me as they don't seem to be causing any problems to already working DBs (only an if-oracle case seems to exist as a change here, and a DB table name change).

        +1, committing.

        Show
        qwertymaniac Harsh J added a comment - -1 tests included. Doesn't look like we can test this change specific to Oracle. The changes look good to me as they don't seem to be causing any problems to already working DBs (only an if-oracle case seems to exist as a change here, and a DB table name change). +1, committing.
        Hide
        qwertymaniac Harsh J added a comment -

        Committed to trunk, thanks for the report and the patch Viji! Hope to see more contributions from you

        Show
        qwertymaniac Harsh J added a comment - Committed to trunk, thanks for the report and the patch Viji! Hope to see more contributions from you
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2774 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2774/)
        MAPREDUCE-4685. DBCount should not use ACCESS. Contributed by Viji. (harsh) (Revision 1390372)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390372
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/DBCountPageView.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2774 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2774/ ) MAPREDUCE-4685 . DBCount should not use ACCESS. Contributed by Viji. (harsh) (Revision 1390372) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390372 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/DBCountPageView.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2837 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2837/)
        MAPREDUCE-4685. DBCount should not use ACCESS. Contributed by Viji. (harsh) (Revision 1390372)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390372
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/DBCountPageView.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2837 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2837/ ) MAPREDUCE-4685 . DBCount should not use ACCESS. Contributed by Viji. (harsh) (Revision 1390372) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390372 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/DBCountPageView.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2796 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2796/)
        MAPREDUCE-4685. DBCount should not use ACCESS. Contributed by Viji. (harsh) (Revision 1390372)

        Result = FAILURE
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390372
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/DBCountPageView.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2796 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2796/ ) MAPREDUCE-4685 . DBCount should not use ACCESS. Contributed by Viji. (harsh) (Revision 1390372) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390372 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/DBCountPageView.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1177 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1177/)
        MAPREDUCE-4685. DBCount should not use ACCESS. Contributed by Viji. (harsh) (Revision 1390372)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390372
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/DBCountPageView.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1177 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1177/ ) MAPREDUCE-4685 . DBCount should not use ACCESS. Contributed by Viji. (harsh) (Revision 1390372) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390372 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/DBCountPageView.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1208 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1208/)
        MAPREDUCE-4685. DBCount should not use ACCESS. Contributed by Viji. (harsh) (Revision 1390372)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390372
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/DBCountPageView.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1208 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1208/ ) MAPREDUCE-4685 . DBCount should not use ACCESS. Contributed by Viji. (harsh) (Revision 1390372) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390372 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/DBCountPageView.java

          People

          • Assignee:
            viji_r Viji
            Reporter:
            viji_r Viji
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development