Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4673

make TestRawHistoryFile and TestJobHistoryServer more robust

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0, 1.2.0
    • Fix Version/s: 1.1.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Fixed TestRawHistoryFile and TestJobHistoryServer to not write to /tmp.

      Description

      these unit tests fail if 2 different users run them on the same host as they are using /tmp/input path

      following is the info from the test log

      testcase classname="org.apache.hadoop.mapred.TestJobHistoryServer" name="testHistoryServerStandalone" time="4.572">
          <failure message="/tmp/.input.crc (Permission denied)" type="junit.framework.AssertionFailedError">junit.framework.AssertionFailedError: /tmp/.input.crc (Permission denied)
              at org.apache.hadoop.mapred.TestJobHistoryServer.testHistoryServerStandalone(TestJobHistoryServer.java:113)
      </failure>
      
      1. MAPREDUCE-4673.branch-1.patch
        4 kB
        Arpit Gupta
      2. MAPREDUCE-4673.branch-1.patch
        4 kB
        Arpit Gupta

        Activity

        Arpit Gupta created issue -
        Hide
        Arpit Gupta added a comment -

        attached a patch for branch-1. Also removed unused imports.

        Show
        Arpit Gupta added a comment - attached a patch for branch-1. Also removed unused imports.
        Arpit Gupta made changes -
        Field Original Value New Value
        Attachment MAPREDUCE-4673.branch-1.patch [ 12546072 ]
        Hide
        Arpit Gupta added a comment -

        ran the tests for both the classes and tests passed.

        Show
        Arpit Gupta added a comment - ran the tests for both the classes and tests passed.
        Hide
        Arpit Gupta added a comment -

        Could not find these test classes in trunk. so looks like it only impacts branch-1

        Show
        Arpit Gupta added a comment - Could not find these test classes in trunk. so looks like it only impacts branch-1
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Arpit, the patch looks good. One minor nit: wrap around the newly added lines to be under 80chars.

        Once you do that, can you also quickly run test-patch and post the results? Will commit it once that's done. Tx.

        Show
        Vinod Kumar Vavilapalli added a comment - Arpit, the patch looks good. One minor nit: wrap around the newly added lines to be under 80chars. Once you do that, can you also quickly run test-patch and post the results? Will commit it once that's done. Tx.
        Hide
        Arpit Gupta added a comment -

        updated the patch with 80 char limit for the line.

        Show
        Arpit Gupta added a comment - updated the patch with 80 char limit for the line.
        Arpit Gupta made changes -
        Attachment MAPREDUCE-4673.branch-1.patch [ 12546237 ]
        Hide
        Arpit Gupta added a comment -

        Here is the test-patch output

         [exec] BUILD SUCCESSFUL
             [exec] Total time: 7 minutes 1 second
             [exec] 
             [exec] 
             [exec] 
             [exec] 
             [exec] -1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     +1 tests included.  The patch appears to include 8 new or modified tests.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     -1 findbugs.  The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.
             [exec] 
             [exec] 
             [exec] 
             [exec] 
             [exec] ======================================================================
             [exec] ======================================================================
             [exec]     Finished build.
             [exec] ======================================================================
             [exec] ======================================================================
        

        findbugs warnings are not related to the files that have been updated in this patch.

        Show
        Arpit Gupta added a comment - Here is the test-patch output [exec] BUILD SUCCESSFUL [exec] Total time: 7 minutes 1 second [exec] [exec] [exec] [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 8 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== findbugs warnings are not related to the files that have been updated in this patch.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        I just committed this to branch-1 and branch-1.1. Thanks Arpit!

        Show
        Vinod Kumar Vavilapalli added a comment - I just committed this to branch-1 and branch-1.1. Thanks Arpit!
        Vinod Kumar Vavilapalli made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Release Note Fixed TestRawHistoryFile and TestJobHistoryServer to not write to /tmp.
        Fix Version/s 1.1.0 [ 12317960 ]
        Resolution Fixed [ 1 ]
        Hide
        Matt Foley added a comment -

        Closed upon release of Hadoop-1.1.0.

        Show
        Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.
        Matt Foley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arpit Gupta
            Reporter:
            Arpit Gupta
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development