Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.3, 2.0.0-alpha
    • Fix Version/s: 1.2.0, 2.0.2-alpha
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change

      Description

      Remove JobHistory.DEBUG_MODE for the following reasons:

      1. No one seems to be using it - the config parameter corresponding to enabling it does not even exist in mapred-default.xml
      2. The logging being done in DEBUG_MODE needs to move to LOG.debug() and LOG.trace()
      3. Buggy handling of helper methods in DEBUG_MODE; e.g. directoryTime() and timestampDirectoryComponent().

      1. MR-4629.patch
        7 kB
        Karthik Kambatla
      2. MR-4629.patch.v1
        12 kB
        Karthik Kambatla
      3. trunk-mr-6429.patch
        5 kB
        Karthik Kambatla
      4. branch1-mr-4629.patch
        8 kB
        Karthik Kambatla
      5. trunk-mr-6429.patch
        5 kB
        Robert Joseph Evans

        Issue Links

          Activity

          Karthik Kambatla (Inactive) created issue -
          Karthik Kambatla (Inactive) made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          Karthik Kambatla (Inactive) made changes -
          Attachment MR-4629.patch [ 12543406 ]
          Karthik Kambatla (Inactive) made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          Karthik Kambatla (Inactive) made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Karthik Kambatla (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Karthik Kambatla (Inactive) made changes -
          Attachment MR-4629.patch.v1 [ 12544080 ]
          Karthik Kambatla (Inactive) made changes -
          Description The helper methods in JobHistory - directoryTime() and timestampDirectoryComponent() - adjust the month field for readability (Jan is 0 as per Calendar, 1 for us)

          In DEBUG_MODE, JobHistory uses hour instead of month. However, the adjustment is still applied.
          Remove JobHistory.DEBUG_MODE for the following reasons:

          1. No one seems to be using it - the config parameter corresponding to enabling it does not even exist in mapred-default.xml
          2. The logging being done in DEBUG_MODE needs to move to LOG.debug() and LOG.trace()
          3. Buggy handling of helper methods in DEBUG_MODE; e.g. directoryTime() and timestampDirectoryComponent().
          Summary In DEBUG_MODE, JobHistory#directoryTime() returns incorrect time Remove JobHistory.DEBUG_MODE
          Hadoop Flags Incompatible change [ 10342 ]
          Affects Version/s 2.0.0-alpha [ 12320354 ]
          Karthik Kambatla (Inactive) made changes -
          Link This issue blocks MAPREDUCE-4643 [ MAPREDUCE-4643 ]
          Karthik Kambatla (Inactive) made changes -
          Attachment trunk-mr-6429.patch [ 12544167 ]
          Karthik Kambatla (Inactive) made changes -
          Attachment branch1-mr-4629.patch [ 12544175 ]
          Karthik Kambatla (Inactive) made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          Robert Joseph Evans made changes -
          Attachment trunk-mr-6429.patch [ 12544233 ]
          Robert Joseph Evans made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 1.2.0 [ 12321661 ]
          Fix Version/s 2.2.0-alpha [ 12322471 ]
          Resolution Fixed [ 1 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue blocks MAPREDUCE-4643 [ MAPREDUCE-4643 ]
          Gavin made changes -
          Link This issue is depended upon by MAPREDUCE-4643 [ MAPREDUCE-4643 ]
          Gavin made changes -
          Assignee Karthik Kambatla [ kkambatl ] Karthik Kambatla [ kasha ]
          Gavin made changes -
          Reporter Karthik Kambatla [ kkambatl ] Karthik Kambatla [ kasha ]

            People

            • Assignee:
              Karthik Kambatla
              Reporter:
              Karthik Kambatla
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development