Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.3, 3.0.0, 2.0.2-alpha
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: None
    • Labels:

      Description

      TestHsWebServicesJobsQuery fails on jdk7 due to the test order no longer being constant.

      testJobsQueryStateNone(org.apache.hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobsQuery) Time elapsed: 0.279 sec <<< FAILURE!
      java.lang.AssertionError: jobs is not null expected:<null> but was:<{"job":[

      {"startTime":1345559717819,"finishTime":1345560891194,"id":"job_1345560632472_0002","name":"RandomWriter","queue":"mockqueue","user":"mock","state":"KILL_WAIT","mapsTotal":0,"mapsCompleted":0,"reducesTotal":1,"reducesCompleted":1}

      ]}>
      at org.junit.Assert.fail(Assert.java:91)
      at org.junit.Assert.failNotEquals(Assert.java:645)
      at org.junit.Assert.assertEquals(Assert.java:126)
      at org.apache.hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobsQuery.testJobsQueryStateNone(TestHsWebServicesJobsQuery.java:226)

      It looks like the issues is that the mock jobs just iterate through the JOBSTATE and since other tests run first we just happen to hit the state KILL_WAIT that we don't expect any jobs to be in.

        Activity

        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Arun C Murthy made changes -
        Fix Version/s 3.0.0 [ 12320355 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1182 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1182/)
        MAPREDUCE-4569. Fixed TestHsWebServicesJobsQuery to pass on JDK7 by not depending on test order. Contributed by Thomas Graves. (Revision 1379146)

        Result = SUCCESS
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379146
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobsQuery.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1182 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1182/ ) MAPREDUCE-4569 . Fixed TestHsWebServicesJobsQuery to pass on JDK7 by not depending on test order. Contributed by Thomas Graves. (Revision 1379146) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379146 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobsQuery.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1151 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1151/)
        MAPREDUCE-4569. Fixed TestHsWebServicesJobsQuery to pass on JDK7 by not depending on test order. Contributed by Thomas Graves. (Revision 1379146)

        Result = FAILURE
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379146
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobsQuery.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1151 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1151/ ) MAPREDUCE-4569 . Fixed TestHsWebServicesJobsQuery to pass on JDK7 by not depending on test order. Contributed by Thomas Graves. (Revision 1379146) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379146 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobsQuery.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #360 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/360/)
        MAPREDUCE-4569. Fixed TestHsWebServicesJobsQuery to pass on JDK7 by not depending on test order. Contributed by Thomas Graves.
        svn merge --ignore-ancestry -c 1379146 ../../trunk/ (Revision 1379150)

        Result = UNSTABLE
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379150
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobsQuery.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #360 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/360/ ) MAPREDUCE-4569 . Fixed TestHsWebServicesJobsQuery to pass on JDK7 by not depending on test order. Contributed by Thomas Graves. svn merge --ignore-ancestry -c 1379146 ../../trunk/ (Revision 1379150) Result = UNSTABLE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379150 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobsQuery.java
        Vinod Kumar Vavilapalli made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.23.3 [ 12320060 ]
        Fix Version/s 3.0.0 [ 12320355 ]
        Fix Version/s 2.2.0-alpha [ 12322471 ]
        Resolution Fixed [ 1 ]
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Pushed this to trunk, branch-2 and branch-23. Thanks Thomas!

        Show
        Vinod Kumar Vavilapalli added a comment - Pushed this to trunk, branch-2 and branch-23. Thanks Thomas!
        Hide
        Vinod Kumar Vavilapalli added a comment -

        +1. This looks good, the test does indeed potentially fail because of the ordering.

        Pushing this in.

        Show
        Vinod Kumar Vavilapalli added a comment - +1. This looks good, the test does indeed potentially fail because of the ordering. Pushing this in.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12541822/MAPREDUCE-4569.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2755//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2755//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541822/MAPREDUCE-4569.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2755//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2755//console This message is automatically generated.
        Thomas Graves made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 3.0.0 [ 12320355 ]
        Affects Version/s 2.2.0-alpha [ 12322471 ]
        Target Version/s 0.23.3, 3.0.0, 2.2.0-alpha [ 12320060, 12320355, 12322471 ]
        Thomas Graves made changes -
        Field Original Value New Value
        Attachment MAPREDUCE-4569.patch [ 12541822 ]
        Hide
        Thomas Graves added a comment -

        fix by not relying on the state order.

        Show
        Thomas Graves added a comment - fix by not relying on the state order.
        Thomas Graves created issue -

          People

          • Assignee:
            Thomas Graves
            Reporter:
            Thomas Graves
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development