Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4556

FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.3
    • Fix Version/s: 1.2.0
    • Component/s: contrib/fair-share
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. MR-4556.patch
      1 kB
      Karthik Kambatla
    2. MR-4556.patch
      1 kB
      Karthik Kambatla

      Issue Links

        Activity

        Hide
        Matt Foley added a comment -

        Closed upon release of Hadoop 1.2.0.

        Show
        Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
        Hide
        Alejandro Abdelnur added a comment -

        Thanks Karthik. Committed to branch-1.

        Show
        Alejandro Abdelnur added a comment - Thanks Karthik. Committed to branch-1.
        Hide
        Alejandro Abdelnur added a comment -

        +1 pending on YARN-23 to get in trunk.

        Show
        Alejandro Abdelnur added a comment - +1 pending on YARN-23 to get in trunk.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12544157/MR-4556.patch
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2827//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544157/MR-4556.patch against trunk revision . -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2827//console This message is automatically generated.
        Hide
        Karthik Kambatla added a comment -

        Rebased on branch-1.

        Testing:
        TestFairScheduler#testPoolAssignment() and TestFairScheduler#testSetPoolTwice() verify PoolSchedulable#updateDemand() that the patch changes.

        However, a couple of other tests fail in TestFairScheduler. Will create a JIRA for those failures.

        Show
        Karthik Kambatla added a comment - Rebased on branch-1. Testing: TestFairScheduler#testPoolAssignment() and TestFairScheduler#testSetPoolTwice() verify PoolSchedulable#updateDemand() that the patch changes. However, a couple of other tests fail in TestFairScheduler . Will create a JIRA for those failures.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12540965/MR-4556.patch
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2727//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12540965/MR-4556.patch against trunk revision . -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2727//console This message is automatically generated.
        Hide
        Karthik Kambatla added a comment -

        MR1 side of YARN-23

        Show
        Karthik Kambatla added a comment - MR1 side of YARN-23

          People

          • Assignee:
            Karthik Kambatla
            Reporter:
            Karthik Kambatla
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development