Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4517

Too many INFO messages written out during AM to RM heartbeat

    Details

      Description

      Too many INFO log messages written out during AM to RM heartbeat. Based on default frequency of 1000ms (scheduler.heartbeat.interval-ms) either 2 or 4 INFO messages are written out per second:

      LOG.info("Before Scheduling: " + getStat());
      List<Container> allocatedContainers = getResources();
      LOG.info("After Scheduling: " + getStat());
      if (allocatedContainers.size() > 0)

      { LOG.info("Before Assign: " + getStat()); scheduledRequests.assign(allocatedContainers); LOG.info("After Assign: " + getStat()); }

      These should probably be changed to DEBUG message to save the log growing too quickly.

      1. MAPREDUCE-4517.patch
        1 kB
        James Kinley
      2. MAPREDUCE-4517.patch
        6 kB
        Jason Lowe
      3. MAPREDUCE-4517.patch
        6 kB
        Jason Lowe
      4. MAPREDUCE-4517.patch
        6 kB
        Jason Lowe
      5. MAPREDUCE-4517.patch
        7 kB
        Jason Lowe

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1257 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1257/)
        MAPREDUCE-4517. Too many INFO messages written out during AM to RM heartbeat (Jason Lowe via tgraves) (Revision 1409032)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409032
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1257 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1257/ ) MAPREDUCE-4517 . Too many INFO messages written out during AM to RM heartbeat (Jason Lowe via tgraves) (Revision 1409032) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409032 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1226 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1226/)
        MAPREDUCE-4517. Too many INFO messages written out during AM to RM heartbeat (Jason Lowe via tgraves) (Revision 1409032)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409032
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1226 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1226/ ) MAPREDUCE-4517 . Too many INFO messages written out during AM to RM heartbeat (Jason Lowe via tgraves) (Revision 1409032) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409032 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #435 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/435/)
        merge -r 1409031:1409032 from trunk. FIXES: MAPREDUCE-4517 (Revision 1409035)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409035
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #435 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/435/ ) merge -r 1409031:1409032 from trunk. FIXES: MAPREDUCE-4517 (Revision 1409035) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409035 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #36 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/36/)
        MAPREDUCE-4517. Too many INFO messages written out during AM to RM heartbeat (Jason Lowe via tgraves) (Revision 1409032)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409032
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #36 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/36/ ) MAPREDUCE-4517 . Too many INFO messages written out during AM to RM heartbeat (Jason Lowe via tgraves) (Revision 1409032) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409032 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3011 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3011/)
        MAPREDUCE-4517. Too many INFO messages written out during AM to RM heartbeat (Jason Lowe via tgraves) (Revision 1409032)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409032
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3011 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3011/ ) MAPREDUCE-4517 . Too many INFO messages written out during AM to RM heartbeat (Jason Lowe via tgraves) (Revision 1409032) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409032 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
        Hide
        Thomas Graves added a comment -

        +1 looks good. Thanks Jason!

        Show
        Thomas Graves added a comment - +1 looks good. Thanks Jason!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12553363/MAPREDUCE-4517.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3027//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3027//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12553363/MAPREDUCE-4517.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3027//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3027//console This message is automatically generated.
        Hide
        Jason Lowe added a comment -

        Thanks for the review, Tom. I modified the logging to only log a before and after for the entire heartbeat (and only if something changed). Also abbreviated field names in the log message so it's not such a long line.

        I moved out the headroom logging and log only in debug since that's likely to change often while the job is running and it often isn't interesting when it does. It's usually interesting when the AM isn't preempting reducers to make room for maps, and we can always turn on debug via the logLevel webpage to dynamically enable the logging of the headroom to figure things out.

        Show
        Jason Lowe added a comment - Thanks for the review, Tom. I modified the logging to only log a before and after for the entire heartbeat (and only if something changed). Also abbreviated field names in the log message so it's not such a long line. I moved out the headroom logging and log only in debug since that's likely to change often while the job is running and it often isn't interesting when it does. It's usually interesting when the AM isn't preempting reducers to make room for maps, and we can always turn on debug via the logLevel webpage to dynamically enable the logging of the headroom to figure things out.
        Hide
        Thomas Graves added a comment -

        Mostly looks good. How about we take one more of the updateAndLogIfChanged calls out though and only call it once before Scheduling and then once after the assign (outside of the if block) and then in getResource add a log message for the # new or finished containers. This way we cut the logging down but I think still get the crucial information. I think assign and getResource already have other log messages that will allow us to build up what happens in between.

        Show
        Thomas Graves added a comment - Mostly looks good. How about we take one more of the updateAndLogIfChanged calls out though and only call it once before Scheduling and then once after the assign (outside of the if block) and then in getResource add a log message for the # new or finished containers. This way we cut the logging down but I think still get the crucial information. I think assign and getResource already have other log messages that will allow us to build up what happens in between.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12553278/MAPREDUCE-4517.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3022//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3022//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12553278/MAPREDUCE-4517.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3022//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3022//console This message is automatically generated.
        Hide
        Jason Lowe added a comment -

        Ack, I totally misunderstood what findbugs ws complaining about. My local findbugs is happy with this version of the patch.

        Show
        Jason Lowe added a comment - Ack, I totally misunderstood what findbugs ws complaining about. My local findbugs is happy with this version of the patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12553271/MAPREDUCE-4517.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 13 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3021//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3021//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3021//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12553271/MAPREDUCE-4517.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 13 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3021//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3021//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3021//console This message is automatically generated.
        Hide
        Jason Lowe added a comment -

        Updated patch to fix findbug warnings. No unit test since it's just changing logging behavior. I manually tested this with sleep jobs and verified it no longer emits messages during heartbeats to the RM unless the scheduling state has changed.

        Show
        Jason Lowe added a comment - Updated patch to fix findbug warnings. No unit test since it's just changing logging behavior. I manually tested this with sleep jobs and verified it no longer emits messages during heartbeats to the RM unless the scheduling state has changed.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12553265/MAPREDUCE-4517.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3020//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3020//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3020//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12553265/MAPREDUCE-4517.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3020//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3020//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3020//console This message is automatically generated.
        Hide
        Jason Lowe added a comment -

        Patch to only log scheduling stats when they change.

        Show
        Jason Lowe added a comment - Patch to only log scheduling stats when they change.
        Hide
        Jason Lowe added a comment -

        I agree the messages are too long and printing them every heartbeat is wasteful. However the messages have proven multiple times to be critical in debugging scheduling issues, and I fear having them turned off completely by default will make debugging issues between the RM and AM very difficult.

        I think we could log a lot less and still have the state info we need if we only logged these messages when something in them changes. Logging the same state every heartbeat isn't useful, but knowing when these states change is.

        Show
        Jason Lowe added a comment - I agree the messages are too long and printing them every heartbeat is wasteful. However the messages have proven multiple times to be critical in debugging scheduling issues, and I fear having them turned off completely by default will make debugging issues between the RM and AM very difficult. I think we could log a lot less and still have the state info we need if we only logged these messages when something in them changes. Logging the same state every heartbeat isn't useful, but knowing when these states change is.
        Hide
        James Kinley added a comment -

        No new tests required. Only changed logging level from INFO to DEBUG.

        Show
        James Kinley added a comment - No new tests required. Only changed logging level from INFO to DEBUG.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12544442/MAPREDUCE-4517.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2833//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2833//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544442/MAPREDUCE-4517.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2833//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2833//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12539306/MAPREDUCE-4517.patch
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2710//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539306/MAPREDUCE-4517.patch against trunk revision . -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2710//console This message is automatically generated.
        Hide
        James Kinley added a comment -

        Trivial change attached.

        Show
        James Kinley added a comment - Trivial change attached.

          People

          • Assignee:
            Jason Lowe
            Reporter:
            James Kinley
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development