Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4504

SortValidator writes to wrong directory

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 0.23.3, 3.0.0, 2.0.2-alpha
        • Fix Version/s: 0.23.3, 2.0.2-alpha
        • Component/s: mrv2
        • Labels:
          None

          Description

          SortValidator tries to write to jobConf.get("hadoop.tmp.dir", "/tmp"), but it is not intended to be an HDFS directory. it should just be /tmp.

          1. Text File
            MR-4504.txt
            2 kB
            Robert Joseph Evans

            Issue Links

            is broken by

            Improvement - An improvement or enhancement to an existing feature or task. MAPREDUCE-4234 SortValidator.java is incompatible with multi-user or parallel use (due to a /tmp file with static name)

            • Minor - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

              Activity

              Ascending order - Click to sort in descending order
              Robert Joseph Evans created issue -
              Hide
              Permalink
              Robert Joseph Evans added a comment -

              Adds in fix.

              Show
              Robert Joseph Evans added a comment - Adds in fix.
              Robert Joseph Evans made changes -
              Field Original Value New Value
              Attachment MR-4504.txt [ 12538786 ]
              Robert Joseph Evans made changes -
              Status Open [ 1 ] Patch Available [ 10002 ]
              Robert Joseph Evans made changes -
              Link This issue is broken by MAPREDUCE-4234 [ MAPREDUCE-4234 ]
              Hide
              Permalink
              Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12538786/MR-4504.txt
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 2 new or modified test files.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 eclipse:eclipse. The patch built with eclipse:eclipse.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

              org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2693//testReport/
              Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2693//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12538786/MR-4504.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2693//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2693//console This message is automatically generated.
              Hide
              Permalink
              Thomas Graves added a comment -

              +1 looks good, thanks Bobby!

              Show
              Thomas Graves added a comment - +1 looks good, thanks Bobby!
              Thomas Graves made changes -
              Status Patch Available [ 10002 ] Resolved [ 5 ]
              Fix Version/s 0.23.3 [ 12320060 ]
              Fix Version/s 3.0.0 [ 12320355 ]
              Fix Version/s 2.2.0-alpha [ 12322471 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Hdfs-trunk-Commit #2614 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2614/)
              MAPREDUCE-4504. SortValidator writes to wrong directory (Robert Evans via tgraves) (Revision 1368294)

              Result = SUCCESS
              tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368294
              Files :

              • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
              • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/SortValidator.java
              • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/SortValidator.java
              Show
              Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2614 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2614/ ) MAPREDUCE-4504 . SortValidator writes to wrong directory (Robert Evans via tgraves) (Revision 1368294) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368294 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/SortValidator.java /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/SortValidator.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Common-trunk-Commit #2549 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2549/)
              MAPREDUCE-4504. SortValidator writes to wrong directory (Robert Evans via tgraves) (Revision 1368294)

              Result = SUCCESS
              tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368294
              Files :

              • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
              • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/SortValidator.java
              • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/SortValidator.java
              Show
              Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2549 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2549/ ) MAPREDUCE-4504 . SortValidator writes to wrong directory (Robert Evans via tgraves) (Revision 1368294) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368294 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/SortValidator.java /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/SortValidator.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Mapreduce-trunk-Commit #2567 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2567/)
              MAPREDUCE-4504. SortValidator writes to wrong directory (Robert Evans via tgraves) (Revision 1368294)

              Result = FAILURE
              tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368294
              Files :

              • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
              • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/SortValidator.java
              • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/SortValidator.java
              Show
              Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2567 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2567/ ) MAPREDUCE-4504 . SortValidator writes to wrong directory (Robert Evans via tgraves) (Revision 1368294) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368294 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/SortValidator.java /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/SortValidator.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Hdfs-0.23-Build #332 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/332/)
              merge -r 1368295:1368296 from branch-2. FIXES: MAPREDUCE-4504 (Revision 1368298)

              Result = SUCCESS
              tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368298
              Files :

              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/SortValidator.java
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/SortValidator.java
              Show
              Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #332 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/332/ ) merge -r 1368295:1368296 from branch-2. FIXES: MAPREDUCE-4504 (Revision 1368298) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368298 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/SortValidator.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/SortValidator.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Hdfs-trunk #1123 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1123/)
              MAPREDUCE-4504. SortValidator writes to wrong directory (Robert Evans via tgraves) (Revision 1368294)

              Result = SUCCESS
              tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368294
              Files :

              • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
              • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/SortValidator.java
              • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/SortValidator.java
              Show
              Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1123 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1123/ ) MAPREDUCE-4504 . SortValidator writes to wrong directory (Robert Evans via tgraves) (Revision 1368294) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368294 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/SortValidator.java /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/SortValidator.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Mapreduce-trunk #1155 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1155/)
              MAPREDUCE-4504. SortValidator writes to wrong directory (Robert Evans via tgraves) (Revision 1368294)

              Result = FAILURE
              tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368294
              Files :

              • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
              • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/SortValidator.java
              • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/SortValidator.java
              Show
              Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1155 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1155/ ) MAPREDUCE-4504 . SortValidator writes to wrong directory (Robert Evans via tgraves) (Revision 1368294) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368294 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/SortValidator.java /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/SortValidator.java
              Arun C Murthy made changes -
              Fix Version/s 3.0.0 [ 12320355 ]
              Arun C Murthy made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Robert Joseph Evans
                  Reporter:
                  Robert Joseph Evans
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development