Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4467

IndexCache failures due to missing synchronization

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.23.2
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: nodemanager
    • Labels:
      None

      Description

      TestMRJobs.testSleepJob fails randomly due to synchronization error in IndexCache:

      2012-07-20 19:32:34,627 ERROR [New I/O server worker #2-1] mapred.ShuffleHandler (ShuffleHandler.java:exceptionCaught(528)) - Shuffle error: 
      java.lang.IllegalMonitorStateException
      	at java.lang.Object.wait(Native Method)
      	at org.apache.hadoop.mapred.IndexCache.getIndexInformation(IndexCache.java:74)
      	at org.apache.hadoop.mapred.ShuffleHandler$Shuffle.sendMapOutput(ShuffleHandler.java:471)
      	at org.apache.hadoop.mapred.ShuffleHandler$Shuffle.messageReceived(ShuffleHandler.java:397)
      	at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleUpstream(ChunkedWriteHandler.java:148)
      	at org.jboss.netty.handler.codec.http.HttpChunkAggregator.messageReceived(HttpChunkAggregator.java:116)
      	at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:302)
      	at org.jboss.netty.handler.codec.replay.ReplayingDecoder.unfoldAndfireMessageReceived(ReplayingDecoder.java:522)
      	at org.jboss.netty.handler.codec.replay.ReplayingDecoder.callDecode(ReplayingDecoder.java:506)
      	at org.jboss.netty.handler.codec.replay.ReplayingDecoder.messageReceived(ReplayingDecoder.java:443)
      	at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274)
      	at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261)
      	at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:349)
      	at org.jboss.netty.channel.socket.nio.NioWorker.processSelectedKeys(NioWorker.java:280)
      	at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:200)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
      	at java.lang.Thread.run(Thread.java:662)
      

      A related issue is MAPREDUCE-4384. The change introduced there removed "synchronized" keyword and hence "info.wait()" call fails. Tbis needs to be wrapped into a "synchronized" block.

      1. mapreduce-4467.patch.txt
        2 kB
        Kihwal Lee
      2. mapreduce-4467.patch.txt
        2 kB
        Kihwal Lee

        Activity

        Hide
        Kihwal Lee added a comment -

        Sorry about the bug. Patch attached.

        Show
        Kihwal Lee added a comment - Sorry about the bug. Patch attached.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12537395/mapreduce-4467.patch.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2639//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2639//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12537395/mapreduce-4467.patch.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2639//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2639//console This message is automatically generated.
        Hide
        Kihwal Lee added a comment -

        Additional test not needed. Existing test case detected the breakage.

        Show
        Kihwal Lee added a comment - Additional test not needed. Existing test case detected the breakage.
        Hide
        Thomas Graves added a comment -

        Looks good. Minor nit, can you change info.wait(0); back to info.wait();

        otherwise +1.

        Show
        Thomas Graves added a comment - Looks good. Minor nit, can you change info.wait(0); back to info.wait(); otherwise +1.
        Hide
        Kihwal Lee added a comment -

        The new patch addresses Tom's comment.

        Show
        Kihwal Lee added a comment - The new patch addresses Tom's comment.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12537731/mapreduce-4467.patch.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2654//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2654//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12537731/mapreduce-4467.patch.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2654//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2654//console This message is automatically generated.
        Hide
        Thomas Graves added a comment -

        +1. Thanks Kihwal.

        Show
        Thomas Graves added a comment - +1. Thanks Kihwal.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2582 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2582/)
        MAPREDUCE-4467. IndexCache failures due to missing synchronization (Kihwal Lee via tgraves) (Revision 1365240)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365240
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/IndexCache.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2582 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2582/ ) MAPREDUCE-4467 . IndexCache failures due to missing synchronization (Kihwal Lee via tgraves) (Revision 1365240) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365240 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/IndexCache.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2517 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2517/)
        MAPREDUCE-4467. IndexCache failures due to missing synchronization (Kihwal Lee via tgraves) (Revision 1365240)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365240
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/IndexCache.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2517 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2517/ ) MAPREDUCE-4467 . IndexCache failures due to missing synchronization (Kihwal Lee via tgraves) (Revision 1365240) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365240 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/IndexCache.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2538 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2538/)
        MAPREDUCE-4467. IndexCache failures due to missing synchronization (Kihwal Lee via tgraves) (Revision 1365240)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365240
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/IndexCache.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2538 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2538/ ) MAPREDUCE-4467 . IndexCache failures due to missing synchronization (Kihwal Lee via tgraves) (Revision 1365240) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365240 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/IndexCache.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1115 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1115/)
        MAPREDUCE-4467. IndexCache failures due to missing synchronization (Kihwal Lee via tgraves) (Revision 1365240)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365240
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/IndexCache.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1115 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1115/ ) MAPREDUCE-4467 . IndexCache failures due to missing synchronization (Kihwal Lee via tgraves) (Revision 1365240) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365240 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/IndexCache.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #324 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/324/)
        merge -r 1365240:1365241 from branch-2. FIXES: MAPREDUCE-4467 (Revision 1365243)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365243
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/IndexCache.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #324 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/324/ ) merge -r 1365240:1365241 from branch-2. FIXES: MAPREDUCE-4467 (Revision 1365243) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365243 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/IndexCache.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1147 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1147/)
        MAPREDUCE-4467. IndexCache failures due to missing synchronization (Kihwal Lee via tgraves) (Revision 1365240)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365240
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/IndexCache.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1147 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1147/ ) MAPREDUCE-4467 . IndexCache failures due to missing synchronization (Kihwal Lee via tgraves) (Revision 1365240) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365240 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/IndexCache.java

          People

          • Assignee:
            Kihwal Lee
            Reporter:
            Andrey Klochkov
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development