Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4432

Confusing warning message when GenericOptionsParser is not used

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The warning that is issued in JobSubmitter – "Use GenericOptionsParser for parsing the arguments. Applications should implement Tool for the same." – is confusing and (probably) grammatically incorrect.

      This can be improved by having an updated warning message which gives clearer directions on what can be improved in the application to avoid the warning in the future.

      1. MAPREDUCE-4432.patch
        1 kB
        Gabriel Reid
      2. MAPREDUCE-4432.patch
        1 kB
        Gabriel Reid

        Activity

        Hide
        Gabriel Reid added a comment -

        Patch attached to update the warning message

        Show
        Gabriel Reid added a comment - Patch attached to update the warning message
        Hide
        Harsh J added a comment -

        Gabriel,

        Thanks for filing this! I agree we should improve it. Your improvement is much nicer to read and understand as well

        Given that GenericOptionsParser is a non-public API class, and Tool was the real to-be-used class for users, I think we should not suggest GOP at all and rather show the message just with Tool?

        Show
        Harsh J added a comment - Gabriel, Thanks for filing this! I agree we should improve it. Your improvement is much nicer to read and understand as well Given that GenericOptionsParser is a non-public API class, and Tool was the real to-be-used class for users, I think we should not suggest GOP at all and rather show the message just with Tool?
        Hide
        Gabriel Reid added a comment -

        Good point about GOP – I'll upload a new patch that only mentions Tool and ToolRunner.

        Show
        Gabriel Reid added a comment - Good point about GOP – I'll upload a new patch that only mentions Tool and ToolRunner.
        Hide
        Gabriel Reid added a comment -

        Updated patch that doesn't mention GenericOptionsParser

        Show
        Gabriel Reid added a comment - Updated patch that doesn't mention GenericOptionsParser
        Hide
        Harsh J added a comment -

        This looks good, thank you! +1 pending jenkins result.

        Show
        Harsh J added a comment - This looks good, thank you! +1 pending jenkins result.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12536261/MAPREDUCE-4432.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2584//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2584//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12536261/MAPREDUCE-4432.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2584//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2584//console This message is automatically generated.
        Hide
        Gabriel Reid added a comment -

        Justification for the lack of new tests on this patch is that the patch is only changing the wording of a warning message, and therefore not a candidate for automated testing.

        Show
        Gabriel Reid added a comment - Justification for the lack of new tests on this patch is that the patch is only changing the wording of a warning message, and therefore not a candidate for automated testing.
        Hide
        Robert Joseph Evans added a comment -

        I am +1 on this patch too. Thanks Gabriel for helping to make Hadoop better.

        Show
        Robert Joseph Evans added a comment - I am +1 on this patch too. Thanks Gabriel for helping to make Hadoop better.
        Hide
        Harsh J added a comment -

        Committed to branch-2 and trunk. Thanks for the contribution Gabriel, and thanks for the additional review too Robert!

        Show
        Harsh J added a comment - Committed to branch-2 and trunk. Thanks for the contribution Gabriel, and thanks for the additional review too Robert!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2529 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2529/)
        MAPREDUCE-4432. Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2529 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2529/ ) MAPREDUCE-4432 . Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2463 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2463/)
        MAPREDUCE-4432. Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2463 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2463/ ) MAPREDUCE-4432 . Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2483 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2483/)
        MAPREDUCE-4432. Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273)

        Result = FAILURE
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2483 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2483/ ) MAPREDUCE-4432 . Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1103 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1103/)
        MAPREDUCE-4432. Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273)

        Result = FAILURE
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1103 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1103/ ) MAPREDUCE-4432 . Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1136 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1136/)
        MAPREDUCE-4432. Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1136 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1136/ ) MAPREDUCE-4432 . Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java

          People

          • Assignee:
            Unassigned
            Reporter:
            Gabriel Reid
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development