Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4422

YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: nodemanager
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.

      However, we didn't add a default value to YarnConfiguration, as-is the norm.

      Ran into it while investigating MAPREDUCE-4421.

      1. MAPREDUCE-4422_rev4.patch
        5 kB
        Ahmed Radwan
      2. MAPREDUCE-4422_rev3.patch
        5 kB
        Ahmed Radwan
      3. MAPREDUCE-4422_rev3.patch
        4 kB
        Harsh J
      4. MAPREDUCE-4422_rev2.patch
        3 kB
        Ahmed Radwan
      5. MAPREDUCE-4422.patch
        1 kB
        Ahmed Radwan

        Activity

        Arun C Murthy created issue -
        Ahmed Radwan made changes -
        Field Original Value New Value
        Assignee Ahmed Radwan [ ahmed.radwan ]
        Hide
        Ahmed Radwan added a comment -

        Here is the patch adding the default value (from yarn-default.xml) to YarnConfiguration as well. Sorry, I missed adding it while working on MAPREDUCE-3505.

        Show
        Ahmed Radwan added a comment - Here is the patch adding the default value (from yarn-default.xml) to YarnConfiguration as well. Sorry, I missed adding it while working on MAPREDUCE-3505 .
        Ahmed Radwan made changes -
        Attachment MAPREDUCE-4422.patch [ 12536196 ]
        Ahmed Radwan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12536196/MAPREDUCE-4422.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2578//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2578//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12536196/MAPREDUCE-4422.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2578//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2578//console This message is automatically generated.
        Hide
        Harsh J added a comment -

        The yarn-default contains spaces, but am guessing that those missing here is no big deal?:

        $HADOOP_CONF_DIR, $HADOOP_COMMON_HOME/share/hadoop/common/*, $HADOOP_COMMON_HOME/share/hadoop/common/lib/*, $HADOOP_HDFS_HOME/share/hadoop/hdfs/*, $HADOOP_HDFS_HOME/share/hadoop/hdfs/lib/*, $YARN_HOME/share/hadoop/mapreduce/*, $YARN_HOME/share/hadoop/mapreduce/lib/*
        

        Regardless of the result, lets make it consistent in both places. I feel its better to do that with an area like the CP config.

        Show
        Harsh J added a comment - The yarn-default contains spaces, but am guessing that those missing here is no big deal?: $HADOOP_CONF_DIR, $HADOOP_COMMON_HOME/share/hadoop/common/*, $HADOOP_COMMON_HOME/share/hadoop/common/lib/*, $HADOOP_HDFS_HOME/share/hadoop/hdfs/*, $HADOOP_HDFS_HOME/share/hadoop/hdfs/lib/*, $YARN_HOME/share/hadoop/mapreduce/*, $YARN_HOME/share/hadoop/mapreduce/lib/* Regardless of the result, lets make it consistent in both places. I feel its better to do that with an area like the CP config.
        Hide
        Ahmed Radwan added a comment -

        Thanks Harsh for the review!
        Yes, it is not an issue, but I agree about consistency. I have updated the patch accordingly.

        Show
        Ahmed Radwan added a comment - Thanks Harsh for the review! Yes, it is not an issue, but I agree about consistency. I have updated the patch accordingly.
        Ahmed Radwan made changes -
        Attachment MAPREDUCE-4422_rev2.patch [ 12536259 ]
        Hide
        Harsh J added a comment -

        Thanks Ahmed. +1, pending Jenkins.

        Show
        Harsh J added a comment - Thanks Ahmed. +1, pending Jenkins.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12536259/MAPREDUCE-4422_rev2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2581//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2581//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12536259/MAPREDUCE-4422_rev2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2581//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2581//console This message is automatically generated.
        Hide
        Harsh J added a comment -

        Committing shortly.

        Show
        Harsh J added a comment - Committing shortly.
        Harsh J made changes -
        Hadoop Flags Reviewed [ 10343 ]
        Affects Version/s 2.0.0-alpha [ 12320354 ]
        Target Version/s 2.0.1-alpha [ 12321442 ]
        Component/s nodemanager [ 12315341 ]
        Hide
        Harsh J added a comment -

        Committed to branch-2 and trunk. Thanks Ahmed!

        Show
        Harsh J added a comment - Committed to branch-2 and trunk. Thanks Ahmed!
        Harsh J made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Target Version/s 2.0.1-alpha [ 12321442 ]
        Fix Version/s 2.0.1-alpha [ 12321442 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2527 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2527/)
        MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2527 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2527/ ) MAPREDUCE-4422 . YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2461 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2461/)
        MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2461 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2461/ ) MAPREDUCE-4422 . YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Arun C Murthy added a comment -

        Uh, Harsh/Ahmed, I'm confused... the newly added variable DEFAULT_YARN_APPLICATION_CLASSPATH isn't being used anywhere? The point of adding this was to use it, at least, in MRApps.setMRFrameworkClasspath?

        Also, not sure whether this was introduced via MAPREDUCE-3505, but we should use Configuration.getStrings rather than do a 'manual' String.split to parse this out.

        Show
        Arun C Murthy added a comment - Uh, Harsh/Ahmed, I'm confused... the newly added variable DEFAULT_YARN_APPLICATION_CLASSPATH isn't being used anywhere? The point of adding this was to use it, at least, in MRApps.setMRFrameworkClasspath? Also, not sure whether this was introduced via MAPREDUCE-3505 , but we should use Configuration.getStrings rather than do a 'manual' String.split to parse this out.
        Arun C Murthy made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Harsh J added a comment -

        /me facepalms at not seeing that. Sorry.

        I have reverted MAPREDUCE-4422 from both branch-2 and trunk, for until
        your comments are all addressed.

        Show
        Harsh J added a comment - /me facepalms at not seeing that. Sorry. I have reverted MAPREDUCE-4422 from both branch-2 and trunk, for until your comments are all addressed.
        Hide
        Ahmed Radwan added a comment -

        > the newly added variable DEFAULT_YARN_APPLICATION_CLASSPATH isn't being used anywhere? The point of adding this was to use it, at least, in MRApps.setMRFrameworkClasspath?

        MRApps.setMRFrameworkClasspath reads the value from the conf files through conf.get(YarnConfiguration.YARN_APPLICATION_CLASSPATH), and if not set, the default value will be picked from yarn-default.xml. Making it reads the DEFAULT_YARN_APPLICATION_CLASSPATH will defeat the purpose of having it configurable. Or do you just mean modifying the call to be conf.get(YarnConfiguration.YARN_APPLICATION_CLASSPATH, DEFAULT_YARN_APPLICATION_CLASSPATH), which will not make a difference in this case as the default is already picked if the property is not set.

        > we should use Configuration.getStrings rather than do a 'manual' String.split to parse this out.

        Configuration.getString uses StringTokenizer to achieve exactly what String.split will do here. I am not sure if one is more efficient than the other, but I can change the it if you know it is better. I'll upload a new patch with the updates.

        Show
        Ahmed Radwan added a comment - > the newly added variable DEFAULT_YARN_APPLICATION_CLASSPATH isn't being used anywhere? The point of adding this was to use it, at least, in MRApps.setMRFrameworkClasspath? MRApps.setMRFrameworkClasspath reads the value from the conf files through conf.get(YarnConfiguration.YARN_APPLICATION_CLASSPATH), and if not set, the default value will be picked from yarn-default.xml. Making it reads the DEFAULT_YARN_APPLICATION_CLASSPATH will defeat the purpose of having it configurable. Or do you just mean modifying the call to be conf.get(YarnConfiguration.YARN_APPLICATION_CLASSPATH, DEFAULT_YARN_APPLICATION_CLASSPATH), which will not make a difference in this case as the default is already picked if the property is not set. > we should use Configuration.getStrings rather than do a 'manual' String.split to parse this out. Configuration.getString uses StringTokenizer to achieve exactly what String.split will do here. I am not sure if one is more efficient than the other, but I can change the it if you know it is better. I'll upload a new patch with the updates.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2481 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2481/)
        MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061)

        Result = FAILURE
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2481 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2481/ ) MAPREDUCE-4422 . YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2528 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2528/)
        Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2528 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2528/ ) Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2462 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2462/)
        Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2462 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2462/ ) Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Harsh J added a comment -

        Here's a patch with Arun's comments specifically addressed.

        Arun/Ahmed - Are there other spots and/or tests we should be using this default string at?

        Show
        Harsh J added a comment - Here's a patch with Arun's comments specifically addressed. Arun/Ahmed - Are there other spots and/or tests we should be using this default string at?
        Harsh J made changes -
        Attachment MAPREDUCE-4422_rev3.patch [ 12536354 ]
        Hide
        Ahmed Radwan added a comment -

        Thanks Arun and Harsh, Here is the updated patch with Arun comments addressed. I have also spotted another use in distributedshell client that could be updated and I added that to the patch.

        Show
        Ahmed Radwan added a comment - Thanks Arun and Harsh, Here is the updated patch with Arun comments addressed. I have also spotted another use in distributedshell client that could be updated and I added that to the patch.
        Ahmed Radwan made changes -
        Attachment MAPREDUCE-4422_rev3.patch [ 12536356 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2482 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2482/)
        Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107)

        Result = FAILURE
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2482 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2482/ ) Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1102 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1102/)
        Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107)
        MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061)

        Result = FAILURE
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1102 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1102/ ) Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107) MAPREDUCE-4422 . YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Arun C Murthy added a comment -

        Or do you just mean modifying the call to be conf.get(YarnConfiguration.YARN_APPLICATION_CLASSPATH, DEFAULT_YARN_APPLICATION_CLASSPATH),

        Ahmed - yes. Apologies if I wasn't clear, that was what I meant.

        which will not make a difference in this case as the default is already picked if the property is not set.

        Ahmed - the point of doing this is essentially documentation. We follow the convention all over the codebase so that developers quickly grok the flow; and hence the jira itself.

        Configuration.getString uses StringTokenizer to achieve exactly what String.split will do here. I am not sure if one is more efficient than the other,

        Ahmed - the idea behind adding Configuration.getStrings was to re-use existing apis rather than hand-craft it for modularity/reuse, not efficiency. As you can see, we use it in a number of places all over the codebase for similar scenarios to parse comma-delimited values.

        Show
        Arun C Murthy added a comment - Or do you just mean modifying the call to be conf.get(YarnConfiguration.YARN_APPLICATION_CLASSPATH, DEFAULT_YARN_APPLICATION_CLASSPATH), Ahmed - yes. Apologies if I wasn't clear, that was what I meant. which will not make a difference in this case as the default is already picked if the property is not set. Ahmed - the point of doing this is essentially documentation. We follow the convention all over the codebase so that developers quickly grok the flow; and hence the jira itself. Configuration.getString uses StringTokenizer to achieve exactly what String.split will do here. I am not sure if one is more efficient than the other, Ahmed - the idea behind adding Configuration.getStrings was to re-use existing apis rather than hand-craft it for modularity/reuse, not efficiency. As you can see, we use it in a number of places all over the codebase for similar scenarios to parse comma-delimited values.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1135/)
        Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107)
        MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1135/ ) Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107) MAPREDUCE-4422 . YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Ahmed Radwan added a comment -

        Thanks Arun for the clarifications! I have already submitted a new patch yesterday incorporating your comments. Please let me know if you have any other comments.

        Show
        Ahmed Radwan added a comment - Thanks Arun for the clarifications! I have already submitted a new patch yesterday incorporating your comments. Please let me know if you have any other comments.
        Hide
        Alejandro Abdelnur added a comment -

        Ahmed, one NIT I see: The default value should be a String[], doing the "....".split() in teh constant definition. Then when using it as default value there is not split() call over and over.

        Show
        Alejandro Abdelnur added a comment - Ahmed, one NIT I see: The default value should be a String[], doing the "....".split() in teh constant definition. Then when using it as default value there is not split() call over and over.
        Hide
        Ahmed Radwan added a comment -

        Nice NIT! Thanks Tucu. Here is the updated patch.

        Show
        Ahmed Radwan added a comment - Nice NIT! Thanks Tucu. Here is the updated patch.
        Ahmed Radwan made changes -
        Attachment MAPREDUCE-4422_rev4.patch [ 12536485 ]
        Ahmed Radwan made changes -
        Status Reopened [ 4 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12536485/MAPREDUCE-4422_rev4.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2591//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2591//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12536485/MAPREDUCE-4422_rev4.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2591//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2591//console This message is automatically generated.
        Hide
        Alejandro Abdelnur added a comment -

        +1

        Show
        Alejandro Abdelnur added a comment - +1
        Hide
        Alejandro Abdelnur added a comment -

        Thanks Ahmed. Committed to trunk and branch-2

        Show
        Alejandro Abdelnur added a comment - Thanks Ahmed. Committed to trunk and branch-2
        Alejandro Abdelnur made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 2.2.0-alpha [ 12322471 ]
        Fix Version/s 2.1.0-alpha [ 12321442 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2491 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2491/)
        MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2491 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2491/ ) MAPREDUCE-4422 . YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2556 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2556/)
        MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2556 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2556/ ) MAPREDUCE-4422 . YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2512 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2512/)
        MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2512 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2512/ ) MAPREDUCE-4422 . YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1107 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1107/)
        MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1107 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1107/ ) MAPREDUCE-4422 . YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1140 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1140/)
        MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1140 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1140/ ) MAPREDUCE-4422 . YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Ahmed Radwan
            Reporter:
            Arun C Murthy
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development