Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4392

Counters.makeCompactString() changed behavior from 0.20

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 0.23.3
        • Fix Version/s: 0.23.3, 2.0.2-alpha
        • Component/s: mrv2
        • Labels:
          None

          Description

          In 0.20, makeCompactString() returned a comma-separated list, but MAPREDUCE-3697 changed it to be equivalent to makeEscapedCompactString(). Users moving from 0.20 to 0.23 are expecting the original behavior from makeCompactString().

            Activity

            Ascending order - Click to sort in descending order
            Jason Lowe created issue -
            Hide
            Permalink
            Jason Lowe added a comment -

            Patch that restores behavior from 0.20 to Counters.makeCompactString()

            Show
            Jason Lowe added a comment - Patch that restores behavior from 0.20 to Counters.makeCompactString()
            Jason Lowe made changes -
            Field Original Value New Value
            Attachment MAPREDUCE-4392.patch [ 12535224 ]
            Jason Lowe made changes -
            Status Open [ 1 ] Patch Available [ 10002 ]
            Target Version/s 0.23.3, 2.0.1-alpha, trunk [ 12320060, 12321442, 12320360 ]
            Assignee Jason Lowe [ jlowe ]
            Hide
            Permalink
            Hadoop QA added a comment -

            +1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12535224/MAPREDUCE-4392.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 1 new or modified test files.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2544//testReport/
            Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2544//console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12535224/MAPREDUCE-4392.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2544//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2544//console This message is automatically generated.
            Hide
            Permalink
            Robert Joseph Evans added a comment -

            The code is a copy and paste of what was originally there, and the new test ensures that it sill works as expected. +1 I'll check this in.

            Show
            Robert Joseph Evans added a comment - The code is a copy and paste of what was originally there, and the new test ensures that it sill works as expected. +1 I'll check this in.
            Hide
            Permalink
            Robert Joseph Evans added a comment -

            Thanks Jason, I put this into trunk, branch-2, and branch-0.23.

            Show
            Robert Joseph Evans added a comment - Thanks Jason, I put this into trunk, branch-2, and branch-0.23.
            Robert Joseph Evans made changes -
            Status Patch Available [ 10002 ] Resolved [ 5 ]
            Fix Version/s 0.23.3 [ 12320060 ]
            Fix Version/s 2.0.1-alpha [ 12321442 ]
            Fix Version/s 3.0.0 [ 12320355 ]
            Resolution Fixed [ 1 ]
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Common-trunk-Commit #2425 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2425/)
            MAPREDUCE-4392. Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357776)

            Result = SUCCESS
            bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357776
            Files :

            • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
            • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Show
            Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2425 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2425/ ) MAPREDUCE-4392 . Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357776) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357776 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk-Commit #2493 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2493/)
            MAPREDUCE-4392. Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357776)

            Result = SUCCESS
            bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357776
            Files :

            • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
            • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2493 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2493/ ) MAPREDUCE-4392 . Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357776) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357776 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Mapreduce-trunk-Commit #2442 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2442/)
            MAPREDUCE-4392. Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357776)

            Result = FAILURE
            bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357776
            Files :

            • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
            • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Show
            Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2442 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2442/ ) MAPREDUCE-4392 . Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357776) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357776 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk #1095 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1095/)
            MAPREDUCE-4392. Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357776)

            Result = FAILURE
            bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357776
            Files :

            • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
            • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1095 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1095/ ) MAPREDUCE-4392 . Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357776) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357776 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Mapreduce-trunk #1128 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1128/)
            MAPREDUCE-4392. Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357776)

            Result = SUCCESS
            bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357776
            Files :

            • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
            • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Show
            Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1128 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1128/ ) MAPREDUCE-4392 . Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357776) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357776 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-0.23-Build #305 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/305/)
            svn merge -c 1357776 FIXES: MAPREDUCE-4392. Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357779)

            Result = SUCCESS
            bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357779
            Files :

            • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
            • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
            • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #305 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/305/ ) svn merge -c 1357776 FIXES: MAPREDUCE-4392 . Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357779) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357779 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk-Commit #2508 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2508/)
            MAPREDUCE-4392. Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357776)

            Result = SUCCESS
            bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357776
            Files :

            • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
            • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2508 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2508/ ) MAPREDUCE-4392 . Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357776) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357776 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Common-trunk-Commit #2441 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2441/)
            MAPREDUCE-4392. Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357776)

            Result = SUCCESS
            bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357776
            Files :

            • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
            • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Show
            Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2441 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2441/ ) MAPREDUCE-4392 . Counters.makeCompactString() changed behavior from 0.20 (Jason Lowe via bobby) (Revision 1357776) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357776 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java
            Arun C Murthy made changes -
            Fix Version/s 2.0.2-alpha [ 12322471 ]
            Fix Version/s 3.0.0 [ 12320355 ]
            Fix Version/s 2.1.0-alpha [ 12321442 ]
            Arun C Murthy made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                Jason Lowe
                Reporter:
                Jason Lowe
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development