Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4385

FairScheduler.maxTasksToAssign() should check for fairscheduler.assignmultiple.maps < TaskTracker.availableSlots

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.3
    • Fix Version/s: 1.2.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      FairScheduler.maxTasksToAssign() can potentially return a value greater than the available slots. Currently, we rely on canAssignMaps()/canAssignReduces() to reject such requests.

      These additional calls can be avoided by check against the available slots in maxTasksToAssign().

      1. MR-4385.patch
        5 kB
        Karthik Kambatla

        Activity

        Hide
        kkambatl Karthik Kambatla (Inactive) added a comment -

        Uploading a straight-forward patch that returns the minimum of availableSlots() and the number of tasks requested as per config file.

        Testing:

        • Didn't add additional tests
        • Ran TestFairScheduler
        Show
        kkambatl Karthik Kambatla (Inactive) added a comment - Uploading a straight-forward patch that returns the minimum of availableSlots() and the number of tasks requested as per config file. Testing: Didn't add additional tests Ran TestFairScheduler
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12533888/MR-4385.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2534//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533888/MR-4385.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2534//console This message is automatically generated.
        Hide
        kkambatl Karthik Kambatla (Inactive) added a comment -

        Added TestFairScheduler.testMaxTasksToAssign()

        Show
        kkambatl Karthik Kambatla (Inactive) added a comment - Added TestFairScheduler.testMaxTasksToAssign()
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12534461/MR-4385.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2540//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12534461/MR-4385.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2540//console This message is automatically generated.
        Hide
        tucu00 Alejandro Abdelnur added a comment -

        +1

        Show
        tucu00 Alejandro Abdelnur added a comment - +1
        Hide
        tucu00 Alejandro Abdelnur added a comment -

        Thanks Karthik. Committed to branch-1.

        Show
        tucu00 Alejandro Abdelnur added a comment - Thanks Karthik. Committed to branch-1.
        Hide
        mattf Matt Foley added a comment -

        Closed upon release of Hadoop 1.2.0.

        Show
        mattf Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.

          People

          • Assignee:
            kasha Karthik Kambatla
            Reporter:
            kasha Karthik Kambatla
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development