[MAPREDUCE-4368] TaskRunner fails to start jars when the java.library.path contains a quoted path with embedded spaces

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1-win
• Fix Version/s: 1-win
• Component/s: tasktracker
• Labels: newbie patch

Environment

on Windows:
set PATH=%PATH%;"C:\this memorable place".

• Target Version/s: 1-win
• Assignee: John Gordon
• Reporter: John Gordon
• Created: 25/Jun/12 23:53
• Updated: 05/Jul/12 07:15
• Resolved: 05/Jul/12 07:15

Description

TaskRunner splits arguments by space before it adds them back to the vargs list, so it loses all context of quote escaped strings with embedded spaces. This gets fixed up later by wrapping all arguments with " – so you get something like java "-D<opt>=<value>". This is problematic for paths with embedded spaces, where we end up creating "-D<opt>=<first part" "last part>". To java, the jar being run is last part. So with the environment above, you will see "ClassNoDefFoundError: memorable" and the jar will fail to start. In this particular case, we know that java.libarary.path contains paths and the tests often use %PATH% to seed this, so the fix is to remove embedded quotes in listed path elements because we know the aggregate will be quoted when the JVM is started.

Issue Links

• is part of: HADOOP-8079 Proposal for enhancements to Hadoop for Windows Server and Windows Azure development and runtime environments