Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.3, 2.0.0-alpha
    • Fix Version/s: 1.2.0, 2.0.2-alpha
    • Component/s: mrv1, mrv2
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Usecase: Read the start/end-time of a particular job.

      Currently, one has to iterate through JobClient.getAllJobStatuses() and iterate through them. JobClient.getJob(JobID) returns RunningJob, which doesn't hold the job's start time.

      Adding RunningJob.getJobStatus() solves the issue.

      1. MR-4355_mr1.patch
        3 kB
        Karthik Kambatla
      2. MR-4355_mr2.patch
        6 kB
        Karthik Kambatla

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2441 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2441/)
        MAPREDUCE-4355. Add RunningJob.getJobStatus() (kkambatl via tucu) (Revision 1357723)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357723
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/RunningJob.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestNetworkedJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2441 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2441/ ) MAPREDUCE-4355 . Add RunningJob.getJobStatus() (kkambatl via tucu) (Revision 1357723) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357723 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/RunningJob.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestNetworkedJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2508 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2508/)
        MAPREDUCE-4355. Add RunningJob.getJobStatus() (kkambatl via tucu) (Revision 1357723)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357723
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/RunningJob.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestNetworkedJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2508 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2508/ ) MAPREDUCE-4355 . Add RunningJob.getJobStatus() (kkambatl via tucu) (Revision 1357723) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357723 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/RunningJob.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestNetworkedJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1128 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1128/)
        MAPREDUCE-4355. Add RunningJob.getJobStatus() (kkambatl via tucu) (Revision 1357723)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357723
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/RunningJob.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestNetworkedJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1128 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1128/ ) MAPREDUCE-4355 . Add RunningJob.getJobStatus() (kkambatl via tucu) (Revision 1357723) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357723 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/RunningJob.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestNetworkedJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1095 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1095/)
        MAPREDUCE-4355. Add RunningJob.getJobStatus() (kkambatl via tucu) (Revision 1357723)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357723
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/RunningJob.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestNetworkedJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1095 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1095/ ) MAPREDUCE-4355 . Add RunningJob.getJobStatus() (kkambatl via tucu) (Revision 1357723) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357723 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/RunningJob.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestNetworkedJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2441 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2441/)
        MAPREDUCE-4355. Add RunningJob.getJobStatus() (kkambatl via tucu) (Revision 1357723)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357723
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/RunningJob.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestNetworkedJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2441 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2441/ ) MAPREDUCE-4355 . Add RunningJob.getJobStatus() (kkambatl via tucu) (Revision 1357723) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357723 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/RunningJob.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestNetworkedJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2492 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2492/)
        MAPREDUCE-4355. Add RunningJob.getJobStatus() (kkambatl via tucu) (Revision 1357723)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357723
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/RunningJob.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestNetworkedJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2492 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2492/ ) MAPREDUCE-4355 . Add RunningJob.getJobStatus() (kkambatl via tucu) (Revision 1357723) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357723 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/RunningJob.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestNetworkedJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2424 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2424/)
        MAPREDUCE-4355. Add RunningJob.getJobStatus() (kkambatl via tucu) (Revision 1357723)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357723
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/RunningJob.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestNetworkedJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2424 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2424/ ) MAPREDUCE-4355 . Add RunningJob.getJobStatus() (kkambatl via tucu) (Revision 1357723) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357723 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/RunningJob.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestNetworkedJob.java
        Hide
        Alejandro Abdelnur added a comment -

        Thanks Karthik. Committed to trunk, branch-2 and branch-1.

        Show
        Alejandro Abdelnur added a comment - Thanks Karthik. Committed to trunk, branch-2 and branch-1.
        Hide
        Alejandro Abdelnur added a comment -

        +1

        Show
        Alejandro Abdelnur added a comment - +1
        Hide
        Karthik Kambatla added a comment -

        Re-submitting the patch to make sure Jenkins is fine with it.

        The tests it complained earlier about were removed from trunk (and have nothing to do with this patch).

        Show
        Karthik Kambatla added a comment - Re-submitting the patch to make sure Jenkins is fine with it. The tests it complained earlier about were removed from trunk (and have nothing to do with this patch).
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12533921/MR-4355_mr2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

        org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl
        org.apache.hadoop.mapred.jobcontrol.TestLocalJobControl

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2530//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2530//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533921/MR-4355_mr2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl org.apache.hadoop.mapred.jobcontrol.TestLocalJobControl +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2530//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2530//console This message is automatically generated.
        Hide
        Karthik Kambatla added a comment -

        Patch with updated test:

        • TestNetworkedJob defines its own MR job, independent of other tests
        Show
        Karthik Kambatla added a comment - Patch with updated test: TestNetworkedJob defines its own MR job, independent of other tests
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12533864/MR-4355_mr2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2527//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2527//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533864/MR-4355_mr2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2527//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2527//console This message is automatically generated.
        Hide
        Karthik Kambatla added a comment -

        Updated patch for MR2.

        • RunningJob.getJobStatus()
        • TestNetworkedJob uses MiniMRClientCluster
        Show
        Karthik Kambatla added a comment - Updated patch for MR2. RunningJob.getJobStatus() TestNetworkedJob uses MiniMRClientCluster
        Hide
        Alejandro Abdelnur added a comment -

        regarding changing updateStatus() to ensureFreshStatus(), no I think updateStatus() is more appropriate.

        Show
        Alejandro Abdelnur added a comment - regarding changing updateStatus() to ensureFreshStatus(), no I think updateStatus() is more appropriate.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12533723/MR-4355_mr1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2524//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533723/MR-4355_mr1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2524//console This message is automatically generated.
        Hide
        Karthik Kambatla added a comment -

        Updated patch for MR1.

        ensureFreshStatus() calls updateStatus() only after a particular amount of time has passed since previous updateStatus().

        For getJobStatus(), to get the latest status, we need to call updateStatus(). Do you suggest calling ensureFreshStatus() instead for consistency?

        Show
        Karthik Kambatla added a comment - Updated patch for MR1. ensureFreshStatus() calls updateStatus() only after a particular amount of time has passed since previous updateStatus(). For getJobStatus(), to get the latest status, we need to call updateStatus(). Do you suggest calling ensureFreshStatus() instead for consistency?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12533712/MR-4355_mr2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2523//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2523//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533712/MR-4355_mr2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2523//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2523//console This message is automatically generated.
        Hide
        Alejandro Abdelnur added a comment -

        The mr1 patch has a few false changes in the test class, please revert those.

        Please add a simple testcase for the mr2 case.

        Also, in the mr1 patch you are using 'updateStatus()' to update the jobstatus before returning the object. the method above uses 'ensureFreshStatus()', why the difference?

        Show
        Alejandro Abdelnur added a comment - The mr1 patch has a few false changes in the test class, please revert those. Please add a simple testcase for the mr2 case. Also, in the mr1 patch you are using 'updateStatus()' to update the jobstatus before returning the object. the method above uses 'ensureFreshStatus()', why the difference?
        Hide
        Karthik Kambatla added a comment -

        Submitting the MR1 and MR2 patches.

        • No tests for MR2 - just added a wrapper call to Job.getStatus()
        Show
        Karthik Kambatla added a comment - Submitting the MR1 and MR2 patches. No tests for MR2 - just added a wrapper call to Job.getStatus()
        Hide
        Arun C Murthy added a comment -

        Arun, it might be cleaner to add RunningJob.getJobStatus() instead of adding startTime, endTime fields to RunningJob and redundantly maintaining them.

        +1, good point!

        Show
        Arun C Murthy added a comment - Arun, it might be cleaner to add RunningJob.getJobStatus() instead of adding startTime, endTime fields to RunningJob and redundantly maintaining them. +1, good point!
        Hide
        Alejandro Abdelnur added a comment - - edited

        reverted from trunk, branch-2 and branch-1.

        Show
        Alejandro Abdelnur added a comment - - edited reverted from trunk, branch-2 and branch-1.
        Hide
        Alejandro Abdelnur added a comment -

        I'll revert the current commit WED morning.

        I think adding a getJobStatus() method to RunningJob would be more comprehensive that just adding startTime(). Arun, would you agree with that?

        Show
        Alejandro Abdelnur added a comment - I'll revert the current commit WED morning. I think adding a getJobStatus() method to RunningJob would be more comprehensive that just adding startTime(). Arun, would you agree with that?
        Hide
        Karthik Kambatla added a comment -

        Arun, it might be cleaner to add RunningJob.getJobStatus() instead of adding startTime, endTime fields to RunningJob and redundantly maintaining them.

        Thanks.

        Show
        Karthik Kambatla added a comment - Arun, it might be cleaner to add RunningJob.getJobStatus() instead of adding startTime, endTime fields to RunningJob and redundantly maintaining them. Thanks.
        Hide
        Karthik Kambatla added a comment -

        Alejandro, sorry for the trouble. We need to revert the earlier commit.

        Thanks.

        Show
        Karthik Kambatla added a comment - Alejandro, sorry for the trouble. We need to revert the earlier commit. Thanks.
        Hide
        Arun C Murthy added a comment -

        Adding startTime to RunningJob does definitely help. By returning JobStatus, we would be able to serve user requests for start time on old, non-running jobs as well.

        Not really, the old jobs are 'retired' and won't be served after a while. JobHistory is the option there.

        So, please, do change this to add startTime to RunningJob. Thanks.

        Show
        Arun C Murthy added a comment - Adding startTime to RunningJob does definitely help. By returning JobStatus, we would be able to serve user requests for start time on old, non-running jobs as well. Not really, the old jobs are 'retired' and won't be served after a while. JobHistory is the option there. So, please, do change this to add startTime to RunningJob. Thanks.
        Hide
        Karthik Kambatla added a comment -

        Robert, sorry about the warnings - I ll upload a patch to MAPREDUCE-4373 at the earliest.

        Thanks

        Show
        Karthik Kambatla added a comment - Robert, sorry about the warnings - I ll upload a patch to MAPREDUCE-4373 at the earliest. Thanks
        Hide
        Karthik Kambatla added a comment -

        Arun,

        Adding startTime to RunningJob does definitely help. By returning JobStatus, we would be able to serve user requests for start time on old, non-running jobs as well.

        If you think we should go the RunningJob route, I could redo it that way. However, it might be a little ambiguous for users.

        Thanks.

        Show
        Karthik Kambatla added a comment - Arun, Adding startTime to RunningJob does definitely help. By returning JobStatus, we would be able to serve user requests for start time on old, non-running jobs as well. If you think we should go the RunningJob route, I could redo it that way. However, it might be a little ambiguous for users. Thanks.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1121 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1121/)
        MAPREDUCE-4355. Add JobStatus getJobStatus(JobID) to JobClient. (kkambatl via tucu) (Revision 1353757)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1353757
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClientGetJob.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Cluster.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1121 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1121/ ) MAPREDUCE-4355 . Add JobStatus getJobStatus(JobID) to JobClient. (kkambatl via tucu) (Revision 1353757) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1353757 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClientGetJob.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Cluster.java
        Hide
        Robert Joseph Evans added a comment -

        It looks like this added in two new javadoc warnings

        MAPREDUCE-4373

        Show
        Robert Joseph Evans added a comment - It looks like this added in two new javadoc warnings MAPREDUCE-4373
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1088 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1088/)
        MAPREDUCE-4355. Add JobStatus getJobStatus(JobID) to JobClient. (kkambatl via tucu) (Revision 1353757)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1353757
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClientGetJob.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Cluster.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1088 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1088/ ) MAPREDUCE-4355 . Add JobStatus getJobStatus(JobID) to JobClient. (kkambatl via tucu) (Revision 1353757) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1353757 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClientGetJob.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Cluster.java
        Hide
        Arun C Murthy added a comment -

        IAC, we could avoid the new API by adding startTime to RunningJob if that is the current drawback?

        Show
        Arun C Murthy added a comment - IAC, we could avoid the new API by adding startTime to RunningJob if that is the current drawback?
        Hide
        Arun C Murthy added a comment -

        My bad, I read the patch wrong as removing getJob. Apologies for the noise.

        Show
        Arun C Murthy added a comment - My bad, I read the patch wrong as removing getJob. Apologies for the noise.
        Hide
        Arun C Murthy added a comment -

        I'm sorry, but we cannot make an incompatible change to JobClient which is a public API, at least in hadoop-1.x

        -1 on this change.

        This will break a number of existing apis.

        It seems we cud just add start-time to RunningJob if necessary.

        Alejandro - do you mind reverting this change since it breaks compatibility? Thanks.

        Show
        Arun C Murthy added a comment - I'm sorry, but we cannot make an incompatible change to JobClient which is a public API, at least in hadoop-1.x -1 on this change. This will break a number of existing apis. It seems we cud just add start-time to RunningJob if necessary. Alejandro - do you mind reverting this change since it breaks compatibility? Thanks.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2405 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2405/)
        MAPREDUCE-4355. Add JobStatus getJobStatus(JobID) to JobClient. (kkambatl via tucu) (Revision 1353757)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1353757
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClientGetJob.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Cluster.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2405 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2405/ ) MAPREDUCE-4355 . Add JobStatus getJobStatus(JobID) to JobClient. (kkambatl via tucu) (Revision 1353757) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1353757 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClientGetJob.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Cluster.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2387 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2387/)
        MAPREDUCE-4355. Add JobStatus getJobStatus(JobID) to JobClient. (kkambatl via tucu) (Revision 1353757)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1353757
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClientGetJob.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Cluster.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2387 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2387/ ) MAPREDUCE-4355 . Add JobStatus getJobStatus(JobID) to JobClient. (kkambatl via tucu) (Revision 1353757) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1353757 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClientGetJob.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Cluster.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2456 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2456/)
        MAPREDUCE-4355. Add JobStatus getJobStatus(JobID) to JobClient. (kkambatl via tucu) (Revision 1353757)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1353757
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClientGetJob.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Cluster.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2456 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2456/ ) MAPREDUCE-4355 . Add JobStatus getJobStatus(JobID) to JobClient. (kkambatl via tucu) (Revision 1353757) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1353757 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClientGetJob.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Cluster.java
        Hide
        Alejandro Abdelnur added a comment -

        Thanks Karthik. Committed to trunk, branch-1 & branch-2.

        Show
        Alejandro Abdelnur added a comment - Thanks Karthik. Committed to trunk, branch-1 & branch-2.
        Hide
        Alejandro Abdelnur added a comment -

        +1

        Show
        Alejandro Abdelnur added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12532926/MR-4355_mr2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 15 warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2493//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2493//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12532926/MR-4355_mr2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 javadoc. The javadoc tool appears to have generated 15 warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2493//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2493//console This message is automatically generated.
        Hide
        Karthik Kambatla added a comment -

        Devaraj,

        Thanks for your comments. I uploaded another patch with the suggested changes, and updated getJob(JobID) also accordingly.

        Show
        Karthik Kambatla added a comment - Devaraj, Thanks for your comments. I uploaded another patch with the suggested changes, and updated getJob(JobID) also accordingly.
        Hide
        Devaraj K added a comment -

        It is good to have this API. Thanks for providing patch.

        There are few minor comments about the patch

        1. Can we get the JobStatus directly from Cluster instance instead of getting the Job instance and getting the JobStatus from Job instance? In Cluster.java, getJob(JobID jobId) API is getting the JobStatus and creating the Job instance using the JobStatus, again you are getting the JobStatus from Job instance.

        2. I don't see any use of having the jobid as final.

        +  public JobStatus getJobStatus(final JobID jobid) throws IOException {
        

        3. Can you rename the jobid variable name to jobId, anyway it is minor you can take the final decision.

        Show
        Devaraj K added a comment - It is good to have this API. Thanks for providing patch. There are few minor comments about the patch 1. Can we get the JobStatus directly from Cluster instance instead of getting the Job instance and getting the JobStatus from Job instance? In Cluster.java, getJob(JobID jobId) API is getting the JobStatus and creating the Job instance using the JobStatus, again you are getting the JobStatus from Job instance. 2. I don't see any use of having the jobid as final. + public JobStatus getJobStatus(final JobID jobid) throws IOException { 3. Can you rename the jobid variable name to jobId, anyway it is minor you can take the final decision.
        Hide
        Jason Lowe added a comment -

        The 13 javadoc warnings were caused by MAPREDUCE-3868, see HDFS-3550.

        Show
        Jason Lowe added a comment - The 13 javadoc warnings were caused by MAPREDUCE-3868 , see HDFS-3550 .
        Hide
        Karthik Kambatla added a comment -

        W.r.t MR2 patch, Eclipse shows the same number of warnings with and without the patch. Any pointers as to where I should look for these extra warnings Hudson reports?

        Otherwise, I believe the patches are good to go.

        Show
        Karthik Kambatla added a comment - W.r.t MR2 patch, Eclipse shows the same number of warnings with and without the patch. Any pointers as to where I should look for these extra warnings Hudson reports? Otherwise, I believe the patches are good to go.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12532781/MR-4355_mr1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2489//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12532781/MR-4355_mr1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2489//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12532743/MR-4355_mr2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 13 warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2485//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2485//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12532743/MR-4355_mr2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 javadoc. The javadoc tool appears to have generated 13 warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2485//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2485//console This message is automatically generated.
        Hide
        Karthik Kambatla added a comment -

        Submitting to make sure Hudson doesn't complain

        Show
        Karthik Kambatla added a comment - Submitting to make sure Hudson doesn't complain
        Hide
        Karthik Kambatla added a comment -

        Uploading a patch for MR2: MR-4355_mr2.patch.

        The patch

        • implements JobClient.getJobStatus(JobID)
        • renames TestJobClientGetJob to TestJobClient
        • adds a test for getJobStatus to the renamed test file
        Show
        Karthik Kambatla added a comment - Uploading a patch for MR2: MR-4355_mr2.patch. The patch implements JobClient.getJobStatus(JobID) renames TestJobClientGetJob to TestJobClient adds a test for getJobStatus to the renamed test file

          People

          • Assignee:
            Karthik Kambatla
            Reporter:
            Karthik Kambatla
          • Votes:
            0 Vote for this issue
            Watchers:
            13 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development