Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4272

SortedRanges.Range#compareTo is not spec compliant

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.3
    • Fix Version/s: 3.0.0, 2.0.3-alpha, 1.1.2
    • Component/s: task
    • Labels:

      Description

      SortedRanges.Range#compareTo does not satisfy the requirement of Comparable#compareTo, where "the implementor must ensure

      sgn(x.compareTo(y)) == -sgn(y.compareTo(x))

      for all x and y."

      This is manifested as TestStreamingBadRecords failures in alternative JDKs.

      1. mapreduce-4272-branch-1.0.patch
        1 kB
        Luke Lu
      2. mapreduce-4272-branch-2.patch
        1 kB
        Yu Gao
      3. mapreduce-4272.patch
        1 kB
        Yu Gao

        Issue Links

          Activity

          Hide
          Luke Lu added a comment -

          Looks like build 1292 failed for many other changes unrelated to this as well. https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1305/ which includes this change seems to be fine.

          Show
          Luke Lu added a comment - Looks like build 1292 failed for many other changes unrelated to this as well. https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1305/ which includes this change seems to be fine.
          Hide
          Matt Foley added a comment -

          Looks like the integration with trunk / 2.0 was not successful. Keeping bug open for that.
          Fix accepted into 1.1.2.

          Show
          Matt Foley added a comment - Looks like the integration with trunk / 2.0 was not successful. Keeping bug open for that. Fix accepted into 1.1.2.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1292 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1292/)
          MAPREDUCE-4272. SortedRanges.Range#compareTo was not spec compliant. (Yu Gao via llu) (Revision 1425180)

          Result = FAILURE
          llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1425180
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/SortedRanges.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1292 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1292/ ) MAPREDUCE-4272 . SortedRanges.Range#compareTo was not spec compliant. (Yu Gao via llu) (Revision 1425180) Result = FAILURE llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1425180 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/SortedRanges.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1262 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1262/)
          MAPREDUCE-4272. SortedRanges.Range#compareTo was not spec compliant. (Yu Gao via llu) (Revision 1425180)

          Result = FAILURE
          llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1425180
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/SortedRanges.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1262 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1262/ ) MAPREDUCE-4272 . SortedRanges.Range#compareTo was not spec compliant. (Yu Gao via llu) (Revision 1425180) Result = FAILURE llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1425180 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/SortedRanges.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #73 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/73/)
          MAPREDUCE-4272. SortedRanges.Range#compareTo was not spec compliant. (Yu Gao via llu) (Revision 1425180)

          Result = SUCCESS
          llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1425180
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/SortedRanges.java
          Show
          Hudson added a comment - Integrated in Hadoop-Yarn-trunk #73 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/73/ ) MAPREDUCE-4272 . SortedRanges.Range#compareTo was not spec compliant. (Yu Gao via llu) (Revision 1425180) Result = SUCCESS llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1425180 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/SortedRanges.java
          Hide
          Luke Lu added a comment -

          +1. Committed to branch-

          {1,1.1}

          . Thanks Yu!

          Show
          Luke Lu added a comment - +1. Committed to branch- {1,1.1} . Thanks Yu!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3152 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3152/)
          MAPREDUCE-4272. SortedRanges.Range#compareTo was not spec compliant. (Yu Gao via llu) (Revision 1425180)

          Result = SUCCESS
          llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1425180
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/SortedRanges.java
          Show
          Hudson added a comment - Integrated in Hadoop-trunk-Commit #3152 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3152/ ) MAPREDUCE-4272 . SortedRanges.Range#compareTo was not spec compliant. (Yu Gao via llu) (Revision 1425180) Result = SUCCESS llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1425180 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/SortedRanges.java
          Hide
          Yu Gao added a comment -

          Thanks Luke for the review. This patch fixes TestStreamingBadRecords failure in alternative JDKs, like IBM JDK.

          Show
          Yu Gao added a comment - Thanks Luke for the review. This patch fixes TestStreamingBadRecords failure in alternative JDKs, like IBM JDK.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12551775/mapreduce-4272.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2981//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2981//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12551775/mapreduce-4272.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2981//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2981//console This message is automatically generated.
          Hide
          Luke Lu added a comment -

          The patch lgtm. Submitting for jenkins test patch.

          Show
          Luke Lu added a comment - The patch lgtm. Submitting for jenkins test patch.

            People

            • Assignee:
              Yu Gao
              Reporter:
              Luke Lu
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development