Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4091

tools testcases failing because of MAPREDUCE-4082

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: build, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      MAPREDUCE-4082 moved the generated-classpath file used by MRApp from the main classpath to the test classpath.

      The objective of MAPREDUCE-4082 was to remove the generated-classpath file from the hadoop-mapreduce-client-app JAR. I've thought that moving it to the test-classpath would do the trick.

      This is breaking tools testcases (most likely) because of different classloader being used by maven for main classpath and test classpath.

      1. MAPREDUCE-4091.patch
        1 kB
        Alejandro Abdelnur

        Activity

        Alejandro Abdelnur created issue -
        Hide
        Alejandro Abdelnur added a comment -

        The generated-classpath file has a meaning for running testcases in the current project. If downstream projects want to leverage that file, they have create it in their project (i.e. oozie-core creates one to be able to use MiniMR).

        Having the generated-classpath file bundled in the JAR is pointless, and as MAPREDUCE-4082 stated, pollutes the classpath big time.

        An alternate way to achieve not having the generated-classpath file in the JAR is to excluded it in the maven-jar-plugin.

        Show
        Alejandro Abdelnur added a comment - The generated-classpath file has a meaning for running testcases in the current project. If downstream projects want to leverage that file, they have create it in their project (i.e. oozie-core creates one to be able to use MiniMR). Having the generated-classpath file bundled in the JAR is pointless, and as MAPREDUCE-4082 stated, pollutes the classpath big time. An alternate way to achieve not having the generated-classpath file in the JAR is to excluded it in the maven-jar-plugin.
        Hide
        Alejandro Abdelnur added a comment -

        the tools (streaming & archives) failing testcases are passing again.

        and the hadoop-mapreduce-client-app JAR does not have the mrapp-generated-classpath file in it.

        Show
        Alejandro Abdelnur added a comment - the tools (streaming & archives) failing testcases are passing again. and the hadoop-mapreduce-client-app JAR does not have the mrapp-generated-classpath file in it.
        Alejandro Abdelnur made changes -
        Field Original Value New Value
        Attachment MAPREDUCE-4091.patch [ 12520672 ]
        Alejandro Abdelnur made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Mahadev konar added a comment -

        +1 for the patch. Looks good.

        Show
        Mahadev konar added a comment - +1 for the patch. Looks good.
        Hide
        Alejandro Abdelnur added a comment -

        committed to trunk & branch-2

        Show
        Alejandro Abdelnur added a comment - committed to trunk & branch-2
        Alejandro Abdelnur made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2031 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2031/)
        MAPREDUCE-4091. tools testcases failing because of MAPREDUCE-4082 (tucu) (Revision 1307623)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307623
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2031 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2031/ ) MAPREDUCE-4091 . tools testcases failing because of MAPREDUCE-4082 (tucu) (Revision 1307623) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307623 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1956 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1956/)
        MAPREDUCE-4091. tools testcases failing because of MAPREDUCE-4082 (tucu) (Revision 1307623)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307623
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1956 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1956/ ) MAPREDUCE-4091 . tools testcases failing because of MAPREDUCE-4082 (tucu) (Revision 1307623) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307623 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1969 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1969/)
        MAPREDUCE-4091. tools testcases failing because of MAPREDUCE-4082 (tucu) (Revision 1307623)

        Result = ABORTED
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307623
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1969 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1969/ ) MAPREDUCE-4091 . tools testcases failing because of MAPREDUCE-4082 (tucu) (Revision 1307623) Result = ABORTED tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307623 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12520672/MAPREDUCE-4091.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.mapreduce.v2.TestMRJobs
        org.apache.hadoop.mapred.TestMiniMRBringup
        org.apache.hadoop.mapred.TestMiniMRChildTask
        org.apache.hadoop.mapred.TestReduceFetch
        org.apache.hadoop.mapred.TestReduceFetchFromPartialMem
        org.apache.hadoop.mapred.TestJobCounters
        org.apache.hadoop.mapreduce.TestChild
        org.apache.hadoop.mapred.TestMiniMRClientCluster
        org.apache.hadoop.mapreduce.v2.TestMROldApiJobs
        org.apache.hadoop.mapreduce.v2.TestSpeculativeExecution
        org.apache.hadoop.mapreduce.lib.output.TestJobOutputCommitter
        org.apache.hadoop.mapred.TestClientRedirect
        org.apache.hadoop.mapred.TestLazyOutput
        org.apache.hadoop.mapred.TestJobCleanup
        org.apache.hadoop.mapreduce.TestMapReduceLazyOutput
        org.apache.hadoop.mapred.TestSpecialCharactersInOutputPath
        org.apache.hadoop.mapreduce.v2.TestRMNMInfo
        org.apache.hadoop.mapreduce.v2.TestNonExistentJob
        org.apache.hadoop.mapred.TestJobSysDirWithDFS
        org.apache.hadoop.mapreduce.v2.TestUberAM
        org.apache.hadoop.mapreduce.v2.TestMiniMRProxyUser
        org.apache.hadoop.mapreduce.security.TestJHSSecurity

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2120//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2120//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520672/MAPREDUCE-4091.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.mapreduce.v2.TestMRJobs org.apache.hadoop.mapred.TestMiniMRBringup org.apache.hadoop.mapred.TestMiniMRChildTask org.apache.hadoop.mapred.TestReduceFetch org.apache.hadoop.mapred.TestReduceFetchFromPartialMem org.apache.hadoop.mapred.TestJobCounters org.apache.hadoop.mapreduce.TestChild org.apache.hadoop.mapred.TestMiniMRClientCluster org.apache.hadoop.mapreduce.v2.TestMROldApiJobs org.apache.hadoop.mapreduce.v2.TestSpeculativeExecution org.apache.hadoop.mapreduce.lib.output.TestJobOutputCommitter org.apache.hadoop.mapred.TestClientRedirect org.apache.hadoop.mapred.TestLazyOutput org.apache.hadoop.mapred.TestJobCleanup org.apache.hadoop.mapreduce.TestMapReduceLazyOutput org.apache.hadoop.mapred.TestSpecialCharactersInOutputPath org.apache.hadoop.mapreduce.v2.TestRMNMInfo org.apache.hadoop.mapreduce.v2.TestNonExistentJob org.apache.hadoop.mapred.TestJobSysDirWithDFS org.apache.hadoop.mapreduce.v2.TestUberAM org.apache.hadoop.mapreduce.v2.TestMiniMRProxyUser org.apache.hadoop.mapreduce.security.TestJHSSecurity +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2120//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2120//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1001 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1001/)
        MAPREDUCE-4091. tools testcases failing because of MAPREDUCE-4082 (tucu) (Revision 1307623)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307623
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1001 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1001/ ) MAPREDUCE-4091 . tools testcases failing because of MAPREDUCE-4082 (tucu) (Revision 1307623) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307623 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1036 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1036/)
        MAPREDUCE-4091. tools testcases failing because of MAPREDUCE-4082 (tucu) (Revision 1307623)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307623
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1036 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1036/ ) MAPREDUCE-4091 . tools testcases failing because of MAPREDUCE-4082 (tucu) (Revision 1307623) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307623 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Robert Joseph Evans added a comment -

        I pulled this into 0.23.3

        Show
        Robert Joseph Evans added a comment - I pulled this into 0.23.3
        Robert Joseph Evans made changes -
        Fix Version/s 0.23.3 [ 12320060 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #350 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/350/)
        svn merge -c 1307124, 1307623, 1309583 FIXES: MAPREDUCE-4082 MAPREDUCE-4091 and MAPREDUCE-4097 hadoop-mapreduce-client-app's mrapp-generated-classpath file should not be in the module JAR (tucu) (Revision 1375190)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375190
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/v2/util/TestMRApps.java
        • /hadoop/common/branches/branch-0.23/hadoop-project/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #350 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/350/ ) svn merge -c 1307124, 1307623, 1309583 FIXES: MAPREDUCE-4082 MAPREDUCE-4091 and MAPREDUCE-4097 hadoop-mapreduce-client-app's mrapp-generated-classpath file should not be in the module JAR (tucu) (Revision 1375190) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375190 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/v2/util/TestMRApps.java /hadoop/common/branches/branch-0.23/hadoop-project/pom.xml
        Arun C Murthy made changes -
        Fix Version/s 2.0.2-alpha [ 12322471 ]
        Fix Version/s 2.0.0-alpha [ 12320354 ]

          People

          • Assignee:
            Alejandro Abdelnur
            Reporter:
            Alejandro Abdelnur
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development