Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3935

Annotate Counters.Counter and Counters.Group as @Public

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha
    • Component/s: client
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      For clarity these inner classes should be marked as public stable.

        Activity

        Hide
        Tom White added a comment -

        Trivial patch.

        Show
        Tom White added a comment - Trivial patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12516369/MAPREDUCE-3935.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1951//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1951//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516369/MAPREDUCE-3935.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1951//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1951//console This message is automatically generated.
        Hide
        Tom White added a comment -

        No tests since this is a documentation patch.

        Show
        Tom White added a comment - No tests since this is a documentation patch.
        Hide
        Robert Joseph Evans added a comment -

        +1 the patch looks good me.

        Show
        Robert Joseph Evans added a comment - +1 the patch looks good me.
        Hide
        Tom White added a comment -

        I've just committed this. Thanks for taking a look, Robert.

        Show
        Tom White added a comment - I've just committed this. Thanks for taking a look, Robert.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1823 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1823/)
        MAPREDUCE-3935. Annotate Counters.Counter and Counters.Group as @Public. (Revision 1296523)

        Result = SUCCESS
        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296523
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1823 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1823/ ) MAPREDUCE-3935 . Annotate Counters.Counter and Counters.Group as @Public. (Revision 1296523) Result = SUCCESS tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296523 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1897 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1897/)
        MAPREDUCE-3935. Annotate Counters.Counter and Counters.Group as @Public. (Revision 1296523)

        Result = SUCCESS
        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296523
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1897 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1897/ ) MAPREDUCE-3935 . Annotate Counters.Counter and Counters.Group as @Public. (Revision 1296523) Result = SUCCESS tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296523 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #620 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/620/)
        Merge -r 1296522:1296523 from trunk to branch-23. Fixes: MAPREDUCE-3935. (Revision 1296524)

        Result = SUCCESS
        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296524
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #620 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/620/ ) Merge -r 1296522:1296523 from trunk to branch-23. Fixes: MAPREDUCE-3935 . (Revision 1296524) Result = SUCCESS tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296524 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #631 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/631/)
        Merge -r 1296522:1296523 from trunk to branch-23. Fixes: MAPREDUCE-3935. (Revision 1296524)

        Result = SUCCESS
        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296524
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #631 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/631/ ) Merge -r 1296522:1296523 from trunk to branch-23. Fixes: MAPREDUCE-3935 . (Revision 1296524) Result = SUCCESS tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296524 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1830 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1830/)
        MAPREDUCE-3935. Annotate Counters.Counter and Counters.Group as @Public. (Revision 1296523)

        Result = ABORTED
        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296523
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1830 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1830/ ) MAPREDUCE-3935 . Annotate Counters.Counter and Counters.Group as @Public. (Revision 1296523) Result = ABORTED tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296523 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #630 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/630/)
        Merge -r 1296522:1296523 from trunk to branch-23. Fixes: MAPREDUCE-3935. (Revision 1296524)

        Result = ABORTED
        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296524
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #630 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/630/ ) Merge -r 1296522:1296523 from trunk to branch-23. Fixes: MAPREDUCE-3935 . (Revision 1296524) Result = ABORTED tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296524 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #186 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/186/)
        Merge -r 1296522:1296523 from trunk to branch-23. Fixes: MAPREDUCE-3935. (Revision 1296524)

        Result = SUCCESS
        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296524
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #186 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/186/ ) Merge -r 1296522:1296523 from trunk to branch-23. Fixes: MAPREDUCE-3935 . (Revision 1296524) Result = SUCCESS tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296524 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #973 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/973/)
        MAPREDUCE-3935. Annotate Counters.Counter and Counters.Group as @Public. (Revision 1296523)

        Result = SUCCESS
        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296523
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #973 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/973/ ) MAPREDUCE-3935 . Annotate Counters.Counter and Counters.Group as @Public. (Revision 1296523) Result = SUCCESS tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296523 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #214 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/214/)
        Merge -r 1296522:1296523 from trunk to branch-23. Fixes: MAPREDUCE-3935. (Revision 1296524)

        Result = FAILURE
        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296524
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #214 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/214/ ) Merge -r 1296522:1296523 from trunk to branch-23. Fixes: MAPREDUCE-3935 . (Revision 1296524) Result = FAILURE tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296524 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1008 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1008/)
        MAPREDUCE-3935. Annotate Counters.Counter and Counters.Group as @Public. (Revision 1296523)

        Result = SUCCESS
        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296523
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1008 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1008/ ) MAPREDUCE-3935 . Annotate Counters.Counter and Counters.Group as @Public. (Revision 1296523) Result = SUCCESS tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296523 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java

          People

          • Assignee:
            Tom White
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development