Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 0.23.1
    • Fix Version/s: 2.0.0-alpha
    • Component/s: mrv2
    • Labels:
      None

      Description

      The Service interface doesn't describe what it does.

      The ServiceStateChangeListener interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.

      Document for others

      1. MAPREDUCE-3909.patch
        8 kB
        Steve Loughran
      2. MAPREDUCE-3909.patch
        1 kB
        Steve Loughran

        Activity

        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Arun C Murthy made changes -
        Fix Version/s 2.0.0 [ 12320354 ]
        Fix Version/s 0.24.0 [ 12317654 ]
        Fix Version/s 0.23.3 [ 12320060 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1004 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1004/)
        MAPREDUCE-3909 (Revision 1294219)

        Result = SUCCESS
        stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1004 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1004/ ) MAPREDUCE-3909 (Revision 1294219) Result = SUCCESS stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #210 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/210/)
        MAPREDUCE-3909 (Revision 1294220)

        Result = FAILURE
        stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #210 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/210/ ) MAPREDUCE-3909 (Revision 1294220) Result = FAILURE stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #969 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/969/)
        MAPREDUCE-3909 (Revision 1294219)

        Result = UNSTABLE
        stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #969 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/969/ ) MAPREDUCE-3909 (Revision 1294219) Result = UNSTABLE stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #182 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/182/)
        MAPREDUCE-3909 (Revision 1294220)

        Result = SUCCESS
        stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #182 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/182/ ) MAPREDUCE-3909 (Revision 1294220) Result = SUCCESS stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1796 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1796/)
        MAPREDUCE-3909 (Revision 1294219)

        Result = ABORTED
        stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1796 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1796/ ) MAPREDUCE-3909 (Revision 1294219) Result = ABORTED stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #602 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/602/)
        MAPREDUCE-3909 (Revision 1294220)

        Result = ABORTED
        stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #602 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/602/ ) MAPREDUCE-3909 (Revision 1294220) Result = ABORTED stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1785 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1785/)
        MAPREDUCE-3909 (Revision 1294219)

        Result = SUCCESS
        stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1785 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1785/ ) MAPREDUCE-3909 (Revision 1294219) Result = SUCCESS stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #601 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/601/)
        MAPREDUCE-3909 (Revision 1294220)

        Result = SUCCESS
        stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #601 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/601/ ) MAPREDUCE-3909 (Revision 1294220) Result = SUCCESS stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1859 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1859/)
        MAPREDUCE-3909 (Revision 1294219)

        Result = SUCCESS
        stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1859 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1859/ ) MAPREDUCE-3909 (Revision 1294219) Result = SUCCESS stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #588 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/588/)
        MAPREDUCE-3909 (Revision 1294220)

        Result = SUCCESS
        stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #588 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/588/ ) MAPREDUCE-3909 (Revision 1294220) Result = SUCCESS stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
        Steve Loughran made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Target Version/s 0.23.2, 0.24.0 [ 12319851, 12317654 ] 0.24.0, 0.23.2 [ 12317654, 12319851 ]
        Fix Version/s 0.24.0 [ 12317654 ]
        Fix Version/s 0.23.3 [ 12320060 ]
        Resolution Fixed [ 1 ]
        Hide
        Sharad Agarwal added a comment -

        +1

        Show
        Sharad Agarwal added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12515933/MAPREDUCE-3909.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1924//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1924//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515933/MAPREDUCE-3909.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1924//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1924//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12515928/MAPREDUCE-3909.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1923//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1923//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515928/MAPREDUCE-3909.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1923//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1923//console This message is automatically generated.
        Steve Loughran made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Target Version/s 0.24.0, 0.23.2 [ 12317654, 12319851 ]
        Hide
        Steve Loughran added a comment -

        this is only javadocs, no tests or code changes apart from removing a trailing ; on the state enum (the IDE was complaining)

        Show
        Steve Loughran added a comment - this is only javadocs, no tests or code changes apart from removing a trailing ; on the state enum (the IDE was complaining)
        Steve Loughran made changes -
        Attachment MAPREDUCE-3909.patch [ 12515933 ]
        Hide
        Steve Loughran added a comment -

        javadocs for Service, ServiceStateChangeListener, and AbstractService

        Show
        Steve Loughran added a comment - javadocs for Service, ServiceStateChangeListener, and AbstractService
        Steve Loughran made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Steve Loughran made changes -
        Summary javadoc the ServiceStateChangeListener callback javadoc the Service interfaces
        Description The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.

        Document it for others
        The {{Service}} interface doesn't describe what it does.

        The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.

        Document for others
        Steve Loughran made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Steve Loughran made changes -
        Field Original Value New Value
        Attachment MAPREDUCE-3909.patch [ 12515928 ]
        Steve Loughran created issue -

          People

          • Assignee:
            Steve Loughran
            Reporter:
            Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.25h
              0.25h
              Remaining:
              Remaining Estimate - 0.25h
              0.25h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development