Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.23.1
    • Fix Version/s: 0.23.2
    • Component/s: mrv2
    • Labels:
      None

      Description

      If jobhistory/job.* is filtered to bypass acl, resulting page will always show Null user. This differs from 0.20 where filtering on this page, bypasses security to allow all access to the page. essentially passes a null user to AppController where an exception is thrown. If a null user is detected, we should acl checking is disabled on this page.

      1. MAPREDUCE-3878.patch
        1 kB
        Jonathan Eagles

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #206 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/206/)
        merge -r 1292830:1292831 from trunk to branch-0.23. FIXES: MAPREDUCE-3878 (Revision 1292834)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292834
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #206 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/206/ ) merge -r 1292830:1292831 from trunk to branch-0.23. FIXES: MAPREDUCE-3878 (Revision 1292834) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292834 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1000 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1000/)
        MAPREDUCE-3878. Null user on filtered jobhistory job page (Jonathon Eagles via tgraves) (Revision 1292831)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292831
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1000 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1000/ ) MAPREDUCE-3878 . Null user on filtered jobhistory job page (Jonathon Eagles via tgraves) (Revision 1292831) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292831 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #178 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/178/)
        merge -r 1292830:1292831 from trunk to branch-0.23. FIXES: MAPREDUCE-3878 (Revision 1292834)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292834
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #178 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/178/ ) merge -r 1292830:1292831 from trunk to branch-0.23. FIXES: MAPREDUCE-3878 (Revision 1292834) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292834 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #965 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/965/)
        MAPREDUCE-3878. Null user on filtered jobhistory job page (Jonathon Eagles via tgraves) (Revision 1292831)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292831
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #965 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/965/ ) MAPREDUCE-3878 . Null user on filtered jobhistory job page (Jonathon Eagles via tgraves) (Revision 1292831) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292831 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1778 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1778/)
        MAPREDUCE-3878. Null user on filtered jobhistory job page (Jonathon Eagles via tgraves) (Revision 1292831)

        Result = ABORTED
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292831
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1778 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1778/ ) MAPREDUCE-3878 . Null user on filtered jobhistory job page (Jonathon Eagles via tgraves) (Revision 1292831) Result = ABORTED tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292831 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #588 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/588/)
        merge -r 1292830:1292831 from trunk to branch-0.23. FIXES: MAPREDUCE-3878 (Revision 1292834)

        Result = ABORTED
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292834
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #588 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/588/ ) merge -r 1292830:1292831 from trunk to branch-0.23. FIXES: MAPREDUCE-3878 (Revision 1292834) Result = ABORTED tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292834 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #573 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/573/)
        merge -r 1292830:1292831 from trunk to branch-0.23. FIXES: MAPREDUCE-3878 (Revision 1292834)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292834
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #573 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/573/ ) merge -r 1292830:1292831 from trunk to branch-0.23. FIXES: MAPREDUCE-3878 (Revision 1292834) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292834 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1767 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1767/)
        MAPREDUCE-3878. Null user on filtered jobhistory job page (Jonathon Eagles via tgraves) (Revision 1292831)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292831
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1767 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1767/ ) MAPREDUCE-3878 . Null user on filtered jobhistory job page (Jonathon Eagles via tgraves) (Revision 1292831) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292831 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #586 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/586/)
        merge -r 1292830:1292831 from trunk to branch-0.23. FIXES: MAPREDUCE-3878 (Revision 1292834)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292834
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #586 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/586/ ) merge -r 1292830:1292831 from trunk to branch-0.23. FIXES: MAPREDUCE-3878 (Revision 1292834) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292834 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1841 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1841/)
        MAPREDUCE-3878. Null user on filtered jobhistory job page (Jonathon Eagles via tgraves) (Revision 1292831)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292831
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1841 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1841/ ) MAPREDUCE-3878 . Null user on filtered jobhistory job page (Jonathon Eagles via tgraves) (Revision 1292831) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292831 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
        Hide
        Thomas Graves added a comment -

        I committed this to trunk and branch-0.23. Thanks Jon!

        Show
        Thomas Graves added a comment - I committed this to trunk and branch-0.23. Thanks Jon!
        Hide
        Thomas Graves added a comment -

        +1 looks good. Thanks Jon.

        Show
        Thomas Graves added a comment - +1 looks good. Thanks Jon.
        Hide
        Jonathan Eagles added a comment -

        Manual test performed on patch.

        Setup
        Job in history server with owner and user1 only view access.

        Test 1
        Filter provides owner user on /jobhistory/job/*
        Verified Page is correctly displayed

        Test 2
        Filter provides user1 user on /jobhistory/job/*
        Verified Page is correctly displayed

        Test 3
        Filter provides user2 user on /jobhistory/job/*
        Verified Page displays access denied

        Test 4
        Filter provides null user on /jobhistory/job/*
        Verified Page is correctly displayed

        Show
        Jonathan Eagles added a comment - Manual test performed on patch. Setup Job in history server with owner and user1 only view access. Test 1 Filter provides owner user on /jobhistory/job/* Verified Page is correctly displayed Test 2 Filter provides user1 user on /jobhistory/job/* Verified Page is correctly displayed Test 3 Filter provides user2 user on /jobhistory/job/* Verified Page displays access denied Test 4 Filter provides null user on /jobhistory/job/* Verified Page is correctly displayed
        Hide
        Jonathan Eagles added a comment -

        Canceling to add unit tests and/or post manual testing.

        Show
        Jonathan Eagles added a comment - Canceling to add unit tests and/or post manual testing.
        Hide
        Jonathan Eagles added a comment -

        Implementation from AMWebServices.

        Show
        Jonathan Eagles added a comment - Implementation from AMWebServices.
        Hide
        Jonathan Eagles added a comment -

        Implementation from AMWebServices.

        Show
        Jonathan Eagles added a comment - Implementation from AMWebServices.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12515041/MAPREDUCE-3878.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1890//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1890//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515041/MAPREDUCE-3878.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1890//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1890//console This message is automatically generated.

          People

          • Assignee:
            Jonathan Eagles
            Reporter:
            Jonathan Eagles
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development