Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Ports FieldSelectionMapReduce to the new Map/Reduce API
    1. patch-373-1.txt
      39 kB
      Amareshwari Sriramadasu
    2. patch-373.txt
      36 kB
      Amareshwari Sriramadasu

      Activity

      Hide
      Amareshwari Sriramadasu added a comment -

      The failures are not related to the patch. They were due to MAPREDUCE-699

      Show
      Amareshwari Sriramadasu added a comment - The failures are not related to the patch. They were due to MAPREDUCE-699
      Hide
      gary murry added a comment -

      What about the failed contrib tests?

      Show
      gary murry added a comment - What about the failed contrib tests?
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk #33 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/33/)
      . Change org.apache.hadoop.mapred.lib.FieldSelectionMapReduce to use new mapreduce API. Contributed by Amareshwari Sriramadasu.

      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #33 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/33/ ) . Change org.apache.hadoop.mapred.lib.FieldSelectionMapReduce to use new mapreduce API. Contributed by Amareshwari Sriramadasu.
      Hide
      Sharad Agarwal added a comment -

      I just committed this. Thanks Amareshwari!

      Show
      Sharad Agarwal added a comment - I just committed this. Thanks Amareshwari!
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12414320/patch-373-1.txt
      against trunk revision 797362.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 9 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed core unit tests.

      -1 contrib tests. The patch failed contrib unit tests.

      Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/418/testReport/
      Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/418/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/418/artifact/trunk/build/test/checkstyle-errors.html
      Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/418/console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12414320/patch-373-1.txt against trunk revision 797362. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/418/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/418/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/418/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/418/console This message is automatically generated.
      Hide
      Amareshwari Sriramadasu added a comment -

      test-patch resurlt:

           [exec]
           [exec] +1 overall.
           [exec]
           [exec]     +1 @author.  The patch does not contain any @author tags.
           [exec]
           [exec]     +1 tests included.  The patch appears to include 9 new or modified tests.
           [exec]
           [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
           [exec]
           [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
           [exec]
           [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
           [exec]
           [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
           [exec]
           [exec]
      

      Both TestFieldSelection and TestMRFieldSelection passed on my machine.

      Show
      Amareshwari Sriramadasu added a comment - test-patch resurlt: [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 9 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] Both TestFieldSelection and TestMRFieldSelection passed on my machine.
      Hide
      Amareshwari Sriramadasu added a comment -

      Patch with comments incorporated. I left FieldSelectionHelper as public class, since it is used in old api class.

      Show
      Amareshwari Sriramadasu added a comment - Patch with comments incorporated. I left FieldSelectionHelper as public class, since it is used in old api class.
      Hide
      Sharad Agarwal added a comment -

      Since all FieldSelection* classes are related, I think we can keep them all in a single package something like org.apache.hadoop.mapreduce.lib.fieldsel. This will also avoid making FieldSelectionHelper class as public.
      Also lot of code is duplicate in the old API testcase and new API one. We should share the code between these. "mapred" tests can depend on "mapreduce" test.

      Show
      Sharad Agarwal added a comment - Since all FieldSelection* classes are related, I think we can keep them all in a single package something like org.apache.hadoop.mapreduce.lib.fieldsel. This will also avoid making FieldSelectionHelper class as public. Also lot of code is duplicate in the old API testcase and new API one. We should share the code between these. "mapred" tests can depend on "mapreduce" test.
      Hide
      Amareshwari Sriramadasu added a comment -

      Patch deprecates org.apache.hadoop.mapred.lib.FieldSelectionMapReduce. Adds org.apache.hadoop.mapreduce.lib.map.FieldSelectionMapper, org.apache.hadoop.mapreduce.lib.reduce.FieldSelectionReducer and org.apache.hadoop.mapreduce.lib.FieldSelectionHelper.

      Show
      Amareshwari Sriramadasu added a comment - Patch deprecates org.apache.hadoop.mapred.lib.FieldSelectionMapReduce. Adds org.apache.hadoop.mapreduce.lib.map.FieldSelectionMapper, org.apache.hadoop.mapreduce.lib.reduce.FieldSelectionReducer and org.apache.hadoop.mapreduce.lib.FieldSelectionHelper.

        People

        • Assignee:
          Amareshwari Sriramadasu
          Reporter:
          Amareshwari Sriramadasu
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development