Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3624

bin/yarn script adds jdk tools.jar to the classpath.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.1
    • Component/s: mrv2
    • Labels:
      None

      Description

      Thanks to Roman for pointing it out. Looks like we have the following lines in bin/yarn:

      CLASSPATH=${CLASSPATH}:$JAVA_HOME/lib/tools.jar
      

      We dont really have a dependency on the tools jar. We should remove this.

      1. MAPREDUCE-3624.patch
        0.5 kB
        Mahadev konar

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #951 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/951/)
        MAPREDUCE-3624. Remove unnecessary dependency on JDK's tools.jar. Contributed by Mahadev Konar.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228354
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #951 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/951/ ) MAPREDUCE-3624 . Remove unnecessary dependency on JDK's tools.jar. Contributed by Mahadev Konar. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228354 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #153 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/153/)
        Merge -c 1228354 from trunk to branch-0.23 to fix MAPREDUCE-3624. Remove unnecessary dependency on JDK's tools.jar.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228355
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #153 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/153/ ) Merge -c 1228354 from trunk to branch-0.23 to fix MAPREDUCE-3624 . Remove unnecessary dependency on JDK's tools.jar. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228355 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #918 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/918/)
        MAPREDUCE-3624. Remove unnecessary dependency on JDK's tools.jar. Contributed by Mahadev Konar.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228354
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #918 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/918/ ) MAPREDUCE-3624 . Remove unnecessary dependency on JDK's tools.jar. Contributed by Mahadev Konar. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228354 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #131 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/131/)
        Merge -c 1228354 from trunk to branch-0.23 to fix MAPREDUCE-3624. Remove unnecessary dependency on JDK's tools.jar.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228355
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #131 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/131/ ) Merge -c 1228354 from trunk to branch-0.23 to fix MAPREDUCE-3624 . Remove unnecessary dependency on JDK's tools.jar. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228355 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1530 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1530/)
        MAPREDUCE-3624. Remove unnecessary dependency on JDK's tools.jar. Contributed by Mahadev Konar.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228354
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1530 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1530/ ) MAPREDUCE-3624 . Remove unnecessary dependency on JDK's tools.jar. Contributed by Mahadev Konar. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228354 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #362 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/362/)
        Merge -c 1228354 from trunk to branch-0.23 to fix MAPREDUCE-3624. Remove unnecessary dependency on JDK's tools.jar.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228355
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #362 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/362/ ) Merge -c 1228354 from trunk to branch-0.23 to fix MAPREDUCE-3624 . Remove unnecessary dependency on JDK's tools.jar. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228355 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #341 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/341/)
        Merge -c 1228354 from trunk to branch-0.23 to fix MAPREDUCE-3624. Remove unnecessary dependency on JDK's tools.jar.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228355
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #341 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/341/ ) Merge -c 1228354 from trunk to branch-0.23 to fix MAPREDUCE-3624 . Remove unnecessary dependency on JDK's tools.jar. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228355 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1510 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1510/)
        MAPREDUCE-3624. Remove unnecessary dependency on JDK's tools.jar. Contributed by Mahadev Konar.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228354
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1510 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1510/ ) MAPREDUCE-3624 . Remove unnecessary dependency on JDK's tools.jar. Contributed by Mahadev Konar. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228354 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1583 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1583/)
        MAPREDUCE-3624. Remove unnecessary dependency on JDK's tools.jar. Contributed by Mahadev Konar.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228354
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1583 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1583/ ) MAPREDUCE-3624 . Remove unnecessary dependency on JDK's tools.jar. Contributed by Mahadev Konar. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228354 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #351 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/351/)
        Merge -c 1228354 from trunk to branch-0.23 to fix MAPREDUCE-3624. Remove unnecessary dependency on JDK's tools.jar.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228355
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #351 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/351/ ) Merge -c 1228354 from trunk to branch-0.23 to fix MAPREDUCE-3624 . Remove unnecessary dependency on JDK's tools.jar. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228355 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/bin/yarn
        Hide
        Arun C Murthy added a comment -

        I just committed this. Thanks Mahadev!

        Show
        Arun C Murthy added a comment - I just committed this. Thanks Mahadev!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12509578/MAPREDUCE-3624.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1546//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1546//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1546//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12509578/MAPREDUCE-3624.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1546//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1546//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1546//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        +1

        Btw, I made the same change to hadoop a while back (HADOOP-7374), same rationale applies here.

        Show
        Eli Collins added a comment - +1 Btw, I made the same change to hadoop a while back ( HADOOP-7374 ), same rationale applies here.
        Hide
        Mahadev konar added a comment -

        trivial patch for removing dependency in jdk tools.jar.

        Show
        Mahadev konar added a comment - trivial patch for removing dependency in jdk tools.jar.

          People

          • Assignee:
            Mahadev konar
            Reporter:
            Mahadev konar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development