Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.1
    • Component/s: mrv2
    • Labels:
      None

      Description

      The hadoop streaming command will ignore any command line arguments to it.

      hadoop jar streaming.jar -input input -output output -mapper cat -reducer cat ThisIsABadArgument
      

      Works just fine. This can mask issues where quotes were mistakenly missed like

      hadoop jar streaming.jar -input input -output output -mapper xargs cat -reducer cat -archive someArchive.tgz
      

      Streaming should fail if it encounters an unexpected command line parameter

      1. MR-3521.txt
        2 kB
        Robert Joseph Evans

        Activity

        Hide
        Robert Joseph Evans added a comment -

        Simply adds in the check, and fails if it finds too many arguments.

        Show
        Robert Joseph Evans added a comment - Simply adds in the check, and fails if it finds too many arguments.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12507247/MR-3521.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1435//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12507247/MR-3521.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1435//console This message is automatically generated.
        Hide
        Robert Joseph Evans added a comment -

        The failures are expected because I changed tools, which test-patch is not set up to deal with yet HADOOP-7725.

        I ran the streaming tests manually and they all pass.

        main:
        [INFO] Executed tasks
        [INFO] ------------------------------------------------------------------------
        [INFO] Reactor Summary:
        [INFO] 
        [INFO] Apache Hadoop MapReduce Streaming ................. SUCCESS [4:12.117s]
        [INFO] Apache Hadoop Archives ............................ SUCCESS [35.337s]
        [INFO] Apache Hadoop Tools ............................... SUCCESS [0.072s]
        [INFO] ------------------------------------------------------------------------
        [INFO] BUILD SUCCESS
        [INFO] ------------------------------------------------------------------------
        [INFO] Total time: 4:47.842s
        [INFO] Finished at: Wed Dec 14 10:17:23 CST 2011
        [INFO] Final Memory: 10M/159M
        [INFO] ------------------------------------------------------------------------
        
        Show
        Robert Joseph Evans added a comment - The failures are expected because I changed tools, which test-patch is not set up to deal with yet HADOOP-7725 . I ran the streaming tests manually and they all pass. main: [INFO] Executed tasks [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Apache Hadoop MapReduce Streaming ................. SUCCESS [4:12.117s] [INFO] Apache Hadoop Archives ............................ SUCCESS [35.337s] [INFO] Apache Hadoop Tools ............................... SUCCESS [0.072s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 4:47.842s [INFO] Finished at: Wed Dec 14 10:17:23 CST 2011 [INFO] Final Memory: 10M/159M [INFO] ------------------------------------------------------------------------
        Hide
        Arun C Murthy added a comment -

        I just committed this. Thanks Bobby!

        Show
        Arun C Murthy added a comment - I just committed this. Thanks Bobby!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1550 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1550/)
        MAPREDUCE-3521. Fixed streaming to ensure it doesn't silently ignore unknown arguments. Contributed by Robert Evans.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225471
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1550 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1550/ ) MAPREDUCE-3521 . Fixed streaming to ensure it doesn't silently ignore unknown arguments. Contributed by Robert Evans. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225471 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1478 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1478/)
        MAPREDUCE-3521. Fixed streaming to ensure it doesn't silently ignore unknown arguments. Contributed by Robert Evans.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225471
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1478 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1478/ ) MAPREDUCE-3521 . Fixed streaming to ensure it doesn't silently ignore unknown arguments. Contributed by Robert Evans. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225471 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #315 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/315/)
        Merge -c 1225471 from trunk to branch-0.23 to fix MAPREDUCE-3521.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225472
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java
        • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #315 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/315/ ) Merge -c 1225471 from trunk to branch-0.23 to fix MAPREDUCE-3521 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225472 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #326 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/326/)
        Merge -c 1225471 from trunk to branch-0.23 to fix MAPREDUCE-3521.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225472
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java
        • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #326 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/326/ ) Merge -c 1225471 from trunk to branch-0.23 to fix MAPREDUCE-3521 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225472 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #337 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/337/)
        Merge -c 1225471 from trunk to branch-0.23 to fix MAPREDUCE-3521.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225472
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java
        • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #337 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/337/ ) Merge -c 1225471 from trunk to branch-0.23 to fix MAPREDUCE-3521 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225472 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1499 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1499/)
        MAPREDUCE-3521. Fixed streaming to ensure it doesn't silently ignore unknown arguments. Contributed by Robert Evans.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225471
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1499 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1499/ ) MAPREDUCE-3521 . Fixed streaming to ensure it doesn't silently ignore unknown arguments. Contributed by Robert Evans. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225471 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #909 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/909/)
        MAPREDUCE-3521. Fixed streaming to ensure it doesn't silently ignore unknown arguments. Contributed by Robert Evans.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225471
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #909 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/909/ ) MAPREDUCE-3521 . Fixed streaming to ensure it doesn't silently ignore unknown arguments. Contributed by Robert Evans. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225471 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #122 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/122/)
        Merge -c 1225471 from trunk to branch-0.23 to fix MAPREDUCE-3521.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225472
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java
        • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #122 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/122/ ) Merge -c 1225471 from trunk to branch-0.23 to fix MAPREDUCE-3521 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225472 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #143 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/143/)
        Merge -c 1225471 from trunk to branch-0.23 to fix MAPREDUCE-3521.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225472
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java
        • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #143 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/143/ ) Merge -c 1225471 from trunk to branch-0.23 to fix MAPREDUCE-3521 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225472 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #942 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/942/)
        MAPREDUCE-3521. Fixed streaming to ensure it doesn't silently ignore unknown arguments. Contributed by Robert Evans.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225471
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #942 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/942/ ) MAPREDUCE-3521 . Fixed streaming to ensure it doesn't silently ignore unknown arguments. Contributed by Robert Evans. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225471 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestStreamJob.java

          People

          • Assignee:
            Robert Joseph Evans
            Reporter:
            Robert Joseph Evans
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development