Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Modified Gridmix STRESS mode locking structure. The submitted thread and the polling thread now run simultaneously without blocking each other.
    • Tags:
      gridmix3 stress

      Description

      Gridmix STREES mode code doesnt sufficiently load the cluster due to improper locking.

      1. MAPREDUCE-3481-v1.7.patch
        19 kB
        Amar Kamat
      2. MAPREDUCE-3481-v1.6.patch
        18 kB
        Amar Kamat

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          61d 21h 28m 1 Amar Kamat 30/Jan/12 06:27
          Resolved Resolved Closed Closed
          34d 20h 21m 1 Arun C Murthy 05/Mar/12 02:49
          Allen Wittenauer made changes -
          Affects Version/s 2.0.0-alpha [ 12320354 ]
          Affects Version/s 0.24.0 [ 12317654 ]
          Amar Kamat made changes -
          Link This issue relates to MAPREDUCE-3769 [ MAPREDUCE-3769 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Vinod Kumar Vavilapalli made changes -
          Fix Version/s 0.24.0 [ 12317654 ]
          Vinod Kumar Vavilapalli made changes -
          Fix Version/s 0.23.1 [ 12318883 ]
          Affects Version/s 0.23.0 [ 12315570 ]
          Target Version/s 0.24.0, 0.23.1 [ 12317654, 12318883 ] 0.23.1, 0.24.0 [ 12318883, 12317654 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #974 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/974/)
          MAPREDUCE-3481. [Gridmix] Improve Gridmix STRESS mode. (amarrk)

          amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237543
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #974 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/974/ ) MAPREDUCE-3481 . [Gridmix] Improve Gridmix STRESS mode. (amarrk) amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237543 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Build #176 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/176/)
          MAPREDUCE-3481. [Gridmix] Improve Gridmix STRESS mode. (amarrk)

          amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237578
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #176 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/176/ ) MAPREDUCE-3481 . [Gridmix] Improve Gridmix STRESS mode. (amarrk) amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237578 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #154 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/154/)
          MAPREDUCE-3481. [Gridmix] Improve Gridmix STRESS mode. (amarrk)

          amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237578
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #154 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/154/ ) MAPREDUCE-3481 . [Gridmix] Improve Gridmix STRESS mode. (amarrk) amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237578 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #941 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/941/)
          MAPREDUCE-3481. [Gridmix] Improve Gridmix STRESS mode. (amarrk)

          amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237543
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #941 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/941/ ) MAPREDUCE-3481 . [Gridmix] Improve Gridmix STRESS mode. (amarrk) amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237543 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #459 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/459/)
          MAPREDUCE-3481. [Gridmix] Improve Gridmix STRESS mode. (amarrk)

          amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237578
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #459 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/459/ ) MAPREDUCE-3481 . [Gridmix] Improve Gridmix STRESS mode. (amarrk) amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237578 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #444 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/444/)
          MAPREDUCE-3481. [Gridmix] Improve Gridmix STRESS mode. (amarrk)

          amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237578
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #444 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/444/ ) MAPREDUCE-3481 . [Gridmix] Improve Gridmix STRESS mode. (amarrk) amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237578 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #435 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/435/)
          MAPREDUCE-3481. [Gridmix] Improve Gridmix STRESS mode. (amarrk)

          amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237578
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #435 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/435/ ) MAPREDUCE-3481 . [Gridmix] Improve Gridmix STRESS mode. (amarrk) amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237578 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Hide
          Amar Kamat added a comment -

          Committed this to branch-0.23 too.

          Show
          Amar Kamat added a comment - Committed this to branch-0.23 too.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1687 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1687/)
          MAPREDUCE-3481. [Gridmix] Improve Gridmix STRESS mode. (amarrk)

          amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237543
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1687 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1687/ ) MAPREDUCE-3481 . [Gridmix] Improve Gridmix STRESS mode. (amarrk) amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237543 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Amar Kamat made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Release Note Modified Gridmix STRESS mode locking structure. The submitted thread and the polling thread now run simultaneously without blocking each other.
          Target Version/s 0.24.0, 0.23.1 [ 12317654, 12318883 ] 0.23.1, 0.24.0 [ 12318883, 12317654 ]
          Resolution Fixed [ 1 ]
          Hide
          Amar Kamat added a comment -

          I just committed the v1.7 patch to trunk. Thanks Ravi for the review.

          Show
          Amar Kamat added a comment - I just committed the v1.7 patch to trunk. Thanks Ravi for the review.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1615 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1615/)
          MAPREDUCE-3481. [Gridmix] Improve Gridmix STRESS mode. (amarrk)

          amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237543
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1615 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1615/ ) MAPREDUCE-3481 . [Gridmix] Improve Gridmix STRESS mode. (amarrk) amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237543 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/Statistics.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/java/org/apache/hadoop/mapred/gridmix/StressJobFactory.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Hide
          Ravi Gummadi added a comment -

          Latest patch looks good to me.
          +1

          Show
          Ravi Gummadi added a comment - Latest patch looks good to me. +1
          Amar Kamat made changes -
          Attachment MAPREDUCE-3481-v1.7.patch [ 12512384 ]
          Hide
          Amar Kamat added a comment -

          Attaching a patch incorporating Ravi's review comments. test-patch and ant-test passed.

          Show
          Amar Kamat added a comment - Attaching a patch incorporating Ravi's review comments. test-patch and ant-test passed.
          Vinod Kumar Vavilapalli made changes -
          Link This issue blocks MAPREDUCE-3719 [ MAPREDUCE-3719 ]
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Amar/Ravi, can you please coordinate to finish this? This will help us with running gridmix with YARN+MR. Thanks!

          Show
          Vinod Kumar Vavilapalli added a comment - Amar/Ravi, can you please coordinate to finish this? This will help us with running gridmix with YARN+MR. Thanks!
          Hide
          Ravi Gummadi added a comment -

          Patch looks good overall.

          Some minor comments:
          (1) You changed "return" to "break" in the while loop in StressReaderThread.run() when an InterruptedException is seen. "return" seems to be better.
          (2) The return value from calcEffectiveIncompleteMapTasks() is taken in to a variable called "mapSlotsBackFill", which is misleading. Please change it to mapLoad or similar name.

          Show
          Ravi Gummadi added a comment - Patch looks good overall. Some minor comments: (1) You changed "return" to "break" in the while loop in StressReaderThread.run() when an InterruptedException is seen. "return" seems to be better. (2) The return value from calcEffectiveIncompleteMapTasks() is taken in to a variable called "mapSlotsBackFill", which is misleading. Please change it to mapLoad or similar name.
          Siddharth Seth made changes -
          Target Version/s 0.24.0 [ 12317654 ] 0.23.1, 0.24.0 [ 12318883, 12317654 ]
          Amar Kamat made changes -
          Attachment MAPREDUCE-3481-v1.6.patch [ 12511801 ]
          Hide
          Amar Kamat added a comment -

          Attaching a patch.

          Show
          Amar Kamat added a comment - Attaching a patch.
          Amar Kamat made changes -
          Field Original Value New Value
          Link This issue relates to MAPREDUCE-1687 [ MAPREDUCE-1687 ]
          Amar Kamat created issue -

            People

            • Assignee:
              Amar Kamat
              Reporter:
              Amar Kamat
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development