Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3448

TestCombineOutputCollector javac unchecked warning on mocked generics

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.1, 0.24.0
    • Fix Version/s: 0.23.1
    • Component/s: mrv2
    • Labels:
      None

      Description

      [javac] found : org.apache.hadoop.mapred.IFile.Writer
      [javac] required: org.apache.hadoop.mapred.IFile.Writer<java.lang.String,java.lang.Integer>
      [javac] Writer<String, Integer> mockWriter = mock(Writer.class);
      [javac] ^
      [javac] /home/jeagles/hadoop/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java:125: warning: [unchecked] unchecked conversion
      [javac] found : org.apache.hadoop.mapred.IFile.Writer
      [javac] required: org.apache.hadoop.mapred.IFile.Writer<java.lang.String,java.lang.Integer>
      [javac] Writer<String, Integer> mockWriter = mock(Writer.class);
      [javac] ^
      [javac] Note: Some input files use or override a deprecated API.
      [javac] Note: Recompile with -Xlint:deprecation for details.
      [javac] 2 warnings

      1. MAPREDUCE-3448.patch
        1 kB
        Jonathan Eagles

        Activity

        Hide
        Hitesh Shah added a comment -

        +1. Looks good.

        Show
        Hitesh Shah added a comment - +1. Looks good.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12504555/MAPREDUCE-3448.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 12 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1334//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1334//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-examples.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1334//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12504555/MAPREDUCE-3448.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 12 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1334//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1334//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-examples.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1334//console This message is automatically generated.
        Hide
        Jonathan Eagles added a comment -

        Findbugs unrelated to the patch

        Show
        Jonathan Eagles added a comment - Findbugs unrelated to the patch
        Hide
        Mahadev konar added a comment -

        Just committed this. Thanks Jonathan!

        Show
        Mahadev konar added a comment - Just committed this. Thanks Jonathan!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #226 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/226/)
        MAPREDUCE-3448. TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) - Merging r1208136 from trunk.

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208137
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #226 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/226/ ) MAPREDUCE-3448 . TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) - Merging r1208136 from trunk. mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208137 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1340 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1340/)
        MAPREDUCE-3448. TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208136
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1340 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1340/ ) MAPREDUCE-3448 . TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208136 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #229 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/229/)
        MAPREDUCE-3448. TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) - Merging r1208136 from trunk.

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208137
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #229 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/229/ ) MAPREDUCE-3448 . TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) - Merging r1208136 from trunk. mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208137 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1414 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1414/)
        MAPREDUCE-3448. TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208136
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1414 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1414/ ) MAPREDUCE-3448 . TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208136 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1364 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1364/)
        MAPREDUCE-3448. TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208136
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1364 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1364/ ) MAPREDUCE-3448 . TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208136 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #240 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/240/)
        MAPREDUCE-3448. TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) - Merging r1208136 from trunk.

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208137
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #240 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/240/ ) MAPREDUCE-3448 . TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) - Merging r1208136 from trunk. mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208137 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #93 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/93/)
        MAPREDUCE-3448. TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) - Merging r1208136 from trunk.

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208137
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #93 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/93/ ) MAPREDUCE-3448 . TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) - Merging r1208136 from trunk. mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208137 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #880 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/880/)
        MAPREDUCE-3448. TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208136
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #880 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/880/ ) MAPREDUCE-3448 . TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208136 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #109 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/109/)
        MAPREDUCE-3448. TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) - Merging r1208136 from trunk.

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208137
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #109 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/109/ ) MAPREDUCE-3448 . TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) - Merging r1208136 from trunk. mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208137 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #913 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/913/)
        MAPREDUCE-3448. TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208136
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #913 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/913/ ) MAPREDUCE-3448 . TestCombineOutputCollector javac unchecked warning on mocked generics (Jonathan Eagles via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208136 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestCombineOutputCollector.java

          People

          • Assignee:
            Jonathan Eagles
            Reporter:
            Jonathan Eagles
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development