Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3374

src/c++/task-controller/configure is not set executable in the tarball and that prevents task-controller from rebuilding

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.205.0
    • Fix Version/s: 1.0.0
    • Component/s: task-controller
    • Labels:
    • Hadoop Flags:
      Reviewed
    • Target Version/s:

      Description

      ant task-controller fails because src/c++/task-controller/configure is not set executable

      1. MAPREDUCE-3374.patch.txt
        0.5 kB
        Roman Shaposhnik
      2. log.gz
        26 kB
        Roman Shaposhnik

        Activity

        Roman Shaposhnik created issue -
        Roman Shaposhnik made changes -
        Field Original Value New Value
        Attachment MAPREDUCE-3374.patch.txt [ 12502860 ]
        Roman Shaposhnik made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12502860/MAPREDUCE-3374.patch.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1267//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12502860/MAPREDUCE-3374.patch.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1267//console This message is automatically generated.
        Hide
        Matt Foley added a comment -

        Hi Roman, thanks for contributing this patch. Please run test-patch manually against branch-0.20-security-205, and paste in the result evaluation as a comment in this Jira. Thanks.

        Show
        Matt Foley added a comment - Hi Roman, thanks for contributing this patch. Please run test-patch manually against branch-0.20-security-205, and paste in the result evaluation as a comment in this Jira. Thanks.
        Hide
        Roman Shaposhnik added a comment -

        Attaching a log from running test-patch. Please let me know if you want any additional details.

        Show
        Roman Shaposhnik added a comment - Attaching a log from running test-patch. Please let me know if you want any additional details.
        Roman Shaposhnik made changes -
        Attachment log.gz [ 12503108 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12503108/log.gz
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1285//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12503108/log.gz against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1285//console This message is automatically generated.
        Hide
        Matt Foley added a comment -

        Here's the piece we needed:

        -1 overall.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings.

        Since this patch is for build code, agree unit tests are inapplicable. Therefore test-patch passes.
        The unit tests are not run by normal developer invocation of test-patch, but this patch is unlikely to affect the way task-controller runs, so we'll let that pass too.

        The patch makes sense to me.
        +1 for code review. Please commit to branch-0.20-security and branch-0.20-security-205.
        Thanks!

        Show
        Matt Foley added a comment - Here's the piece we needed: -1 overall. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. Since this patch is for build code, agree unit tests are inapplicable. Therefore test-patch passes. The unit tests are not run by normal developer invocation of test-patch, but this patch is unlikely to affect the way task-controller runs, so we'll let that pass too. The patch makes sense to me. +1 for code review. Please commit to branch-0.20-security and branch-0.20-security-205. Thanks!
        Matt Foley made changes -
        Target Version/s 0.20.205.1 [ 12318240 ]
        Hide
        Matt Foley added a comment -

        Committed to branch-0.20-security and branch-0.20-security-205.

        Show
        Matt Foley added a comment - Committed to branch-0.20-security and branch-0.20-security-205.
        Matt Foley made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.20.205.1 [ 12318240 ]
        Resolution Fixed [ 1 ]
        Roman Shaposhnik made changes -
        Labels bigtop
        Hide
        Matt Foley added a comment -

        Closed upon release of version 1.0.0.

        Show
        Matt Foley added a comment - Closed upon release of version 1.0.0.
        Matt Foley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development