Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.1
    • Component/s: mrv2
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      While reading this code, I did a little bit of cleanup:

      • added some javadoc
      • rather than using a Map<Priority, Integer> for keeping counts, switched to Guava's HashMultiset, which makes a simpler API.
      1. mr-3238.txt
        5 kB
        Todd Lipcon

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12500092/mr-3238.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 160 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1096//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1096//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1096//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1096//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1096//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500092/mr-3238.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 160 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1096//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1096//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1096//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1096//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1096//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        +1 lgtm

        Show
        Eli Collins added a comment - +1 lgtm
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1401 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1401/)
        MAPREDUCE-3238. Small cleanup in SchedulerApp. (Todd Lipcon via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206921
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1401 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1401/ ) MAPREDUCE-3238 . Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206921 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1327 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1327/)
        MAPREDUCE-3238. Small cleanup in SchedulerApp. (Todd Lipcon via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206921
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1327 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1327/ ) MAPREDUCE-3238 . Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206921 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Hide
        Mahadev konar added a comment -

        Just committed this. Thanks Todd.

        Show
        Mahadev konar added a comment - Just committed this. Thanks Todd.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #215 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/215/)
        MAPREDUCE-3238. Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) - Merging r1206921 from trunk

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206924
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #215 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/215/ ) MAPREDUCE-3238 . Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) - Merging r1206921 from trunk mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206924 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #218 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/218/)
        MAPREDUCE-3238. Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) - Merging r1206921 from trunk

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206924
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #218 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/218/ ) MAPREDUCE-3238 . Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) - Merging r1206921 from trunk mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206924 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #229 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/229/)
        MAPREDUCE-3238. Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) - Merging r1206921 from trunk

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206924
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #229 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/229/ ) MAPREDUCE-3238 . Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) - Merging r1206921 from trunk mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206924 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1351 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1351/)
        MAPREDUCE-3238. Small cleanup in SchedulerApp. (Todd Lipcon via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206921
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1351 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1351/ ) MAPREDUCE-3238 . Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206921 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #91 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/91/)
        MAPREDUCE-3238. Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) - Merging r1206921 from trunk

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206924
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #91 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/91/ ) MAPREDUCE-3238 . Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) - Merging r1206921 from trunk mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206924 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #878 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/878/)
        MAPREDUCE-3238. Small cleanup in SchedulerApp. (Todd Lipcon via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206921
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #878 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/878/ ) MAPREDUCE-3238 . Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206921 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #107 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/107/)
        MAPREDUCE-3238. Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) - Merging r1206921 from trunk

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206924
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #107 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/107/ ) MAPREDUCE-3238 . Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) - Merging r1206921 from trunk mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206924 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #911 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/911/)
        MAPREDUCE-3238. Small cleanup in SchedulerApp. (Todd Lipcon via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206921
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #911 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/911/ ) MAPREDUCE-3238 . Small cleanup in SchedulerApp. (Todd Lipcon via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206921 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApp.java

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development