Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: mrv2
    • Labels:
      None

      Description

      RM, NM, job history, and application master httpservers are not created with access Control lists. I believe this means that anyone can access any of the standard servlets that check to see if the user has administrator access - like /jmx, /stacks, etc and ops has no way to restrict access to these things.

      1. MAPREDUCE-3175.patch
        18 kB
        Jonathan Eagles
      2. MAPREDUCE-3175.patch
        22 kB
        Jonathan Eagles
      3. MAPREDUCE-3175.patch
        19 kB
        Jonathan Eagles
      4. MAPREDUCE-3175.patch
        8 kB
        Jonathan Eagles
      5. MAPREDUCE-3175.patch
        8 kB
        Jonathan Eagles

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #845 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/845/)
          MAPREDUCE-3175. Add authorization to admin web-pages such as /stacks, /jmx etc. Contributed by Jonathan Eagles.

          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189619
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #845 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/845/ ) MAPREDUCE-3175 . Add authorization to admin web-pages such as /stacks, /jmx etc. Contributed by Jonathan Eagles. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189619 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Build #64 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/64/)
          Merge -c 1189619 from trunk to branch-0.23 to fix MAPREDUCE-3175.

          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189628
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #64 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/64/ ) Merge -c 1189619 from trunk to branch-0.23 to fix MAPREDUCE-3175 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189628 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #873 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/873/)
          MAPREDUCE-3175. Add authorization to admin web-pages such as /stacks, /jmx etc. Contributed by Jonathan Eagles.

          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189619
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #873 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/873/ ) MAPREDUCE-3175 . Add authorization to admin web-pages such as /stacks, /jmx etc. Contributed by Jonathan Eagles. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189619 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #52 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/52/)
          Merge -c 1189619 from trunk to branch-0.23 to fix MAPREDUCE-3175.

          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189628
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #52 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/52/ ) Merge -c 1189619 from trunk to branch-0.23 to fix MAPREDUCE-3175 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189628 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #67 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/67/)
          Merge -c 1189619 from trunk to branch-0.23 to fix MAPREDUCE-3175.

          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189628
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #67 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/67/ ) Merge -c 1189619 from trunk to branch-0.23 to fix MAPREDUCE-3175 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189628 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1180 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1180/)
          MAPREDUCE-3175. Add authorization to admin web-pages such as /stacks, /jmx etc. Contributed by Jonathan Eagles.

          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189619
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1180 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1180/ ) MAPREDUCE-3175 . Add authorization to admin web-pages such as /stacks, /jmx etc. Contributed by Jonathan Eagles. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189619 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #71 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/71/)
          Merge -c 1189619 from trunk to branch-0.23 to fix MAPREDUCE-3175.

          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189628
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #71 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/71/ ) Merge -c 1189619 from trunk to branch-0.23 to fix MAPREDUCE-3175 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189628 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #70 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/70/)
          Merge -c 1189619 from trunk to branch-0.23 to fix MAPREDUCE-3175.

          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189628
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #70 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/70/ ) Merge -c 1189619 from trunk to branch-0.23 to fix MAPREDUCE-3175 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189628 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1241 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1241/)
          MAPREDUCE-3175. Add authorization to admin web-pages such as /stacks, /jmx etc. Contributed by Jonathan Eagles.

          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189619
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1241 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1241/ ) MAPREDUCE-3175 . Add authorization to admin web-pages such as /stacks, /jmx etc. Contributed by Jonathan Eagles. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189619 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Hide
          Jonathan Eagles added a comment -

          Thanks for the review and commit, Arun!

          Show
          Jonathan Eagles added a comment - Thanks for the review and commit, Arun!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1164 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1164/)
          MAPREDUCE-3175. Add authorization to admin web-pages such as /stacks, /jmx etc. Contributed by Jonathan Eagles.

          acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189619
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1164 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1164/ ) MAPREDUCE-3175 . Add authorization to admin web-pages such as /stacks, /jmx etc. Contributed by Jonathan Eagles. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189619 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java
          Hide
          Arun C Murthy added a comment -

          I just committed this. Thanks Jonathan!

          Show
          Arun C Murthy added a comment - I just committed this. Thanks Jonathan!
          Hide
          Jonathan Eagles added a comment -

          mvn test results

          [INFO] Reactor Summary:
          [INFO]
          [INFO] hadoop-yarn-api ................................... SUCCESS [12.548s]
          [INFO] hadoop-yarn-common ................................ SUCCESS [7.853s]
          [INFO] hadoop-yarn-server-common ......................... SUCCESS [8.864s]
          [INFO] hadoop-yarn-server-nodemanager .................... SUCCESS [42.338s]
          [INFO] hadoop-yarn-server-web-proxy ...................... SUCCESS [0.644s]
          [INFO] hadoop-yarn-server-resourcemanager ................ SUCCESS [1:01.114s]
          [INFO] hadoop-yarn-server-tests .......................... SUCCESS [6.909s]
          [INFO] hadoop-yarn-server ................................ SUCCESS [0.002s]
          [INFO] hadoop-yarn-applications-distributedshell ......... SUCCESS [14.614s]
          [INFO] hadoop-yarn-applications .......................... SUCCESS [0.002s]
          [INFO] hadoop-yarn-site .................................. SUCCESS [0.340s]
          [INFO] hadoop-yarn ....................................... SUCCESS [0.001s]
          [INFO] hadoop-mapreduce-client-core ...................... SUCCESS [3.118s]
          [INFO] hadoop-mapreduce-client-common .................... SUCCESS [8.019s]
          [INFO] hadoop-mapreduce-client-shuffle ................... SUCCESS [1.422s]
          [INFO] hadoop-mapreduce-client-app ....................... SUCCESS [1:06.022s]
          [INFO] hadoop-mapreduce-client-hs ........................ SUCCESS [9.579s]
          [INFO] hadoop-mapreduce-client-jobclient ................. SUCCESS [35.721s]
          [INFO] hadoop-mapreduce-client ........................... SUCCESS [0.001s]
          [INFO] hadoop-mapreduce .................................. SUCCESS [0.001s]
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD SUCCESS
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 4:39.762s
          [INFO] Finished at: Thu Oct 27 00:13:29 CDT 2011
          [INFO] Final Memory: 56M/238M
          [INFO] ------------------------------------------------------------------------

          Show
          Jonathan Eagles added a comment - mvn test results [INFO] Reactor Summary: [INFO] [INFO] hadoop-yarn-api ................................... SUCCESS [12.548s] [INFO] hadoop-yarn-common ................................ SUCCESS [7.853s] [INFO] hadoop-yarn-server-common ......................... SUCCESS [8.864s] [INFO] hadoop-yarn-server-nodemanager .................... SUCCESS [42.338s] [INFO] hadoop-yarn-server-web-proxy ...................... SUCCESS [0.644s] [INFO] hadoop-yarn-server-resourcemanager ................ SUCCESS [1:01.114s] [INFO] hadoop-yarn-server-tests .......................... SUCCESS [6.909s] [INFO] hadoop-yarn-server ................................ SUCCESS [0.002s] [INFO] hadoop-yarn-applications-distributedshell ......... SUCCESS [14.614s] [INFO] hadoop-yarn-applications .......................... SUCCESS [0.002s] [INFO] hadoop-yarn-site .................................. SUCCESS [0.340s] [INFO] hadoop-yarn ....................................... SUCCESS [0.001s] [INFO] hadoop-mapreduce-client-core ...................... SUCCESS [3.118s] [INFO] hadoop-mapreduce-client-common .................... SUCCESS [8.019s] [INFO] hadoop-mapreduce-client-shuffle ................... SUCCESS [1.422s] [INFO] hadoop-mapreduce-client-app ....................... SUCCESS [1:06.022s] [INFO] hadoop-mapreduce-client-hs ........................ SUCCESS [9.579s] [INFO] hadoop-mapreduce-client-jobclient ................. SUCCESS [35.721s] [INFO] hadoop-mapreduce-client ........................... SUCCESS [0.001s] [INFO] hadoop-mapreduce .................................. SUCCESS [0.001s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 4:39.762s [INFO] Finished at: Thu Oct 27 00:13:29 CDT 2011 [INFO] Final Memory: 56M/238M [INFO] ------------------------------------------------------------------------
          Hide
          Jonathan Eagles added a comment -

          170 findbugs warnings seems to be normal right now

          Show
          Jonathan Eagles added a comment - 170 findbugs warnings seems to be normal right now
          Hide
          Jonathan Eagles added a comment -

          Here are the results of test-patch from my box.

          -1 overall.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 170 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Show
          Jonathan Eagles added a comment - Here are the results of test-patch from my box. -1 overall. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 170 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12501025/MAPREDUCE-3175.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 170 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed the unit tests build

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-web-proxy.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501025/MAPREDUCE-3175.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 170 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed the unit tests build +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-web-proxy.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1163//console This message is automatically generated.
          Hide
          Jonathan Eagles added a comment -

          Updating patch for javadoc warnings

          Show
          Jonathan Eagles added a comment - Updating patch for javadoc warnings
          Hide
          Jonathan Eagles added a comment -

          2 warnings
          [WARNING] Javadoc Warnings
          [WARNING] /home/jeagles/hadoop/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java:95: warning - @See is an unknown tag – same as a known tag except for case.
          [WARNING] /home/jeagles/hadoop/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java:95: warning - @See is an unknown tag – same as a known tag except for case.

          Show
          Jonathan Eagles added a comment - 2 warnings [WARNING] Javadoc Warnings [WARNING] /home/jeagles/hadoop/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java:95: warning - @See is an unknown tag – same as a known tag except for case. [WARNING] /home/jeagles/hadoop/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java:95: warning - @See is an unknown tag – same as a known tag except for case.
          Hide
          Jonathan Eagles added a comment -

          Will do

          Show
          Jonathan Eagles added a comment - Will do
          Hide
          Arun C Murthy added a comment -

          Jonathan, can u run 'mvn test' and test-patch and post results?

          Show
          Arun C Murthy added a comment - Jonathan, can u run 'mvn test' and test-patch and post results?
          Hide
          Jonathan Eagles added a comment -

          1153 fails in the same way, yet 1154 works.

          Seems to be related to which build machine it is run on.

          Hadoop3 and Hadoop4 just came online today and that is where the failures are happening.

          https://builds.apache.org/view/G-L/view/Hadoop/job/PreCommit-MAPREDUCE-Build/buildTimeTrend

          https://builds.apache.org/computer/hadoop4/builds
          https://builds.apache.org/computer/hadoop3/builds

          Show
          Jonathan Eagles added a comment - 1153 fails in the same way, yet 1154 works. Seems to be related to which build machine it is run on. Hadoop3 and Hadoop4 just came online today and that is where the failures are happening. https://builds.apache.org/view/G-L/view/Hadoop/job/PreCommit-MAPREDUCE-Build/buildTimeTrend https://builds.apache.org/computer/hadoop4/builds https://builds.apache.org/computer/hadoop3/builds
          Hide
          Jonathan Eagles added a comment -

          Not a good sign.
          1158 trunkCompile.txt

          /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/trunk/dev-support/test-patch.sh: line 260: /home/jenkins/tools/maven/latest/bin/mvn: No such file or directory

          1155, 1156, 1157 (3 different JIRAs and patches) all died in the same way

          [ERROR] Failed to execute goal org.codehaus.mojo:make-maven-plugin:1.0-beta-1:autoreconf (compile) on project hadoop-yarn-server-nodemanager: autoreconf command returned an exit value != 0. Aborting build; see debug output for more information. -> [Help 1]

          Seems like the build is broken. Will run it on my local machine to see the results.

          Show
          Jonathan Eagles added a comment - Not a good sign. 1158 trunkCompile.txt /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/trunk/dev-support/test-patch.sh: line 260: /home/jenkins/tools/maven/latest/bin/mvn: No such file or directory 1155, 1156, 1157 (3 different JIRAs and patches) all died in the same way [ERROR] Failed to execute goal org.codehaus.mojo:make-maven-plugin:1.0-beta-1:autoreconf (compile) on project hadoop-yarn-server-nodemanager: autoreconf command returned an exit value != 0. Aborting build; see debug output for more information. -> [Help 1] Seems like the build is broken. Will run it on my local machine to see the results.
          Hide
          Mahadev konar added a comment -

          Jenkins is crashing on this patch.

          Take a look at:

          https://builds.apache.org/view/G-L/view/Hadoop/job/PreCommit-MAPREDUCE-Build/1158/

          Compiling /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/trunk
          /home/jenkins/tools/maven/latest/bin/mvn clean test -DskipTests > /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/trunkCompile.txt 2>&1
          Top-level trunk compilation is broken?
          

          Someone needs to debug if thats a real issue or not, or try out mvn clean test to see why its failing.

          Show
          Mahadev konar added a comment - Jenkins is crashing on this patch. Take a look at: https://builds.apache.org/view/G-L/view/Hadoop/job/PreCommit-MAPREDUCE-Build/1158/ Compiling /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/trunk /home/jenkins/tools/maven/latest/bin/mvn clean test -DskipTests > /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/trunkCompile.txt 2>&1 Top-level trunk compilation is broken? Someone needs to debug if thats a real issue or not, or try out mvn clean test to see why its failing.
          Hide
          Arun C Murthy added a comment -

          +1 lgtm.

          I'll commit once Mr. Jenkins waves it through.

          Show
          Arun C Murthy added a comment - +1 lgtm. I'll commit once Mr. Jenkins waves it through.
          Hide
          Jonathan Eagles added a comment -

          New files added by this patch
          hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java

          Show
          Jonathan Eagles added a comment - New files added by this patch hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/AdminACLsManager.java
          Hide
          Jonathan Eagles added a comment -

          Seems like Jenkins fell over during the build. Kicking it again.

          Show
          Jonathan Eagles added a comment - Seems like Jenkins fell over during the build. Kicking it again.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12500967/MAPREDUCE-3175.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 170 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed the unit tests build

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-web-proxy.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500967/MAPREDUCE-3175.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 170 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed the unit tests build +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-web-proxy.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1155//console This message is automatically generated.
          Hide
          Jonathan Eagles added a comment -

          Uploaded a new patch addressing Arun's feedback.

          Notes:
          Ported ACLsManager admin functionality to yarn-common as AminACLsManager (did not port job or queue ACL functionality at this time)
          ApplicationACLsManager now uses AdminACLsManager to store its admin information

          Show
          Jonathan Eagles added a comment - Uploaded a new patch addressing Arun's feedback. Notes: Ported ACLsManager admin functionality to yarn-common as AminACLsManager (did not port job or queue ACL functionality at this time) ApplicationACLsManager now uses AdminACLsManager to store its admin information
          Hide
          Arun C Murthy added a comment -

          Seems ok, one nit - move ApplicationACLsManager to yarn-common rather than add module deps for yarn-server-common.

          Show
          Arun C Murthy added a comment - Seems ok, one nit - move ApplicationACLsManager to yarn-common rather than add module deps for yarn-server-common.
          Hide
          Jonathan Eagles added a comment -

          javadoc warnings are the same as last build.
          findbugs seems to be getting confused

          Show
          Jonathan Eagles added a comment - javadoc warnings are the same as last build. findbugs seems to be getting confused
          Hide
          Jonathan Eagles added a comment -

          -1 overall.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 8 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce -9 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Show
          Jonathan Eagles added a comment - -1 overall. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 8 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce -9 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests.
          Hide
          Jonathan Eagles added a comment -

          Patch needs HADOOP-7764 to compile. Will post test results from my box.

          Show
          Jonathan Eagles added a comment - Patch needs HADOOP-7764 to compile. Will post test results from my box.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12500529/MAPREDUCE-3175.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed the unit tests build

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1141//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1141//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500529/MAPREDUCE-3175.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed the unit tests build +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1141//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1141//console This message is automatically generated.
          Hide
          Jonathan Eagles added a comment -

          Will file another bug to address ease of use for non-MR apps.

          Show
          Jonathan Eagles added a comment - Will file another bug to address ease of use for non-MR apps.
          Hide
          Jonathan Eagles added a comment -

          Since this change only connected the ACLs to the HttpServer, I have added no tests since classes inheriting from WebApp are not very testable. Manual tests confirm /stack /metrics /logs /logLevel /conf and /jmx are not accessible by other users from RM, NM, HS, and AM.

          Show
          Jonathan Eagles added a comment - Since this change only connected the ACLs to the HttpServer, I have added no tests since classes inheriting from WebApp are not very testable. Manual tests confirm /stack /metrics /logs /logLevel /conf and /jmx are not accessible by other users from RM, NM, HS, and AM.
          Hide
          Jonathan Eagles added a comment -

          Uploaded a starter patch to get some initial feed back on the design. This patch certainly limits access to admin only on authorization enabled cluster to /stack /metrics /logs /logLevel /conf and /jmx

          • Verify overall design is correct
          • Looking for a solution to not have to modify HttpServer
          • What to do with JobACL in job history. Merge with ApplicationACLsManager?
          • ApplicationACLsManager seems to ignore CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION
          Show
          Jonathan Eagles added a comment - Uploaded a starter patch to get some initial feed back on the design. This patch certainly limits access to admin only on authorization enabled cluster to /stack /metrics /logs /logLevel /conf and /jmx Verify overall design is correct Looking for a solution to not have to modify HttpServer What to do with JobACL in job history. Merge with ApplicationACLsManager? ApplicationACLsManager seems to ignore CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION
          Hide
          Vinod Kumar Vavilapalli added a comment -

          I am adding an ApplicationACLsManager to RM and NM as part of MAPREDUCE-3104. Once that is done, doing this is trivial.

          Show
          Vinod Kumar Vavilapalli added a comment - I am adding an ApplicationACLsManager to RM and NM as part of MAPREDUCE-3104 . Once that is done, doing this is trivial.

            People

            • Assignee:
              Jonathan Eagles
              Reporter:
              Thomas Graves
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development