Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3026

When user adds hierarchical queues to the cluster, mapred queue -list returns NULL Pointer Exception

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: jobtracker
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      When User adds the hierarchical queues, and try to see them from the command line using
      mapred queue -list
      It returns Null Pointer Exception.

      1. patch-22.patch
        1 kB
        Mayank Bansal
      2. patch-22
        1 kB
        Mayank Bansal

        Activity

        Konstantin Shvachko made changes -
        Assignee Mayank Bansal [ mayank_bansal ]
        Description When User adds the hierarchical queues, and try to see them from the command line using
        mapred queue -list

        It returns Null Pointer Exception.
        When User adds the hierarchical queues, and try to see them from the command line using
        mapred queue -list
        It returns Null Pointer Exception.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-22-branch #73 (See https://builds.apache.org/job/Hadoop-Mapreduce-22-branch/73/)
        MAPREDUCE-3026. Fix NPE in mapred queue -list with hierarchical queues. Contributed by Mayank Bansal.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1175218
        Files :

        • /hadoop/common/branches/branch-0.22/mapreduce/CHANGES.txt
        • /hadoop/common/branches/branch-0.22/mapreduce/src/java/org/apache/hadoop/mapred/JobQueueInfo.java
        • /hadoop/common/branches/branch-0.22/mapreduce/src/java/org/apache/hadoop/mapred/JobTracker.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-22-branch #73 (See https://builds.apache.org/job/Hadoop-Mapreduce-22-branch/73/ ) MAPREDUCE-3026 . Fix NPE in mapred queue -list with hierarchical queues. Contributed by Mayank Bansal. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1175218 Files : /hadoop/common/branches/branch-0.22/mapreduce/CHANGES.txt /hadoop/common/branches/branch-0.22/mapreduce/src/java/org/apache/hadoop/mapred/JobQueueInfo.java /hadoop/common/branches/branch-0.22/mapreduce/src/java/org/apache/hadoop/mapred/JobTracker.java
        Konstantin Shvachko made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Konstantin Shvachko added a comment -

        I just committed this. Thank you Mayank.
        I assume this is not applicable for trunk.

        Show
        Konstantin Shvachko added a comment - I just committed this. Thank you Mayank. I assume this is not applicable for trunk.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12495310/patch-22.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/806//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12495310/patch-22.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/806//console This message is automatically generated.
        Hide
        Mayank Bansal added a comment -

        Test is not included as it is a command line option for show the listing of the queues

        mapred queue -list

        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no new tests are needed for this patch.
        [exec] Also please list what manual steps were performed to verify this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]
        [exec] +1 system test framework. The patch passed system test framework compile.
        [exec]
        [exec]
        [exec]
        [exec]
        [exec] ======================================================================
        [exec] ======================================================================
        [exec] Finished build.
        [exec] ======================================================================
        [exec] ======================================================================

        Show
        Mayank Bansal added a comment - Test is not included as it is a command line option for show the listing of the queues mapred queue -list [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ======================================================================
        Mayank Bansal made changes -
        Attachment patch-22.patch [ 12495310 ]
        Hide
        Mayank Bansal added a comment -

        Latest patch

        Show
        Mayank Bansal added a comment - Latest patch
        Mayank Bansal made changes -
        Release Note There are two changes which needs to be done in order to fix the Null Pointer Exception.
        1. Job tracker was not setting the job statuses for the leaf queues, so we need to fix the job tracker to set the running job statuses for the leaf queues.
        2. When we are decserializing the jobqueueInfo object at the client side then it was actually expecting the jobqueueInfo object however from the Queinfo class we were passing the Queinfo object which needs to be changed to jobqueueInfo object.
        Hide
        Mayank Bansal added a comment -

        There are two changes which needs to be done in order to fix the Null Pointer Exception.
        1. Job tracker was not setting the job statuses for the leaf queues, so we need to fix the job tracker to set the running job statuses for the leaf queues.
        2. When we are decserializing the jobqueueInfo object at the client side then it was actually expecting the jobqueueInfo object however from the Queinfo class we were passing the Queinfo object which needs to be changed to jobqueueInfo object.

        Show
        Mayank Bansal added a comment - There are two changes which needs to be done in order to fix the Null Pointer Exception. 1. Job tracker was not setting the job statuses for the leaf queues, so we need to fix the job tracker to set the running job statuses for the leaf queues. 2. When we are decserializing the jobqueueInfo object at the client side then it was actually expecting the jobqueueInfo object however from the Queinfo class we were passing the Queinfo object which needs to be changed to jobqueueInfo object.
        Hide
        Konstantin Shvachko added a comment -

        +1 looks good. Could you please run test-patch target and paste the results here.

        Show
        Konstantin Shvachko added a comment - +1 looks good. Could you please run test-patch target and paste the results here.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12495140/patch-22
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/789//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12495140/patch-22 against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/789//console This message is automatically generated.
        Mayank Bansal made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Release Note There are two changes which needs to be done in order to fix the Null Pointer Exception.
        1. Job tracker was not setting the job statuses for the leaf queues, so we need to fix the job tracker to set the running job statuses for the leaf queues.
        2. When we are decserializing the jobqueueInfo object at the client side then it was actually expecting the jobqueueInfo object however from the Queinfo class we were passing the Queinfo object which needs to be changed to jobqueueInfo object.
        Affects Version/s 0.22.0 [ 12314184 ]
        Labels patch
        Mayank Bansal made changes -
        Field Original Value New Value
        Attachment patch-22 [ 12495140 ]
        Hide
        Mayank Bansal added a comment -

        Initial patch for review

        Show
        Mayank Bansal added a comment - Initial patch for review
        Mayank Bansal created issue -

          People

          • Assignee:
            Mayank Bansal
            Reporter:
            Mayank Bansal
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development