Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.204.0
    • Fix Version/s: 1.1.0
    • Component/s: tasktracker
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Like HDFS-811/HDFS-1850 but for the TT.

      1. mapreduce-3015-2.patch
        16 kB
        Eli Collins
      2. mapreduce-3015-1.patch
        15 kB
        Eli Collins

        Issue Links

          Activity

          Hide
          Eli Collins added a comment -

          Patch attached for branch-20-security. Adds a metrics for local dir failures, test for the metric, and a new column on the machines list JT UI, which I manually verified.

          Show
          Eli Collins added a comment - Patch attached for branch-20-security. Adds a metrics for local dir failures, test for the metric, and a new column on the machines list JT UI, which I manually verified.
          Hide
          Eli Collins added a comment -

          Here are test-patch results, unit tests running.

               [exec] 
               [exec] +1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     +1 tests included.  The patch appears to include 12 new or modified tests.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version ) warnings.
               [exec] 
          
          Show
          Eli Collins added a comment - Here are test-patch results, unit tests running. [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 12 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. [exec]
          Hide
          Eli Collins added a comment -

          All the tests pass modulo the three that currently fail on the branch (MR-3356, 3357 and 3358).

          Show
          Eli Collins added a comment - All the tests pass modulo the three that currently fail on the branch (MR-3356, 3357 and 3358).
          Hide
          Todd Lipcon added a comment -
          +   * Version 30: Changed TaskStatus for MAPREDUCE-3015
              */
          

          can you add a few words like "to include local dir failure metrics" so people don't have to jump to JIRA?


          -        put("failures", tts.getFailures());
          +        put("failures", tts.getTaskFailures());
          +        put("dirFailures", tts.getDirFailures());
                 }});
          

          "dir_failures" would be more consistent with the other metrics (eg reduce_slots)

          Otherwise looks good

          Show
          Todd Lipcon added a comment - + * Version 30: Changed TaskStatus for MAPREDUCE-3015 */ can you add a few words like "to include local dir failure metrics" so people don't have to jump to JIRA? - put( "failures" , tts.getFailures()); + put( "failures" , tts.getTaskFailures()); + put( "dirFailures" , tts.getDirFailures()); }}); "dir_failures" would be more consistent with the other metrics (eg reduce_slots ) Otherwise looks good
          Hide
          Eli Collins added a comment -

          Thanks Todd, updated patch attached.

          Show
          Eli Collins added a comment - Thanks Todd, updated patch attached.
          Hide
          Eli Collins added a comment -

          Since the changes to the previous patch were trivial I went ahead and committed this. Thanks Todd.

          Show
          Eli Collins added a comment - Since the changes to the previous patch were trivial I went ahead and committed this. Thanks Todd.
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop-1.1.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development