Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3009

RM UI -> Applications -> Application(Job History) -> Map Tasks -> Task ID -> Node link is not working

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.2
    • Component/s: jobhistoryserver, mrv2
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Fixed node link on JobHistory webapp.

      Description

      RM UI -> Applications -> Application(Job History) -> Map Tasks -> Task ID -> Node link is not working. The URL contains extra '/' which is causing the problem. Please find in the attached screen shots.

      1. invalid_url.png
        287 kB
        chackaravarthy
      2. MAPREDUCE-3009.patch
        1.0 kB
        chackaravarthy
      3. invalid_url_latest_code.png
        295 kB
        chackaravarthy
      4. IE_node_link_not_working.png
        261 kB
        chackaravarthy
      5. chrome_node_link_working.png
        341 kB
        chackaravarthy
      6. MAPREDUCE-3009-1.patch
        1.0 kB
        chackaravarthy
      7. MAPREDUCE-3009.patch
        1 kB
        Arun C Murthy

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1011 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1011/)
        MAPREDUCE-3009. Fixed node link on JobHistory webapp. Contributed by hackaravarthy. (Revision 1297149)

        Result = FAILURE
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297149
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1011 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1011/ ) MAPREDUCE-3009 . Fixed node link on JobHistory webapp. Contributed by hackaravarthy. (Revision 1297149) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297149 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #217 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/217/)
        MAPREDUCE-3009. Fixed node link on JobHistory webapp. Contributed by Chackaravarthy.
        svn merge --ignore-ancestry -c 1297149 ../../trunk/ (Revision 1297150)

        Result = FAILURE
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297150
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #217 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/217/ ) MAPREDUCE-3009 . Fixed node link on JobHistory webapp. Contributed by Chackaravarthy. svn merge --ignore-ancestry -c 1297149 ../../trunk/ (Revision 1297150) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297150 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #976 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/976/)
        MAPREDUCE-3009. Fixed node link on JobHistory webapp. Contributed by hackaravarthy. (Revision 1297149)

        Result = SUCCESS
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297149
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #976 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/976/ ) MAPREDUCE-3009 . Fixed node link on JobHistory webapp. Contributed by hackaravarthy. (Revision 1297149) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297149 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #189 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/189/)
        MAPREDUCE-3009. Fixed node link on JobHistory webapp. Contributed by Chackaravarthy.
        svn merge --ignore-ancestry -c 1297149 ../../trunk/ (Revision 1297150)

        Result = SUCCESS
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297150
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #189 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/189/ ) MAPREDUCE-3009 . Fixed node link on JobHistory webapp. Contributed by Chackaravarthy. svn merge --ignore-ancestry -c 1297149 ../../trunk/ (Revision 1297150) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297150 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1841 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1841/)
        MAPREDUCE-3009. Fixed node link on JobHistory webapp. Contributed by hackaravarthy. (Revision 1297149)

        Result = ABORTED
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297149
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1841 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1841/ ) MAPREDUCE-3009 . Fixed node link on JobHistory webapp. Contributed by hackaravarthy. (Revision 1297149) Result = ABORTED vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297149 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #638 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/638/)
        MAPREDUCE-3009. Fixed node link on JobHistory webapp. Contributed by Chackaravarthy.
        svn merge --ignore-ancestry -c 1297149 ../../trunk/ (Revision 1297150)

        Result = FAILURE
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297150
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #638 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/638/ ) MAPREDUCE-3009 . Fixed node link on JobHistory webapp. Contributed by Chackaravarthy. svn merge --ignore-ancestry -c 1297149 ../../trunk/ (Revision 1297150) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297150 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Just committed this to trunk, branch-0.23 and branch-0.23.2. Thanks Chackaravarthy for the bug report and the patches! Thanks Arun of the last update!

        Show
        Vinod Kumar Vavilapalli added a comment - Just committed this to trunk, branch-0.23 and branch-0.23.2. Thanks Chackaravarthy for the bug report and the patches! Thanks Arun of the last update!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1834 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1834/)
        MAPREDUCE-3009. Fixed node link on JobHistory webapp. Contributed by hackaravarthy. (Revision 1297149)

        Result = SUCCESS
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297149
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1834 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1834/ ) MAPREDUCE-3009 . Fixed node link on JobHistory webapp. Contributed by hackaravarthy. (Revision 1297149) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297149 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #628 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/628/)
        MAPREDUCE-3009. Fixed node link on JobHistory webapp. Contributed by Chackaravarthy.
        svn merge --ignore-ancestry -c 1297149 ../../trunk/ (Revision 1297150)

        Result = SUCCESS
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297150
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #628 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/628/ ) MAPREDUCE-3009 . Fixed node link on JobHistory webapp. Contributed by Chackaravarthy. svn merge --ignore-ancestry -c 1297149 ../../trunk/ (Revision 1297150) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297150 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTaskPage.java
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12517038/MAPREDUCE-3009.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1995//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1995//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12517038/MAPREDUCE-3009.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1995//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1995//console This message is automatically generated.
        Hide
        Arun C Murthy added a comment -

        The patch discussed...

        Show
        Arun C Murthy added a comment - The patch discussed...
        Hide
        Arun C Murthy added a comment -

        chackaravarthy any update on the patch? Tx.

        Show
        Arun C Murthy added a comment - chackaravarthy any update on the patch? Tx.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        shall i proceed with simple concatenation or fixing the ujoin method?

        Please proceed with a simple concatenation.

        This isn't critical, downgrading it.

        Show
        Vinod Kumar Vavilapalli added a comment - shall i proceed with simple concatenation or fixing the ujoin method? Please proceed with a simple concatenation. This isn't critical, downgrading it.
        Hide
        Milind Bhandarkar added a comment -

        @Vinod,

        I wanted to say "I am amused that someone is using IE"

        Just checked the date on that comment

        Show
        Milind Bhandarkar added a comment - @Vinod, I wanted to say "I am amused that someone is using IE" Just checked the date on that comment
        Hide
        chackaravarthy added a comment -

        here url method internally using ujoin method which is being used in many places.
        And actually here now i feel like no need to use url method at all.
        simply ,

         td().a(".nodelink", "http://"+ nodeHttpAddr, nodeHttpAddr)._(); 

        this may be enough i think. Because I see the similar usage for getting node link in NodesPage.java

         td().a("http://" + ni.getHttpAddress(), ni.getHttpAddress())._(). 

        shall i proceed with simple concatenation or fixing the ujoin method?

        Thanks

        Show
        chackaravarthy added a comment - here url method internally using ujoin method which is being used in many places. And actually here now i feel like no need to use url method at all. simply , td().a( ".nodelink" , "http: //" + nodeHttpAddr, nodeHttpAddr)._(); this may be enough i think. Because I see the similar usage for getting node link in NodesPage.java td().a( "http: //" + ni.getHttpAddress(), ni.getHttpAddress())._(). shall i proceed with simple concatenation or fixing the ujoin method? Thanks
        Hide
        Vinod Kumar Vavilapalli added a comment -

        I wanted to say "I am amused that someone is using IE" But I kind of started liking your screen-shots, so holding that back

        Anyways, thanks for the analysis. But can we fix the url method itself so that url("http://", address) returns a correct URL? Thanks.

        Show
        Vinod Kumar Vavilapalli added a comment - I wanted to say "I am amused that someone is using IE" But I kind of started liking your screen-shots, so holding that back Anyways, thanks for the analysis. But can we fix the url method itself so that url("http://", address) returns a correct URL? Thanks.
        Hide
        chackaravarthy added a comment -

        Test cases are not required because it is a trivial change

        Show
        chackaravarthy added a comment - Test cases are not required because it is a trivial change
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12498863/MAPREDUCE-3009-1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1003//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1003//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12498863/MAPREDUCE-3009-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1003//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1003//console This message is automatically generated.
        Hide
        chackaravarthy added a comment -

        Hi Vinod,

        In Firefox and Chrome, even if we give URL as "http:///www.google.com" , it will be taken as "http://www.google.com"

        But in Internet Explorer, its been taken as same what the URL we are giving. ie. as "http:///www.google.com" only.

        Hence the problem.

        Even though the URL being constructed in HsTaskPage as "http:///hostname", its not getting reflected in the browser.

        With the attached patch (MAPREDUCE-3009-1), its working fine in all the browsers.

        Thanks

        Show
        chackaravarthy added a comment - Hi Vinod, In Firefox and Chrome, even if we give URL as "http:///www.google.com" , it will be taken as "http://www.google.com" But in Internet Explorer, its been taken as same what the URL we are giving. ie. as "http:///www.google.com" only. Hence the problem. Even though the URL being constructed in HsTaskPage as "http:///hostname", its not getting reflected in the browser. With the attached patch ( MAPREDUCE-3009 -1), its working fine in all the browsers. Thanks
        Hide
        chackaravarthy added a comment -

        Attached the patch. pls review. Thanks.

        Show
        chackaravarthy added a comment - Attached the patch. pls review. Thanks.
        Hide
        chackaravarthy added a comment -

        Hi Vinod,
        As you said, there is a change in the latest code (ip address is replaced by host name)

        But still that problem exists.
        I see it as a Browser level problem. I was using InternetExplorer only earlier and hence added the screen shot for those.
        Now I checked in Chrome Browser and there its working fine.

        I am not sure how it will behave in FireFox. I have some problem in firefox installation in my system.

        So I have attached the screenshots for other 2 browsers (IE and Chrome)

        This issue exists in IE browser only. In chrome its working properly.

        Thanks

        Show
        chackaravarthy added a comment - Hi Vinod, As you said, there is a change in the latest code (ip address is replaced by host name) But still that problem exists. I see it as a Browser level problem. I was using InternetExplorer only earlier and hence added the screen shot for those. Now I checked in Chrome Browser and there its working fine. I am not sure how it will behave in FireFox. I have some problem in firefox installation in my system. So I have attached the screenshots for other 2 browsers (IE and Chrome) This issue exists in IE browser only. In chrome its working properly. Thanks
        Hide
        Vinod Kumar Vavilapalli added a comment -

        The IP addresses have changed to hostnames in one of the recent patches. Can you recheck? I have the latest code and I don't see this. Or this something platform dependant? Another screenshot on the latest code?

        Show
        Vinod Kumar Vavilapalli added a comment - The IP addresses have changed to hostnames in one of the recent patches. Can you recheck? I have the latest code and I don't see this. Or this something platform dependant? Another screenshot on the latest code?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12495054/invalid_url_latest_code.png
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/989//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12495054/invalid_url_latest_code.png against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/989//console This message is automatically generated.
        Hide
        chackaravarthy added a comment -

        Hi, I find the same problem in the updated code also on clicking node link. This is because of extra slash in the URL. The patch is still not stale.pls review the patch. Thanks.

        Show
        chackaravarthy added a comment - Hi, I find the same problem in the updated code also on clicking node link. This is because of extra slash in the URL. The patch is still not stale.pls review the patch. Thanks.
        Hide
        chackaravarthy added a comment -

        pls check. Thanks

        Show
        chackaravarthy added a comment - pls check. Thanks
        Hide
        chackaravarthy added a comment -

        I checked with updated code also. The same issue exists.
        Actually when I raised this issue, there were 2 links in this page (one for node and other one for logs)
        After HsTaskPage is updated (on 18th Sep) and hence there is only one link in that page (only node link) and i checked whether this has been resolved or not.. but that still exists..
        so i changed the issue description removing logs link and keeping node link alone..
        (Also you can see the advanced search boxes (in the attached snapshot invalid_url_latest_code.png) there for each column which is because of updated code on sep18th)

        Show
        chackaravarthy added a comment - I checked with updated code also. The same issue exists. Actually when I raised this issue, there were 2 links in this page (one for node and other one for logs) After HsTaskPage is updated (on 18th Sep) and hence there is only one link in that page (only node link) and i checked whether this has been resolved or not.. but that still exists.. so i changed the issue description removing logs link and keeping node link alone.. (Also you can see the advanced search boxes (in the attached snapshot invalid_url_latest_code.png) there for each column which is because of updated code on sep18th)
        Hide
        Vinod Kumar Vavilapalli added a comment -

        HsTaskPage changed as recently as Sep18th. And I am not finding the problem you outlined on the latest code. Can you please verify once more? Thanks.

        Show
        Vinod Kumar Vavilapalli added a comment - HsTaskPage changed as recently as Sep18th. And I am not finding the problem you outlined on the latest code. Can you please verify once more? Thanks.
        Hide
        chackaravarthy added a comment -

        Test cases are not required because it is a trivial change.

        Show
        chackaravarthy added a comment - Test cases are not required because it is a trivial change.
        Hide
        chackaravarthy added a comment -

        Steps to verify :
        =================

        RM UI -> Applications -> Application(Job History) -> Map Tasks -> Task ID

        Here task attempt page will open.
        In the page, click on node link.
        Earlier it was not working.. Now it will work

        change in HsTaskPage.java:
        ==========================

        Earlier the URL it was linked in anchor tag was http:///nodeHttpAddr
        but it should be http://nodeHttpAddr

        It is because "http://" and nodeHttpAddr was passed as 2 strings to method

        url(String... parts) in View.java

        It should be passed as single string to url method.
        hence the change as
        before : td().a(".nodelink", url("http://", nodeHttpAddr), nodeHttpAddr)._();
        after the fix : td().a(".nodelink", url("http://"+ nodeHttpAddr), nodeHttpAddr)._();

        Show
        chackaravarthy added a comment - Steps to verify : ================= RM UI -> Applications -> Application(Job History) -> Map Tasks -> Task ID Here task attempt page will open. In the page, click on node link. Earlier it was not working.. Now it will work change in HsTaskPage.java: ========================== Earlier the URL it was linked in anchor tag was http:///nodeHttpAddr but it should be http://nodeHttpAddr It is because "http://" and nodeHttpAddr was passed as 2 strings to method url(String... parts) in View.java It should be passed as single string to url method. hence the change as before : td().a(".nodelink", url("http://", nodeHttpAddr), nodeHttpAddr)._(); after the fix : td().a(".nodelink", url("http://"+ nodeHttpAddr), nodeHttpAddr)._();
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12494782/MAPREDUCE-3009.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/759//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/759//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494782/MAPREDUCE-3009.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/759//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/759//console This message is automatically generated.
        Hide
        chackaravarthy added a comment -

        Attached the patch

        Show
        chackaravarthy added a comment - Attached the patch

          People

          • Assignee:
            chackaravarthy
            Reporter:
            chackaravarthy
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development