Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2991

queueinfo.jsp fails to show queue status if any Capacity scheduler queue name has dash/hiphen in it.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0, 0.23.0
    • Component/s: scheduler
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If any queue name has a dash/hiphen in it, the queueinfo.jsp doesn't show any queue information. This is happening because the queue name is used to create javascript variables and javascript doesn't allow dash in variable names.

      1. Job Queue Information page.html
        6 kB
        Priyo Mustafi
      2. Job Queue Information page.pdf
        55 kB
        Priyo Mustafi
      3. mapred-queues.xml
        2 kB
        Priyo Mustafi
      4. MAPREDUCE_2991_022.patch
        0.9 kB
        Priyo Mustafi
      5. MAPREDUCE_2991_trunk.patch
        0.9 kB
        Priyo Mustafi

        Activity

        Hide
        Priyo Mustafi added a comment -

        Patch for the fix

        Show
        Priyo Mustafi added a comment - Patch for the fix
        Hide
        Priyo Mustafi added a comment -

        Trunk patch

        Show
        Priyo Mustafi added a comment - Trunk patch
        Hide
        Priyo Mustafi added a comment -

        Patch submitted for 0.22 and trunk

        Show
        Priyo Mustafi added a comment - Patch submitted for 0.22 and trunk
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12494288/MAPREDUCE_2991_trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/722//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/722//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494288/MAPREDUCE_2991_trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/722//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/722//console This message is automatically generated.
        Hide
        Konstantin Shvachko added a comment -

        Could you check other special symbols as well.

        Show
        Konstantin Shvachko added a comment - Could you check other special symbols as well.
        Hide
        Priyo Mustafi added a comment -

        Patch handling other invalid javascript variables

        Show
        Priyo Mustafi added a comment - Patch handling other invalid javascript variables
        Hide
        Priyo Mustafi added a comment -

        Patch which handles other invalid characters as well

        Show
        Priyo Mustafi added a comment - Patch which handles other invalid characters as well
        Hide
        Priyo Mustafi added a comment -

        Replaced patch with fix to catch more bad variables

        Show
        Priyo Mustafi added a comment - Replaced patch with fix to catch more bad variables
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12494366/MAPREDUCE_2991_022.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/730//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/730//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494366/MAPREDUCE_2991_022.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/730//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/730//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12494367/MAPREDUCE_2991_trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/731//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/731//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494367/MAPREDUCE_2991_trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/731//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/731//console This message is automatically generated.
        Hide
        Priyo Mustafi added a comment -

        Used the attached mapred-queues.xml file to test. The queueinfo.jsp showed up as expected (attached)

        Show
        Priyo Mustafi added a comment - Used the attached mapred-queues.xml file to test. The queueinfo.jsp showed up as expected (attached)
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12494484/Job+Queue+Information+page.pdf
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/738//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494484/Job+Queue+Information+page.pdf against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/738//console This message is automatically generated.
        Hide
        Konstantin Shvachko added a comment -

        +1 lgtm

        Show
        Konstantin Shvachko added a comment - +1 lgtm
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #890 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/890/)
        MAPREDUCE-2991. queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170917
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/webapps/job/queueinfo.jsp
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #890 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/890/ ) MAPREDUCE-2991 . queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170917 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/webapps/job/queueinfo.jsp
        Hide
        Konstantin Shvachko added a comment -

        I just committed this.

        Show
        Konstantin Shvachko added a comment - I just committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #967 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/967/)
        MAPREDUCE-2991. queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170917
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/webapps/job/queueinfo.jsp
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #967 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/967/ ) MAPREDUCE-2991 . queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170917 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/webapps/job/queueinfo.jsp
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #902 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/902/)
        MAPREDUCE-2991. queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170917
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/webapps/job/queueinfo.jsp
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #902 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/902/ ) MAPREDUCE-2991 . queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170917 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/webapps/job/queueinfo.jsp
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-22-branch #69 (See https://builds.apache.org/job/Hadoop-Mapreduce-22-branch/69/)
        MAPREDUCE-2991. queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170918
        Files :

        • /hadoop/common/branches/branch-0.22/mapreduce/CHANGES.txt
        • /hadoop/common/branches/branch-0.22/mapreduce/src/webapps/job/queueinfo.jsp
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-22-branch #69 (See https://builds.apache.org/job/Hadoop-Mapreduce-22-branch/69/ ) MAPREDUCE-2991 . queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170918 Files : /hadoop/common/branches/branch-0.22/mapreduce/CHANGES.txt /hadoop/common/branches/branch-0.22/mapreduce/src/webapps/job/queueinfo.jsp
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #7 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/7/)
        MAPREDUCE-2991. queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170922
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job/queueinfo.jsp
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #7 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/7/ ) MAPREDUCE-2991 . queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170922 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job/queueinfo.jsp
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #831 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/831/)
        MAPREDUCE-2991. queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170917
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/webapps/job/queueinfo.jsp
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #831 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/831/ ) MAPREDUCE-2991 . queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170917 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/webapps/job/queueinfo.jsp
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #5 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/5/)
        MAPREDUCE-2991. queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170922
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job/queueinfo.jsp
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #5 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/5/ ) MAPREDUCE-2991 . queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170922 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job/queueinfo.jsp
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #801 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/801/)
        MAPREDUCE-2991. queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170917
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/webapps/job/queueinfo.jsp
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #801 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/801/ ) MAPREDUCE-2991 . queueinfo.jsp fails if queue names contain special symbols. Contributed by Priyo Mustafi. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170917 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/webapps/job/queueinfo.jsp

          People

          • Assignee:
            Priyo Mustafi
            Reporter:
            Priyo Mustafi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development