[MAPREDUCE-2985] findbugs error in ResourceLocalizationService.handle(LocalizationEvent)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.23.0, 2.0.0-alpha
• Fix Version/s: 0.23.0
• Component/s: mrv2
• Assignee: Thomas Graves
• Reporter: Thomas Graves
• Created: 12/Sep/11 18:24
• Updated: 16/Mar/15 17:57
• Resolved: 12/Sep/11 21:54

Description

hudson mapreduce is reporting a findbugs error:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/707//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html

WMI Method org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService.handle(LocalizationEvent) makes inefficient use of keySet iterator instead of entrySet iterator

Bug type WMI_WRONG_MAP_ITERATOR (click for details)
In class org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService
In method org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService.handle(LocalizationEvent)
At ResourceLocalizationService.java:[line 295]
Another occurrence at ResourceLocalizationService.java:[line 318]