Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 3.0.0
    • Component/s: mrv2
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It seems that hudson is not properly reporting findbug failures introduced by jiras.

      Here is an example where hudson gave the jira a +1 for findbugs but it really introduced a bug:
      https://issues.apache.org/jira/browse/MAPREDUCE-2937

      The actual findbugs report - you'll see there is 1:
      https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/662//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-jobclient.html

      Note that I had to enter in the extra path of hadoop-mapreduce-project to see the html file so perhaps the path it is using to do the diff is wrong.

      1. MAPREDUCE-2978.patch
        1 kB
        Tom White
      2. MAPREDUCE-2978-20110912.txt
        1 kB
        Vinod Kumar Vavilapalli

        Activity

        Hide
        Vinod Kumar Vavilapalli added a comment -

        It's been more than an hour since the resubmit, but Jenkins hasn't returned since. I'm afraid I may have bombed Jenkins with this patch

        Okay Amareshwari figured this one out by reattaching the same patch to MAPREDUCE-2979. Jenkins duly performed his duty.

        She says:

        https://builds.apache.org/job/PreCommit-Admin/ : see how to trigger. The combination of a Jira being in Patch Available state AND having a new attachment that has never been processed by this system is what will trigger a new test of the patch.

        Something new for the day, thanks Amareshwari!

        Closing this as resolved.

        Show
        Vinod Kumar Vavilapalli added a comment - It's been more than an hour since the resubmit, but Jenkins hasn't returned since. I'm afraid I may have bombed Jenkins with this patch Okay Amareshwari figured this one out by reattaching the same patch to MAPREDUCE-2979 . Jenkins duly performed his duty. She says: https://builds.apache.org/job/PreCommit-Admin/ : see how to trigger. The combination of a Jira being in Patch Available state AND having a new attachment that has never been processed by this system is what will trigger a new test of the patch. Something new for the day, thanks Amareshwari! Closing this as resolved.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #815 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/815/)
        MAPREDUCE-2978. Fixed test-patch to make Jenkins report findbugs warnings properly. Contributed by Tom White.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169696
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #815 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/815/ ) MAPREDUCE-2978 . Fixed test-patch to make Jenkins report findbugs warnings properly. Contributed by Tom White. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169696 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        Hide
        Vinod Kumar Vavilapalli added a comment -

        I committed this patch to trunk, and resubmitted MAPREDUCE-2675 to Jenkins. Left this ticket unresolved to wait for Jenkins' confirmation on one of the patches.

        It's been more than an hour since the resubmit, but Jenkins hasn't returned since. I'm afraid I may have bombed Jenkins with this patch. If I don't give any more update my time (IST), and Jenkins still doesn't come back, this patch can be a potential suspect and offers itself for a revert.

        Show
        Vinod Kumar Vavilapalli added a comment - I committed this patch to trunk, and resubmitted MAPREDUCE-2675 to Jenkins. Left this ticket unresolved to wait for Jenkins' confirmation on one of the patches. It's been more than an hour since the resubmit, but Jenkins hasn't returned since. I'm afraid I may have bombed Jenkins with this patch. If I don't give any more update my time (IST), and Jenkins still doesn't come back, this patch can be a potential suspect and offers itself for a revert.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #791 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/791/)
        MAPREDUCE-2978. Fixed test-patch to make Jenkins report findbugs warnings properly. Contributed by Tom White.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169696
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #791 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/791/ ) MAPREDUCE-2978 . Fixed test-patch to make Jenkins report findbugs warnings properly. Contributed by Tom White. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169696 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #947 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/947/)
        MAPREDUCE-2978. Fixed test-patch to make Jenkins report findbugs warnings properly. Contributed by Tom White.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169696
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #947 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/947/ ) MAPREDUCE-2978 . Fixed test-patch to make Jenkins report findbugs warnings properly. Contributed by Tom White. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169696 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #882 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/882/)
        MAPREDUCE-2978. Fixed test-patch to make Jenkins report findbugs warnings properly. Contributed by Tom White.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169696
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #882 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/882/ ) MAPREDUCE-2978 . Fixed test-patch to make Jenkins report findbugs warnings properly. Contributed by Tom White. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169696 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #870 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/870/)
        MAPREDUCE-2978. Fixed test-patch to make Jenkins report findbugs warnings properly. Contributed by Tom White.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169696
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #870 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/870/ ) MAPREDUCE-2978 . Fixed test-patch to make Jenkins report findbugs warnings properly. Contributed by Tom White. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169696 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        Hide
        Vinod Kumar Vavilapalli added a comment -

        This should fix the unnecessary findBugs comments when there are no warning.

        Show
        Vinod Kumar Vavilapalli added a comment - This should fix the unnecessary findBugs comments when there are no warning.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Forcing Jenkins to use test-patch to test changes test-patches! I must be dreaming!

        Cancelling the patch to incorporate one more minor change: Jenkins prints the links to findBugs warning even when there are none.

        Show
        Vinod Kumar Vavilapalli added a comment - Forcing Jenkins to use test-patch to test changes test-patches! I must be dreaming! Cancelling the patch to incorporate one more minor change: Jenkins prints the links to findBugs warning even when there are none.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12493869/MAPREDUCE-2978.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/703//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493869/MAPREDUCE-2978.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/703//console This message is automatically generated.
        Hide
        Tom White added a comment -

        This patch fixes the URL and the number of allowed findbugs warnings (0).

        Show
        Tom White added a comment - This patch fixes the URL and the number of allowed findbugs warnings (0).
        Hide
        Tom White added a comment -

        Looking in the console, it did find the findbugs violation (
        https://builds.apache.org/view/G-L/view/Hadoop/job/PreCommit-MapReduce-Build/662/console):

        Found 1 Findbugs warnings (/home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/target/findbugsXml.xml)
        

        The fact it didn't report it is probably because the number in hadoop-mapreduce-project/dev-support/test-patch.properties is higher than 1. It should be changed to be zero.

        I'll take a look at fixing this issue.

        Show
        Tom White added a comment - Looking in the console, it did find the findbugs violation ( https://builds.apache.org/view/G-L/view/Hadoop/job/PreCommit-MapReduce-Build/662/console): Found 1 Findbugs warnings (/home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/target/findbugsXml.xml) The fact it didn't report it is probably because the number in hadoop-mapreduce-project/dev-support/test-patch.properties is higher than 1. It should be changed to be zero. I'll take a look at fixing this issue.
        Hide
        Thomas Graves added a comment -

        Note that when I ran test-patch manually it found the bug.

        Show
        Thomas Graves added a comment - Note that when I ran test-patch manually it found the bug.

          People

          • Assignee:
            Tom White
            Reporter:
            Thomas Graves
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development