Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2932

Missing instrumentation plugin class shouldn't crash the TT startup per design

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0
    • Component/s: tasktracker
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Per the implementation of the TaskTracker instrumentation plugin implementation (from 2008), a ClassNotFoundException during loading up of an configured TaskTracker instrumentation class shouldn't have hampered TT start up at all.

      But, there is one class-fetching call outside try/catch, which makes TT fall down with a RuntimeException if there's a class not found. Would be good to include this line into the try/catch itself.

      Strace would appear as:

      2011-08-25 11:45:38,470 ERROR org.apache.hadoop.mapred.TaskTracker: Can not start task tracker because java.lang.RuntimeException: java.lang.RuntimeException: java.lang.ClassNotFoundException: org.apache.hadoop.mapred.CustomInstPlugin 
      at org.apache.hadoop.conf.Configuration.getClass(Configuration.java) 
      at org.apache.hadoop.mapred.TaskTracker.getInstrumentationClass(TaskTracker.java) 
      at org.apache.hadoop.mapred.TaskTracker.initialize(TaskTracker.java) 
      
      1. 0.20-MAPREDUCE-2932.r3.diff
        5 kB
        Harsh J
      2. 0.20-MAPREDUCE-2932.r2.diff
        5 kB
        Harsh J
      3. 0.20-MAPREDUCE-2932.r1.diff
        2 kB
        Harsh J

        Activity

        Harsh J created issue -
        Harsh J made changes -
        Field Original Value New Value
        Attachment 0.20-MAPREDUCE-2932.r1.diff [ 12493041 ]
        Harsh J made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Eli Collins made changes -
        Fix Version/s 0.20.206.0 [ 12317960 ]
        Affects Version/s 0.20.2 [ 12314205 ]
        Harsh J made changes -
        Attachment 0.20-MAPREDUCE-2932.r2.diff [ 12495258 ]
        Harsh J made changes -
        Attachment 0.20-MAPREDUCE-2932.r3.diff [ 12496060 ]
        Eli Collins made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Matt Foley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Harsh J
            Reporter:
            Harsh J
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development