Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: mrv2
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The RM Application finishTime isn't being set. Looks like it got lost in the RM refactor.

      1. MAPREDUCE-2781-v2.patch
        21 kB
        Thomas Graves
      2. finishtime.patch
        3 kB
        Thomas Graves

        Activity

        Thomas Graves created issue -
        Thomas Graves made changes -
        Field Original Value New Value
        Attachment finishtime.patch [ 12489439 ]
        Hide
        Mahadev konar added a comment -

        Thomas,
        Would it be possible to add a unit test, that includes unit tests to make sure all the application finish time/start time/diagnostics and other are set? We can do it in a separate jira as well.

        Show
        Mahadev konar added a comment - Thomas, Would it be possible to add a unit test, that includes unit tests to make sure all the application finish time/start time/diagnostics and other are set? We can do it in a separate jira as well.
        Hide
        Thomas Graves added a comment -

        Sorry, looks like I forgot to hit enter with my comment last night. I was actually planning on adding some and want to do a bit more validation on all the kill transitions. Posted the patch in case anyone wanted to take an initial look at it. Thanks.

        Show
        Thomas Graves added a comment - Sorry, looks like I forgot to hit enter with my comment last night. I was actually planning on adding some and want to do a bit more validation on all the kill transitions. Posted the patch in case anyone wanted to take an initial look at it. Thanks.
        Hide
        Thomas Graves added a comment -

        startTime was also not being set, fixed that. start time is actually more like submit time. Might be nice to add some finer grain times in there for atleast submit, launch. I also don't think each attempt is tracking its start/finish time so those would be nice enhancements.

        Show
        Thomas Graves added a comment - startTime was also not being set, fixed that. start time is actually more like submit time. Might be nice to add some finer grain times in there for atleast submit, launch. I also don't think each attempt is tracking its start/finish time so those would be nice enhancements.
        Hide
        Thomas Graves added a comment -

        patch with various small fixes and unit tests.

        Show
        Thomas Graves added a comment - patch with various small fixes and unit tests.
        Thomas Graves made changes -
        Attachment MAPREDUCE-2781-v2.patch [ 12489794 ]
        Thomas Graves made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.23.0 [ 12315570 ]
        Fix Version/s 0.23.0 [ 12315570 ]
        Thomas Graves made changes -
        Link This issue blocks MAPREDUCE-2649 [ MAPREDUCE-2649 ]
        Mahadev konar made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Mahadev konar made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Mahadev konar added a comment -

        +1 lgtm

        Show
        Mahadev konar added a comment - +1 lgtm
        Hide
        Mahadev konar added a comment -

        I just pushed this. Thanks Thomas!

        Show
        Mahadev konar added a comment - I just pushed this. Thanks Thomas!
        Mahadev konar made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Thomas Graves made changes -
        Link This issue blocks MAPREDUCE-2649 [ MAPREDUCE-2649 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Thomas Graves
            Reporter:
            Thomas Graves
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development