Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2701

MR-279: app/Job.java needs UGI for the user that launched it

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: mrv2
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ./mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/Job.java is missing some data that is needed by the Job History GUI. It needs the UGI for the user that launched it.

      1. MR-2701-v1.patch
        14 kB
        Robert Joseph Evans
      2. MR-2701-v2.patch
        14 kB
        Robert Joseph Evans
      3. MR-2701-v2.patch
        14 kB
        Robert Joseph Evans
      4. MR-2701-v3.patch
        14 kB
        Robert Joseph Evans
      5. MR-2701-v4.patch
        14 kB
        Robert Joseph Evans
      6. MR-2701-v5.patch
        18 kB
        Robert Joseph Evans
      7. MR-2701-trunk-v6.patch
        18 kB
        Robert Joseph Evans

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #779 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/779/)
          MAPREDUCE-2701. app/Job.java needs UGI for the user that launched it. (Robert Evans via mahadev)

          mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160392
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JobHistory.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/Job.java
          • /hadoop/common/trunk/hadoop-mapreduce/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedJob.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MockJobs.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRApp.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRuntimeEstimators.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/PartialJob.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryEvents.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #779 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/779/ ) MAPREDUCE-2701 . app/Job.java needs UGI for the user that launched it. (Robert Evans via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160392 Files : /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JobHistory.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/Job.java /hadoop/common/trunk/hadoop-mapreduce/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedJob.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MockJobs.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRApp.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRuntimeEstimators.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/PartialJob.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryEvents.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #763 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/763/)
          MAPREDUCE-2701. app/Job.java needs UGI for the user that launched it. (Robert Evans via mahadev)

          mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160392
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JobHistory.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/Job.java
          • /hadoop/common/trunk/hadoop-mapreduce/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedJob.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MockJobs.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRApp.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRuntimeEstimators.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/PartialJob.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryEvents.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #763 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/763/ ) MAPREDUCE-2701 . app/Job.java needs UGI for the user that launched it. (Robert Evans via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160392 Files : /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JobHistory.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/Job.java /hadoop/common/trunk/hadoop-mapreduce/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedJob.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MockJobs.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRApp.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRuntimeEstimators.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/PartialJob.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryEvents.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #764 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/764/)
          MAPREDUCE-2701. app/Job.java needs UGI for the user that launched it. (Robert Evans via mahadev)

          mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160392
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JobHistory.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/Job.java
          • /hadoop/common/trunk/hadoop-mapreduce/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedJob.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MockJobs.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRApp.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRuntimeEstimators.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/PartialJob.java
          • /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryEvents.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #764 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/764/ ) MAPREDUCE-2701 . app/Job.java needs UGI for the user that launched it. (Robert Evans via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160392 Files : /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JobHistory.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/Job.java /hadoop/common/trunk/hadoop-mapreduce/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedJob.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MockJobs.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRApp.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRuntimeEstimators.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/PartialJob.java /hadoop/common/trunk/hadoop-mapreduce/hadoop-mr-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryEvents.java
          Hide
          Mahadev konar added a comment -

          Ran tests and everything passed. I just pushed this to trunk. Thanks Bobby!

          Show
          Mahadev konar added a comment - Ran tests and everything passed. I just pushed this to trunk. Thanks Bobby!
          Hide
          Mahadev konar added a comment -

          Looks like arun is going to create a branch today. Ill run test and test-patch manually and commit.

          Show
          Mahadev konar added a comment - Looks like arun is going to create a branch today. Ill run test and test-patch manually and commit.
          Hide
          Robert Joseph Evans added a comment -

          I filed MAPREDUCE-2865 for the Job.java javadocs.

          Show
          Robert Joseph Evans added a comment - I filed MAPREDUCE-2865 for the Job.java javadocs.
          Hide
          Mahadev konar added a comment -

          +1, the patch looks good to me Robert. THat reminds me we need to add javadocs to some classes (like Job.java). Mind opening a ticket for it? Someone else or I can take it up.

          I am waiting for the hudson CI to be up to commit patches. Hopefully should be able to commit this by tomm.

          Show
          Mahadev konar added a comment - +1, the patch looks good to me Robert. THat reminds me we need to add javadocs to some classes (like Job.java). Mind opening a ticket for it? Someone else or I can take it up. I am waiting for the hudson CI to be up to commit patches. Hopefully should be able to commit this by tomm.
          Hide
          Robert Joseph Evans added a comment -

          Canceling patch to upload new patch rebased on MR-trunk

          Show
          Robert Joseph Evans added a comment - Canceling patch to upload new patch rebased on MR-trunk
          Hide
          Robert Joseph Evans added a comment -

          Added in tests to verify that user name is returned correctly by JobImpl for MRAppMaster and CompletedJob for the History Server.

          Show
          Robert Joseph Evans added a comment - Added in tests to verify that user name is returned correctly by JobImpl for MRAppMaster and CompletedJob for the History Server.
          Hide
          Robert Joseph Evans added a comment -

          Sorry I didn't respond sooner I have been out on vacation. I will update the patch with the requested tests ASAP.

          Show
          Robert Joseph Evans added a comment - Sorry I didn't respond sooner I have been out on vacation. I will update the patch with the requested tests ASAP.
          Hide
          Mahadev konar added a comment -

          bobby,
          would you be able to add a test case to verify Job.getUser() is returning the correct user? Also, maybe extend the jobhistory tests to make sure the user is correct in the history api's?

          Show
          Mahadev konar added a comment - bobby, would you be able to add a test case to verify Job.getUser() is returning the correct user? Also, maybe extend the jobhistory tests to make sure the user is correct in the history api's?
          Hide
          Robert Joseph Evans added a comment -

          This patch is just for MR-279 branch not Trunk.

          Show
          Robert Joseph Evans added a comment - This patch is just for MR-279 branch not Trunk.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12487721/MR-2701-v4.patch
          against trunk revision 1150533.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/499//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487721/MR-2701-v4.patch against trunk revision 1150533. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/499//console This message is automatically generated.
          Hide
          Robert Joseph Evans added a comment -

          This new patch removes UGI from JobImpl all together.

          Show
          Robert Joseph Evans added a comment - This new patch removes UGI from JobImpl all together.
          Hide
          Robert Joseph Evans added a comment -

          That is simple to fix. Will update the patch shortly once I finish rebuilding/testing.

          Show
          Robert Joseph Evans added a comment - That is simple to fix. Will update the patch shortly once I finish rebuilding/testing.
          Hide
          Mahadev konar added a comment -

          Bobby,
          THe patch looks good except for a minor nit. I think we should not even bother storing UGI in the JobImpl.java and just store the user information as string. What do you think?

          Show
          Mahadev konar added a comment - Bobby, THe patch looks good except for a minor nit. I think we should not even bother storing UGI in the JobImpl.java and just store the user information as string. What do you think?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12487711/MR-2701-v3.patch
          against trunk revision 1150533.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/498//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487711/MR-2701-v3.patch against trunk revision 1150533. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/498//console This message is automatically generated.
          Hide
          Robert Joseph Evans added a comment -

          Updated the patch to use the new API suggested by Mahadev.

          Show
          Robert Joseph Evans added a comment - Updated the patch to use the new API suggested by Mahadev.
          Hide
          Robert Joseph Evans added a comment -

          I thought about that, and yes I think it would be a lot better to just have the user name. I will update the code a submit a new patch. Thanks.

          Show
          Robert Joseph Evans added a comment - I thought about that, and yes I think it would be a lot better to just have the user name. I will update the code a submit a new patch. Thanks.
          Hide
          Mahadev konar added a comment -

          Robert,
          Wont it be simpler to just store the username in Job? Rather than the whole UGI? What do you think? Storing the whole UGI is probably not required and also doesnt sound like a good API.

          Just something like:

          
          String getUserName();
          
          
          Show
          Mahadev konar added a comment - Robert, Wont it be simpler to just store the username in Job? Rather than the whole UGI? What do you think? Storing the whole UGI is probably not required and also doesnt sound like a good API. Just something like: String getUserName();
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12487303/MR-2701-v2.patch
          against trunk revision 1149004.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/487//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487303/MR-2701-v2.patch against trunk revision 1149004. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/487//console This message is automatically generated.
          Hide
          Robert Joseph Evans added a comment -

          Ahhh. Sorry about that I typed in the versions in the wrong order to git. I will attach an updated patch. What I did was add in UGI information to Job.

          Show
          Robert Joseph Evans added a comment - Ahhh. Sorry about that I typed in the versions in the wrong order to git. I will attach an updated patch. What I did was add in UGI information to Job.
          Hide
          Mahadev konar added a comment -

          robert,

          Looks like this patch is removing the UGI information from job? Am not sure I understand the jira completely.

          Show
          Mahadev konar added a comment - robert, Looks like this patch is removing the UGI information from job? Am not sure I understand the jira completely.
          Hide
          Robert Joseph Evans added a comment -

          I am requesting that someone please review this patch.

          Show
          Robert Joseph Evans added a comment - I am requesting that someone please review this patch.
          Hide
          Robert Joseph Evans added a comment -

          This patch is intended for the MR-279 branch not trunk.

          Show
          Robert Joseph Evans added a comment - This patch is intended for the MR-279 branch not trunk.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12486879/MR-2701-v1.patch
          against trunk revision 1146517.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/476//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486879/MR-2701-v1.patch against trunk revision 1146517. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/476//console This message is automatically generated.
          Hide
          Robert Joseph Evans added a comment -

          This patch adds in UGI information to Job for the user that launched the job. This is in preparation for the GUI to display this information.

          Show
          Robert Joseph Evans added a comment - This patch adds in UGI information to Job for the user that launched the job. This is in preparation for the GUI to display this information.

            People

            • Assignee:
              Robert Joseph Evans
              Reporter:
              Robert Joseph Evans
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development