Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2622

Remove the last remaining reference to "io.sort.mb"

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestLocalRunner still carries "io.sort.mb", which must be updated to "mapreduce.task.io.sort.mb" (MRJobConfig.IO_SORT_MB).

        Issue Links

          Activity

          Hide
          Harsh J added a comment -

          Patch that removes io.sort.mb refs and also removes a useless property "io.sort.record.pct" which does not seem in use anymore anywhere (across common or mapreduce).

          Show
          Harsh J added a comment - Patch that removes io.sort.mb refs and also removes a useless property "io.sort.record.pct" which does not seem in use anymore anywhere (across common or mapreduce).
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12483815/MAPREDUCE-2622.r1.diff
          against trunk revision 1139400.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.cli.TestMRCLI
          org.apache.hadoop.fs.TestFileSystem

          -1 contrib tests. The patch failed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/420//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/420//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/420//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483815/MAPREDUCE-2622.r1.diff against trunk revision 1139400. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestMRCLI org.apache.hadoop.fs.TestFileSystem -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/420//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/420//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/420//console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          +1

          Show
          Todd Lipcon added a comment - +1
          Hide
          Todd Lipcon added a comment -

          Committed to trunk. Thanks, Harsh!

          Show
          Todd Lipcon added a comment - Committed to trunk. Thanks, Harsh!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #755 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/755/)
          MAPREDUCE-2622. Remove the last remaining reference to the deprecated configuration "io.sort.mb". Contributed by Harsh J Chouraria.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150921
          Files :

          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/TestLocalRunner.java
          • /hadoop/common/trunk/mapreduce/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #755 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/755/ ) MAPREDUCE-2622 . Remove the last remaining reference to the deprecated configuration "io.sort.mb". Contributed by Harsh J Chouraria. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150921 Files : /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/TestLocalRunner.java /hadoop/common/trunk/mapreduce/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #749 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/749/)
          MAPREDUCE-2622. Remove the last remaining reference to the deprecated configuration "io.sort.mb". Contributed by Harsh J Chouraria.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150921
          Files :

          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/TestLocalRunner.java
          • /hadoop/common/trunk/mapreduce/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #749 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/749/ ) MAPREDUCE-2622 . Remove the last remaining reference to the deprecated configuration "io.sort.mb". Contributed by Harsh J Chouraria. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150921 Files : /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/TestLocalRunner.java /hadoop/common/trunk/mapreduce/CHANGES.txt

            People

            • Assignee:
              Harsh J
              Reporter:
              Harsh J
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development