Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2621

TestCapacityScheduler fails with "Queue "q1" does not exist"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.204.0
    • Fix Version/s: 0.20.204.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      0.20.1xx-Secondary

    • Hadoop Flags:
      Reviewed

      Description

      Error Message

      Queue "q1" does not exist

      Stacktrace

      java.io.IOException: Queue "q1" does not exist
      at org.apache.hadoop.mapred.JobInProgress.<init>(JobInProgress.java:354)
      at org.apache.hadoop.mapred.TestCapacityScheduler$FakeJobInProgress.<init>(TestCapacityScheduler.java:172)
      at org.apache.hadoop.mapred.TestCapacityScheduler.submitJob(TestCapacityScheduler.java:794)
      at org.apache.hadoop.mapred.TestCapacityScheduler.submitJob(TestCapacityScheduler.java:818)
      at org.apache.hadoop.mapred.TestCapacityScheduler.submitJobAndInit(TestCapacityScheduler.java:825)
      at org.apache.hadoop.mapred.TestCapacityScheduler.testMultiTaskAssignmentInMultipleQueues(TestCapacityScheduler.java:1109)

      When queue name is invalid, an exception is thrown now.

      1. MAPREDUCE-2621.patch
        3 kB
        Sherry Chen
      2. MAPREDUCE-2621_1.patch
        3 kB
        Sherry Chen

        Activity

        Hide
        Sherry Chen added a comment -

        QueueManager is added as a parameter of JobTracker constructor.

        This ensures the JobTracker to associate with the proper queue.

        Full tests are running to ensure there is no side effects.

        Show
        Sherry Chen added a comment - QueueManager is added as a parameter of JobTracker constructor. This ensures the JobTracker to associate with the proper queue. Full tests are running to ensure there is no side effects.
        Hide
        Sherry Chen added a comment -

        Testcase for TestCapacityScheduler all passed.

        Show
        Sherry Chen added a comment - Testcase for TestCapacityScheduler all passed.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12483876/MAPREDUCE-2621.patch
        against trunk revision 1139400.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/429//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483876/MAPREDUCE-2621.patch against trunk revision 1139400. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/429//console This message is automatically generated.
        Hide
        Sherry Chen added a comment -

        This patch is for the 20-security branch, so here are the results of the manual test-patch run:

        [exec]
        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 6 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
        [exec]

        Show
        Sherry Chen added a comment - This patch is for the 20-security branch, so here are the results of the manual test-patch run: [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec]
        Hide
        Jeffrey Naisbitt added a comment -

        Looks good to me, and I verified the tests pass for me. A minor comment: the new getJobTracker method (in UtilsForTests.java) duplicates almost all of the code in the original getJobTracker method. It would be more maintainable if we could consolidate the duplicated code so we don't have to make future changes in both places - not critical though.

        Show
        Jeffrey Naisbitt added a comment - Looks good to me, and I verified the tests pass for me. A minor comment: the new getJobTracker method (in UtilsForTests.java) duplicates almost all of the code in the original getJobTracker method. It would be more maintainable if we could consolidate the duplicated code so we don't have to make future changes in both places - not critical though.
        Hide
        Sherry Chen added a comment -

        Consolidated getJobTracker method.

        Show
        Sherry Chen added a comment - Consolidated getJobTracker method.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12485784/MAPREDUCE-2621_1.patch
        against trunk revision 1144403.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/451//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12485784/MAPREDUCE-2621_1.patch against trunk revision 1144403. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/451//console This message is automatically generated.
        Hide
        Jeffrey Naisbitt added a comment -

        +1
        Looks good to me.

        Show
        Jeffrey Naisbitt added a comment - +1 Looks good to me.
        Hide
        Mahadev konar added a comment -

        +1, the patch looks good. Any chance you could post the ant test results on the jira?

        Show
        Mahadev konar added a comment - +1, the patch looks good. Any chance you could post the ant test results on the jira?
        Hide
        Sherry Chen added a comment -

        the results of the manual test-patch run:

        [exec]
        [exec] BUILD SUCCESSFUL
        [exec] Total time: 6 minutes 1 second
        [exec]
        [exec]
        [exec]
        [exec]
        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 6 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
        [exec]
        [exec]
        [exec]
        [exec]
        [exec] ======================================================================
        [exec] ======================================================================
        [exec] Finished build.
        [exec] ======================================================================
        [exec] ======================================================================
        [exec]

        Show
        Sherry Chen added a comment - the results of the manual test-patch run: [exec] [exec] BUILD SUCCESSFUL [exec] Total time: 6 minutes 1 second [exec] [exec] [exec] [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== [exec]
        Hide
        Sherry Chen added a comment -

        ant test passed.

        Show
        Sherry Chen added a comment - ant test passed.
        Hide
        Mahadev konar added a comment -

        I just committed this. Thanks Sherry!

        Show
        Mahadev konar added a comment - I just committed this. Thanks Sherry!
        Hide
        Matt Foley added a comment -

        This was merged to 0.20-security-204:
        ------------------------------------------------------------------------
        r1150857 | ddas | 2011-07-25 19:28:14 +0000 (Mon, 25 Jul 2011) | 1 line

        Merge -r 1150527:1150528 from branch-0.20-security onto branch-0.20-security-204
        ------------------------------------------------------------------------

        The merged -r1150527:1150528 is really -c1150528, which is seen above to be the fix for this bug MAPREDUCE-2621 in the 0.20-security branch.

        Show
        Matt Foley added a comment - This was merged to 0.20-security-204: ------------------------------------------------------------------------ r1150857 | ddas | 2011-07-25 19:28:14 +0000 (Mon, 25 Jul 2011) | 1 line Merge -r 1150527:1150528 from branch-0.20-security onto branch-0.20-security-204 ------------------------------------------------------------------------ The merged -r1150527:1150528 is really -c1150528, which is seen above to be the fix for this bug MAPREDUCE-2621 in the 0.20-security branch.
        Hide
        Owen O'Malley added a comment -

        Hadoop 0.20.204.0 was just released.

        Show
        Owen O'Malley added a comment - Hadoop 0.20.204.0 was just released.

          People

          • Assignee:
            Sherry Chen
            Reporter:
            Sherry Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved:

              Development