Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      IsolationRunner is no longer maintained. See MAPREDUCE-2637 for its replacement.
      Show
      IsolationRunner is no longer maintained. See MAPREDUCE-2637 for its replacement.

      Description

      IsolationRunner it seems it has been broken for a while, it gives a NPE when trying to use it.

      In addition, it supports only Map tasks; to use it the user must ssh to the node where the task failed; and unless the job has been configured to keep local files, the job must be run again.

      Because of this, IMO, the current implementation of IsolationRunner is not of much use.

      Any objection to remove it from trunk and if people have the need for such functionality to open another JIRA to build this functionality supported by the JobTracker (ie via the UI console)?

      1. MAPREDUCE-2606.patch
        26 kB
        Alejandro Abdelnur

        Issue Links

          Activity

          Hide
          Alejandro Abdelnur added a comment -

          Removing IsolationRunner

          Show
          Alejandro Abdelnur added a comment - Removing IsolationRunner
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12483369/MAPREDUCE-2606.patch
          against trunk revision 1137017.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.cli.TestMRCLI
          org.apache.hadoop.fs.TestFileSystem

          -1 contrib tests. The patch failed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/409//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/409//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/409//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483369/MAPREDUCE-2606.patch against trunk revision 1137017. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestMRCLI org.apache.hadoop.fs.TestFileSystem -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/409//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/409//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/409//console This message is automatically generated.
          Hide
          Alejandro Abdelnur added a comment -

          I've reverted the patch in my devel environment, run those tests against the trunk and they still fail. Could it be that they are broken?

          Show
          Alejandro Abdelnur added a comment - I've reverted the patch in my devel environment, run those tests against the trunk and they still fail. Could it be that they are broken?
          Hide
          Eli Collins added a comment -

          Yea, looks like IsolationRunner has bit rot for a long time. Given no one uses it and we have MAPREDUCE-2637 for an MR2 replacement I think we can remove it.

          +1

          Show
          Eli Collins added a comment - Yea, looks like IsolationRunner has bit rot for a long time. Given no one uses it and we have MAPREDUCE-2637 for an MR2 replacement I think we can remove it. +1
          Hide
          Eli Collins added a comment -

          I've committed this. Thanks Alejandro.

          Show
          Eli Collins added a comment - I've committed this. Thanks Alejandro.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #739 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/739/)
          MAPREDUCE-2606. Remove IsolationRunner. Contributed by Alejandro Abdelnur

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1145413
          Files :

          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestIsolationRunner.java
          • /hadoop/common/trunk/mapreduce/CHANGES.txt
          • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/MapTask.java
          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestMapProgress.java
          • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/Task.java
          • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/IsolationRunner.java
          • /hadoop/common/trunk/mapreduce/src/docs/src/documentation/content/xdocs/mapred_tutorial.xml
          • /hadoop/common/trunk/mapreduce/src/docs/src/documentation/content/xdocs/site.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #739 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/739/ ) MAPREDUCE-2606 . Remove IsolationRunner. Contributed by Alejandro Abdelnur eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1145413 Files : /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestIsolationRunner.java /hadoop/common/trunk/mapreduce/CHANGES.txt /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/MapTask.java /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestMapProgress.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/Task.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/IsolationRunner.java /hadoop/common/trunk/mapreduce/src/docs/src/documentation/content/xdocs/mapred_tutorial.xml /hadoop/common/trunk/mapreduce/src/docs/src/documentation/content/xdocs/site.xml
          Hide
          Todd Lipcon added a comment -

          Please add a Release Note entry to this JIRA explaining that it was unmaintained, and pointing to the new JIRA filed for its replacement?

          Show
          Todd Lipcon added a comment - Please add a Release Note entry to this JIRA explaining that it was unmaintained, and pointing to the new JIRA filed for its replacement?
          Hide
          Eli Collins added a comment -

          Done.

          Show
          Eli Collins added a comment - Done.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #735 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/735/)
          MAPREDUCE-2606. Remove IsolationRunner. Contributed by Alejandro Abdelnur

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1145413
          Files :

          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestIsolationRunner.java
          • /hadoop/common/trunk/mapreduce/CHANGES.txt
          • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/MapTask.java
          • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestMapProgress.java
          • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/Task.java
          • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/IsolationRunner.java
          • /hadoop/common/trunk/mapreduce/src/docs/src/documentation/content/xdocs/mapred_tutorial.xml
          • /hadoop/common/trunk/mapreduce/src/docs/src/documentation/content/xdocs/site.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #735 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/735/ ) MAPREDUCE-2606 . Remove IsolationRunner. Contributed by Alejandro Abdelnur eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1145413 Files : /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestIsolationRunner.java /hadoop/common/trunk/mapreduce/CHANGES.txt /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/MapTask.java /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestMapProgress.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/Task.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/IsolationRunner.java /hadoop/common/trunk/mapreduce/src/docs/src/documentation/content/xdocs/mapred_tutorial.xml /hadoop/common/trunk/mapreduce/src/docs/src/documentation/content/xdocs/site.xml

            People

            • Assignee:
              Alejandro Abdelnur
              Reporter:
              Alejandro Abdelnur
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development