Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Spelling errors in log messages (MapTask) - e.g. search for "recieve" (should be "receive"). A decent IDE should detect these errors as well.

      1. MAPREDUCE-2581.patch
        1.0 kB
        Tim Sell
      2. MAPREDUCE-2581.3.patch
        6 kB
        Tim Sell
      3. MAPREDUCE-2581.2.patch
        6 kB
        Tim Sell

        Activity

        Hide
        Tim Sell added a comment -

        made a patch

        Show
        Tim Sell added a comment - made a patch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481940/MAPREDUCE-2581.patch
        against trunk revision 1133226.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestMRCLI
        org.apache.hadoop.fs.TestFileSystem
        org.apache.hadoop.mapred.TestNodeRefresh

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/371//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/371//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/371//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481940/MAPREDUCE-2581.patch against trunk revision 1133226. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestMRCLI org.apache.hadoop.fs.TestFileSystem org.apache.hadoop.mapred.TestNodeRefresh -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/371//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/371//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/371//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Thanks Tim! Minding fixing all of them in this jira? Running find src -name *\.java|xargs grep recieve turns up 6 or so more places.

        Show
        Eli Collins added a comment - Thanks Tim! Minding fixing all of them in this jira? Running find src -name *\.java|xargs grep recieve turns up 6 or so more places.
        Hide
        Tim Sell added a comment -

        no problem, added a patch to replaced recieve with receive in all of:

        find src -name *\.java|xargs grep -i recieve

        Show
        Tim Sell added a comment - no problem, added a patch to replaced recieve with receive in all of: find src -name *\.java|xargs grep -i recieve
        Hide
        Eli Collins added a comment -

        +1 to your updated patch, pending Hudson.

        Show
        Eli Collins added a comment - +1 to your updated patch, pending Hudson.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481994/MAPREDUCE-2581.3.patch
        against trunk revision 1134121.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestMRCLI
        org.apache.hadoop.fs.TestFileSystem

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/372//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/372//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/372//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481994/MAPREDUCE-2581.3.patch against trunk revision 1134121. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestMRCLI org.apache.hadoop.fs.TestFileSystem -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/372//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/372//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/372//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Test failures are unrelated.

        Show
        Eli Collins added a comment - Test failures are unrelated.
        Hide
        Eli Collins added a comment -

        I've committed this to trunk. Thanks Tim!

        Show
        Eli Collins added a comment - I've committed this to trunk. Thanks Tim!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #721 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/721/)
        MAPREDUCE-2581. Spelling errors in log messages. Contributed by Tim Sell

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134180
        Files :

        • /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/TaskInProgress.java
        • /hadoop/mapreduce/trunk/CHANGES.txt
        • /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/TaskTracker.java
        • /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/InterTrackerProtocol.java
        • /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/MapTask.java
        • /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/SortValidator.java
        • /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/TestKillSubProcesses.java
        • /hadoop/mapreduce/trunk/src/contrib/mumak/src/java/org/apache/hadoop/mapred/SimulatorTaskTracker.java
        • /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/fs/slive/DataVerifier.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #721 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/721/ ) MAPREDUCE-2581 . Spelling errors in log messages. Contributed by Tim Sell eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134180 Files : /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/TaskInProgress.java /hadoop/mapreduce/trunk/CHANGES.txt /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/TaskTracker.java /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/InterTrackerProtocol.java /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/MapTask.java /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/SortValidator.java /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/TestKillSubProcesses.java /hadoop/mapreduce/trunk/src/contrib/mumak/src/java/org/apache/hadoop/mapred/SimulatorTaskTracker.java /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/fs/slive/DataVerifier.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #722 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/722/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #722 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/722/ )

          People

          • Assignee:
            Tim Sell
            Reporter:
            Dave Syer
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development