Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2571

CombineFileInputFormat.getSplits throws a java.lang.ArrayStoreException

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The getSplits methods of
      org.apache.hadoop.mapred.lib.CombineFileInputFormat
      not work.

      ...mapred.lib.CombineFileInputFormat(0.20-style) is a proxy for ...mapreduce.lib.input.CombineFileInputFormat(0.21-style)

      The 0.21-style getSplits returns ArrayList<...mapreduce.lib.input.CombineFileSplit>
      and the 0.20-style delegation calls toArray(...mapred.InputSplit[])

      The ...mapreduce.lib.input.CombineFileSplit is based on ...mapreduce.InputSplit
      and ...mapred.InputSplit is a interface, not a super-class of ...mapreduce.InputSplit

      1. MAPREDUCE-2571.patch
        5 kB
        Bochun Bai
      2. MAPREDUCE-2571.patch
        5 kB
        Bochun Bai
      3. MAPREDUCE-2571.patch
        7 kB
        Bochun Bai

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #722 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/722/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #722 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/722/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-22-branch #59 (See https://builds.apache.org/job/Hadoop-Mapreduce-22-branch/59/)
        MAPREDUCE-2571. CombineFileInputFormat.getSplits throws a java.lang.ArrayStoreException. Contributed by Bochun Bai.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1133176
        Files :

        • /hadoop/mapreduce/branches/branch-0.22/src/test/mapred/org/apache/hadoop/mapred/TestCombineFileInputFormat.java
        • /hadoop/mapreduce/branches/branch-0.22/CHANGES.txt
        • /hadoop/mapreduce/branches/branch-0.22/src/java/org/apache/hadoop/mapred/lib/CombineFileInputFormat.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-22-branch #59 (See https://builds.apache.org/job/Hadoop-Mapreduce-22-branch/59/ ) MAPREDUCE-2571 . CombineFileInputFormat.getSplits throws a java.lang.ArrayStoreException. Contributed by Bochun Bai. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1133176 Files : /hadoop/mapreduce/branches/branch-0.22/src/test/mapred/org/apache/hadoop/mapred/TestCombineFileInputFormat.java /hadoop/mapreduce/branches/branch-0.22/CHANGES.txt /hadoop/mapreduce/branches/branch-0.22/src/java/org/apache/hadoop/mapred/lib/CombineFileInputFormat.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #718 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/718/)
        MAPREDUCE-2571. CombineFileInputFormat.getSplits throws a java.lang.ArrayStoreException. Contributed by Bochun Bai.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1133175
        Files :

        • /hadoop/mapreduce/trunk/CHANGES.txt
        • /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/lib/CombineFileInputFormat.java
        • /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/TestCombineFileInputFormat.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #718 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/718/ ) MAPREDUCE-2571 . CombineFileInputFormat.getSplits throws a java.lang.ArrayStoreException. Contributed by Bochun Bai. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1133175 Files : /hadoop/mapreduce/trunk/CHANGES.txt /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/lib/CombineFileInputFormat.java /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/TestCombineFileInputFormat.java
        Hide
        Todd Lipcon added a comment -

        Committed to 22 and trunk, thanks Bochun!

        Show
        Todd Lipcon added a comment - Committed to 22 and trunk, thanks Bochun!
        Hide
        Todd Lipcon added a comment -

        I should note: the new findbugs warning seems like it must have come from a different patch - nothing related to CombineFileInputFormat shows up in the findbugs results. Same with the failing tests.

        Show
        Todd Lipcon added a comment - I should note: the new findbugs warning seems like it must have come from a different patch - nothing related to CombineFileInputFormat shows up in the findbugs results. Same with the failing tests.
        Hide
        Todd Lipcon added a comment -

        +1

        Show
        Todd Lipcon added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481729/MAPREDUCE-2571.patch
        against trunk revision 1132807.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestMRCLI
        org.apache.hadoop.fs.TestFileSystem
        org.apache.hadoop.mapred.TestRecoveryManager

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/358//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/358//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/358//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481729/MAPREDUCE-2571.patch against trunk revision 1132807. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestMRCLI org.apache.hadoop.fs.TestFileSystem org.apache.hadoop.mapred.TestRecoveryManager +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/358//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/358//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/358//console This message is automatically generated.
        Hide
        Bochun Bai added a comment -

        Fix previous patch which contains syntax error.

        Show
        Bochun Bai added a comment - Fix previous patch which contains syntax error.
        Hide
        Bochun Bai added a comment -

        囧rz,I should run test-patch myself before uploading.

        Show
        Bochun Bai added a comment - 囧rz,I should run test-patch myself before uploading.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481721/MAPREDUCE-2571.patch
        against trunk revision 1132807.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        -1 contrib tests. The patch failed contrib unit tests.

        -1 system test framework. The patch failed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/357//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/357//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481721/MAPREDUCE-2571.patch against trunk revision 1132807. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/357//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/357//console This message is automatically generated.
        Hide
        Bochun Bai added a comment -

        Yes, it is not related.
        A new patch is uploading.

        Show
        Bochun Bai added a comment - Yes, it is not related. A new patch is uploading.
        Hide
        Todd Lipcon added a comment -

        Patch looks pretty good. I'm not sure I follow why the main() and unquote() methods are in the test case, though - they seem unrelated and unused by the actual unit test, right?

        Show
        Todd Lipcon added a comment - Patch looks pretty good. I'm not sure I follow why the main() and unquote() methods are in the test case, though - they seem unrelated and unused by the actual unit test, right?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481653/MAPREDUCE-2571.patch
        against trunk revision 1132807.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestMRCLI
        org.apache.hadoop.fs.TestFileSystem

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/355//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/355//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/355//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481653/MAPREDUCE-2571.patch against trunk revision 1132807. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestMRCLI org.apache.hadoop.fs.TestFileSystem +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/355//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/355//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/355//console This message is automatically generated.
        Hide
        Bochun Bai added a comment -

        The patch uses a loop instead of toArray in getSplits.

        Show
        Bochun Bai added a comment - The patch uses a loop instead of toArray in getSplits.

          People

          • Assignee:
            Bochun Bai
            Reporter:
            Bochun Bai
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development