Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2549

Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java

    Details

    1. MAPREDUCE-2549-1.patch
      4 kB
      Devaraj K
    2. MAPREDUCE-2549-0[1].20.205.patch
      4 kB
      Devaraj K
    3. MAPREDUCE-2549.patch
      4 kB
      Devaraj K

      Activity

      Hide
      Austin wei added a comment -

      Hi,I need help, I've got a "error:failure to login " when using my eclipse 3.7.1 to connect to hadoop 0.20.205.0,after install the plugin from 0.20.205.0
      I'found some log information like this file

      eclipseworkspace\.metadata\.log

      !ENTRY org.eclipse.core.jobs 4 2 2011-12-07 17:43:12.831
      !MESSAGE An internal error occurred during: "Connecting to DFS hadoop".
      !STACK 0
      java.lang.NoClassDefFoundError: org/apache/commons/configuration/Configuration
      at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.<init>(DefaultMetricsSystem.java:37)
      at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.<clinit>(DefaultMetricsSystem.java:34)
      at org.apache.hadoop.security.UgiInstrumentation.create(UgiInstrumentation.java:51)
      at org.apache.hadoop.security.UserGroupInformation.initialize(UserGroupInformation.java:196)
      at org.apache.hadoop.security.UserGroupInformation.ensureInitialized(UserGroupInformation.java:159)
      at org.apache.hadoop.security.UserGroupInformation.isSecurityEnabled(UserGroupInformation.java:216)
      at org.apache.hadoop.security.KerberosName.<clinit>(KerberosName.java:83)
      at org.apache.hadoop.security.UserGroupInformation.initialize(UserGroupInformation.java:189)
      at org.apache.hadoop.security.UserGroupInformation.ensureInitialized(UserGroupInformation.java:159)
      at org.apache.hadoop.security.UserGroupInformation.isSecurityEnabled(UserGroupInformation.java:216)
      at org.apache.hadoop.security.UserGroupInformation.getLoginUser(UserGroupInformation.java:409)
      at org.apache.hadoop.security.UserGroupInformation.getCurrentUser(UserGroupInformation.java:395)
      at org.apache.hadoop.fs.FileSystem$Cache$Key.<init>(FileSystem.java:1436)
      at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:1337)
      at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:244)
      at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:122)
      at org.apache.hadoop.eclipse.server.HadoopServer.getDFS(HadoopServer.java:469)
      at org.apache.hadoop.eclipse.dfs.DFSPath.getDFS(DFSPath.java:146)
      at org.apache.hadoop.eclipse.dfs.DFSFolder.loadDFSFolderChildren(DFSFolder.java:61)
      at org.apache.hadoop.eclipse.dfs.DFSFolder$1.run(DFSFolder.java:178)
      at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
      Caused by: java.lang.ClassNotFoundException: org.apache.commons.configuration.Configuration
      at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:513)
      at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:429)
      at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:417)
      at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.loadClass(DefaultClassLoader.java:107)
      at java.lang.ClassLoader.loadClass(Unknown Source)
      ... 21 more

      Show
      Austin wei added a comment - Hi,I need help, I've got a "error:failure to login " when using my eclipse 3.7.1 to connect to hadoop 0.20.205.0,after install the plugin from 0.20.205.0 I'found some log information like this file eclipseworkspace\.metadata\.log !ENTRY org.eclipse.core.jobs 4 2 2011-12-07 17:43:12.831 !MESSAGE An internal error occurred during: "Connecting to DFS hadoop". !STACK 0 java.lang.NoClassDefFoundError: org/apache/commons/configuration/Configuration at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.<init>(DefaultMetricsSystem.java:37) at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.<clinit>(DefaultMetricsSystem.java:34) at org.apache.hadoop.security.UgiInstrumentation.create(UgiInstrumentation.java:51) at org.apache.hadoop.security.UserGroupInformation.initialize(UserGroupInformation.java:196) at org.apache.hadoop.security.UserGroupInformation.ensureInitialized(UserGroupInformation.java:159) at org.apache.hadoop.security.UserGroupInformation.isSecurityEnabled(UserGroupInformation.java:216) at org.apache.hadoop.security.KerberosName.<clinit>(KerberosName.java:83) at org.apache.hadoop.security.UserGroupInformation.initialize(UserGroupInformation.java:189) at org.apache.hadoop.security.UserGroupInformation.ensureInitialized(UserGroupInformation.java:159) at org.apache.hadoop.security.UserGroupInformation.isSecurityEnabled(UserGroupInformation.java:216) at org.apache.hadoop.security.UserGroupInformation.getLoginUser(UserGroupInformation.java:409) at org.apache.hadoop.security.UserGroupInformation.getCurrentUser(UserGroupInformation.java:395) at org.apache.hadoop.fs.FileSystem$Cache$Key.<init>(FileSystem.java:1436) at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:1337) at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:244) at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:122) at org.apache.hadoop.eclipse.server.HadoopServer.getDFS(HadoopServer.java:469) at org.apache.hadoop.eclipse.dfs.DFSPath.getDFS(DFSPath.java:146) at org.apache.hadoop.eclipse.dfs.DFSFolder.loadDFSFolderChildren(DFSFolder.java:61) at org.apache.hadoop.eclipse.dfs.DFSFolder$1.run(DFSFolder.java:178) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) Caused by: java.lang.ClassNotFoundException: org.apache.commons.configuration.Configuration at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:513) at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:429) at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:417) at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.loadClass(DefaultClassLoader.java:107) at java.lang.ClassLoader.loadClass(Unknown Source) ... 21 more
      Hide
      Matt Foley added a comment -

      Closed upon release of 0.20.205.0

      Show
      Matt Foley added a comment - Closed upon release of 0.20.205.0
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk #831 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/831/)
      Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549.

      acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288
      Files :

      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #831 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/831/ ) Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288 Files : /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-0.23-Build #2 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/2/)
      Merge -r 1170287:1170288 from trunk to branch-0.23 to fix MAPREDUCE-2549.

      acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170289
      Files :

      • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java
      • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java
      • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #2 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/2/ ) Merge -r 1170287:1170288 from trunk to branch-0.23 to fix MAPREDUCE-2549 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170289 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk-Commit #895 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/895/)
      Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549.

      acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288
      Files :

      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #895 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/895/ ) Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288 Files : /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk-Commit #960 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/960/)
      Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549.

      acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288
      Files :

      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #960 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/960/ ) Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288 Files : /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk #796 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/796/)
      Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549.

      acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288
      Files :

      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #796 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/796/ ) Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288 Files : /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Common-trunk-Commit #883 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/883/)
      Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549.

      acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288
      Files :

      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
      Show
      Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #883 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/883/ ) Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549 . acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288 Files : /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
      Hide
      Arun C Murthy added a comment -

      I just committed this. Thanks Devaraj!

      Show
      Arun C Murthy added a comment - I just committed this. Thanks Devaraj!
      Hide
      Devaraj K added a comment -

      I ran "ant test-patch" on 0.20.205. Please find the local result.

           [exec] -1 overall.  
           [exec] 
           [exec]     +1 @author.  The patch does not contain any @author tags.
           [exec] 
           [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
           [exec]                         Please justify why no tests are needed for this patch.
           [exec] 
           [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
           [exec] 
           [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
           [exec] 
           [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
           [exec] 
      

      Tests are not required because this is for the eclipse plugin which doesn't have unit tests. Verified it manually.

      Show
      Devaraj K added a comment - I ran "ant test-patch" on 0.20.205. Please find the local result. [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] Tests are not required because this is for the eclipse plugin which doesn't have unit tests. Verified it manually.
      Hide
      Arun C Murthy added a comment -

      Devaraj - did this pass 'ant test-patch' on 0.20.205?

      Show
      Arun C Murthy added a comment - Devaraj - did this pass 'ant test-patch' on 0.20.205?
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12493346/MAPREDUCE-2549-1.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 findbugs. The patch appears to introduce 14 new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:

      org.apache.hadoop.yarn.server.nodemanager.TestNMAuditLogger

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-hs.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-shuffle.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-jobclient.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-api.html
      Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493346/MAPREDUCE-2549-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 14 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.yarn.server.nodemanager.TestNMAuditLogger +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-hs.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-shuffle.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-jobclient.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-api.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//console This message is automatically generated.
      Hide
      Devaraj K added a comment -

      Patch is updated for trunk and also provided for 0.20.205 version.

      Show
      Devaraj K added a comment - Patch is updated for trunk and also provided for 0.20.205 version.
      Hide
      Devaraj K added a comment -

      Hi Todd, I prepared eclipse plug-in by applying this patch and tested it manually.

      Show
      Devaraj K added a comment - Hi Todd, I prepared eclipse plug-in by applying this patch and tested it manually.
      Hide
      Todd Lipcon added a comment -

      Since this is part of the eclipse plugin which doesn't have unit tests, it's OK not to have them.

      But: have you built and used the eclipse plugin with this patch applied? ie manually tested?

      Show
      Todd Lipcon added a comment - Since this is part of the eclipse plugin which doesn't have unit tests, it's OK not to have them. But: have you built and used the eclipse plugin with this patch applied? ie manually tested?
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12481347/MAPREDUCE-2549.patch
      against trunk revision 1130994.

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these core unit tests:
      org.apache.hadoop.cli.TestMRCLI

      +1 contrib tests. The patch passed contrib unit tests.

      +1 system test framework. The patch passed system test framework compile.

      Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/342//testReport/
      Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/342//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/342//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481347/MAPREDUCE-2549.patch against trunk revision 1130994. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestMRCLI +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/342//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/342//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/342//console This message is automatically generated.
      Hide
      Devaraj K added a comment -

      1. If an exception throws while writing, fos will not be closed.

      HadoopServer.java
        public void storeSettingsToFile(File file) throws IOException {
          FileOutputStream fos = new FileOutputStream(file);
          this.conf.writeXml(fos);
          fos.close();
        }
      

      2. If an exception throws while writing, fos will not be closed.

      RunOnHadoopWizard.java
      try {
            // File confFile = File.createTempFile("core-site-", ".xml",
            // confDir);
            File confFile = new File(confDir, "core-site.xml");
            FileOutputStream fos = new FileOutputStream(confFile);
            conf.writeXml(fos);
            fos.close();
      
          } catch (IOException ioe) {
            ioe.printStackTrace();
            return false;
          }
      
      

      3. If an exception throws while reading, reader will not be closed.

      Environment.java
       while (true) {
            String line = in.readLine();
            if (line == null) break;
            int p = line.indexOf("=");
            if (p != -1) {
              String name = line.substring(0, p);
              String value = line.substring(p + 1);
              setProperty(name, value);
            }
          }
          in.close();
      
      
      Show
      Devaraj K added a comment - 1. If an exception throws while writing, fos will not be closed. HadoopServer.java public void storeSettingsToFile(File file) throws IOException { FileOutputStream fos = new FileOutputStream(file); this .conf.writeXml(fos); fos.close(); } 2. If an exception throws while writing, fos will not be closed. RunOnHadoopWizard.java try { // File confFile = File.createTempFile( "core-site-" , ".xml" , // confDir); File confFile = new File(confDir, "core-site.xml" ); FileOutputStream fos = new FileOutputStream(confFile); conf.writeXml(fos); fos.close(); } catch (IOException ioe) { ioe.printStackTrace(); return false ; } 3. If an exception throws while reading, reader will not be closed. Environment.java while ( true ) { String line = in.readLine(); if (line == null ) break ; int p = line.indexOf( "=" ); if (p != -1) { String name = line.substring(0, p); String value = line.substring(p + 1); setProperty(name, value); } } in.close();

        People

        • Assignee:
          Devaraj K
          Reporter:
          Devaraj K
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development