Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2536

TestMRCLI broke due to change in usage output

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      One of the tests broke because it checks the FsShell mv usage line that is emitted after an error. The usage was updated to from "-mv <src> <dst>" to "-mv <src> ... <dst>", so the "..." broke the test.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1h 21m 1 Daryn Sharp 26/May/11 21:19
        Patch Available Patch Available Resolved Resolved
        3h 33m 1 Tsz Wo Nicholas Sze 27/May/11 00:53
        Resolved Resolved Closed Closed
        172d 55m 1 Arun C Murthy 15/Nov/11 00:48
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #692 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/692/)
        Fix MAPREDUCE-2536 entry in CHANGES.txt.
        MAPREDUCE-2536. Update FsShell -mv command usage in TestMRCLI. Contributed by Daryn Sharp

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128125
        Files :

        • /hadoop/mapreduce/trunk/CHANGES.txt

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128124
        Files :

        • /hadoop/mapreduce/trunk/CHANGES.txt
        • /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/cli/testMRConf.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #692 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/692/ ) Fix MAPREDUCE-2536 entry in CHANGES.txt. MAPREDUCE-2536 . Update FsShell -mv command usage in TestMRCLI. Contributed by Daryn Sharp szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128125 Files : /hadoop/mapreduce/trunk/CHANGES.txt szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128124 Files : /hadoop/mapreduce/trunk/CHANGES.txt /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/cli/testMRConf.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #701 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/701/)
        Fix MAPREDUCE-2536 entry in CHANGES.txt.
        MAPREDUCE-2536. Update FsShell -mv command usage in TestMRCLI. Contributed by Daryn Sharp

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128125
        Files :

        • /hadoop/mapreduce/trunk/CHANGES.txt

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128124
        Files :

        • /hadoop/mapreduce/trunk/CHANGES.txt
        • /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/cli/testMRConf.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #701 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/701/ ) Fix MAPREDUCE-2536 entry in CHANGES.txt. MAPREDUCE-2536 . Update FsShell -mv command usage in TestMRCLI. Contributed by Daryn Sharp szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128125 Files : /hadoop/mapreduce/trunk/CHANGES.txt szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128124 Files : /hadoop/mapreduce/trunk/CHANGES.txt /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/cli/testMRConf.xml
        Tsz Wo Nicholas Sze made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.23.0 [ 12315570 ]
        Resolution Fixed [ 1 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Daryn!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Daryn!
        Tsz Wo Nicholas Sze made changes -
        Hadoop Flags [Reviewed]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Daryn Sharp added a comment -

        The patch changes text in only one xml file used an input for a test. The test that failed is completely unrelated. Also, something is wrong with findbugs because the changed xml file is not flagged, and the findbugs report is identical to earlier builds.

        Requesting review since this patch fixes the test it is intended to fix.

        Show
        Daryn Sharp added a comment - The patch changes text in only one xml file used an input for a test. The test that failed is completely unrelated. Also, something is wrong with findbugs because the changed xml file is not flagged, and the findbugs report is identical to earlier builds. Requesting review since this patch fixes the test it is intended to fix.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12480579/MAPREDUCE-2536.patch
        against trunk revision 1127444.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/310//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/310//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/310//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12480579/MAPREDUCE-2536.patch against trunk revision 1127444. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/310//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/310//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/310//console This message is automatically generated.
        Daryn Sharp made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Daryn Sharp made changes -
        Attachment MAPREDUCE-2536.patch [ 12480579 ]
        Hide
        Daryn Sharp added a comment -

        Add "..." to the expected usage for mv.

        Show
        Daryn Sharp added a comment - Add "..." to the expected usage for mv.
        Tsz Wo Nicholas Sze made changes -
        Assignee Tsz Wo (Nicholas), SZE [ szetszwo ] Daryn Sharp [ daryn ]
        Priority Major [ 3 ] Minor [ 4 ]
        Tsz Wo Nicholas Sze made changes -
        Field Original Value New Value
        Assignee Tsz Wo (Nicholas), SZE [ szetszwo ]
        Daryn Sharp created issue -

          People

          • Assignee:
            Daryn Sharp
            Reporter:
            Daryn Sharp
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development