Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. mr-2460.txt
      0.9 kB
      Todd Lipcon
    2. mr-2460.txt
      0.9 kB
      Todd Lipcon
    3. mr-2460.txt
      1 kB
      Todd Lipcon

      Activity

      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk-Commit #656 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/656/)

      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #656 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/656/ )
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk #669 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/669/)

      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #669 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/669/ )
      Hide
      Todd Lipcon added a comment -

      Committed to trunk, thanks for reviewing, Cos.

      Show
      Todd Lipcon added a comment - Committed to trunk, thanks for reviewing, Cos.
      Hide
      Konstantin Boudnik added a comment -

      +1 patch looks good.

      Show
      Konstantin Boudnik added a comment - +1 patch looks good.
      Hide
      Todd Lipcon added a comment -

      Realized there was a whitespace error in previous patch. This patch fixes it and also adds a comment to explain what's going on.

      Show
      Todd Lipcon added a comment - Realized there was a whitespace error in previous patch. This patch fixes it and also adds a comment to explain what's going on.
      Hide
      Todd Lipcon added a comment -

      -1 contrib tests. The patch failed contrib unit tests.

      These failures are all in the RAID contrib (unrelated)

      -1 system test framework. The patch failed system test framework compile.

      This is due to the recent federation merge.

      Show
      Todd Lipcon added a comment - -1 contrib tests. The patch failed contrib unit tests. These failures are all in the RAID contrib (unrelated) -1 system test framework. The patch failed system test framework compile. This is due to the recent federation merge.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12477817/mr-2460.txt
      against trunk revision 1097679.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed core unit tests.

      -1 contrib tests. The patch failed contrib unit tests.

      -1 system test framework. The patch failed system test framework compile.

      Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/200//testReport/
      Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/200//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/200//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12477817/mr-2460.txt against trunk revision 1097679. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/200//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/200//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/200//console This message is automatically generated.
      Hide
      Todd Lipcon added a comment -

      Oops, patch was from the wrong dir

      Show
      Todd Lipcon added a comment - Oops, patch was from the wrong dir
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12477720/mr-2460.txt
      against trunk revision 1097656.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      -1 patch. The patch command could not apply the patch.

      Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/197//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12477720/mr-2460.txt against trunk revision 1097656. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/197//console This message is automatically generated.
      Hide
      Todd Lipcon added a comment -

      The issue seems to be that, when the job is retired, TaskGraphServlet no longer has any output. So, we have a race where the job might get retired just before we fetch this servlet.

      This patch catches the assertion error, and, if it sees that the job was retired, swallows it.

      I looped this on a Hudson box for several minutes and it passed reliably after this fix.

      Show
      Todd Lipcon added a comment - The issue seems to be that, when the job is retired, TaskGraphServlet no longer has any output. So, we have a race where the job might get retired just before we fetch this servlet. This patch catches the assertion error, and, if it sees that the job was retired, swallows it. I looped this on a Hudson box for several minutes and it passed reliably after this fix.

        People

        • Assignee:
          Todd Lipcon
          Reporter:
          Todd Lipcon
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development