Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2449

Allow for command line arguments when performing "Run on Hadoop" action.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.2
    • Fix Version/s: 0.23.0
    • Component/s: contrib/eclipse-plugin
    • Labels:
    • Environment:

      Eclipse 3.6, Ubuntu 9.04

    • Hadoop Flags:
      Reviewed
    • Tags:
      run on hadoop, arguments

      Description

      It is currently not possible to specify command line arguments when creating a run configuration for "Run on Hadoop." This patch adds a text box to the RunOnHadoopWizard dialog for providing command line arguments. The arguments are then stored as part of the run configuration. Additionally (as a result), this patch prevents the creation of duplicate run configuration creation by seeing if the original configuration has been changed first.

      1. MAPREDUCE-2449.patch
        3 kB
        Jeff Zemerick
      2. MAPREDUCE-2449.txt
        3 kB
        Todd Lipcon

        Activity

        Hide
        Jeff Zemerick added a comment -

        Patch for 2449.

        Show
        Jeff Zemerick added a comment - Patch for 2449.
        Hide
        Todd Lipcon added a comment -

        Hi Jeff. Would you mind posting a patch relative to the MapReduce svn trunk/ directory? This patch seems to be relative to the eclipse dir.

        Show
        Todd Lipcon added a comment - Hi Jeff. Would you mind posting a patch relative to the MapReduce svn trunk/ directory? This patch seems to be relative to the eclipse dir.
        Hide
        Jeff Zemerick added a comment -

        Uploaded new patch from trunk. Sorry! Thanks.

        Show
        Jeff Zemerick added a comment - Uploaded new patch from trunk. Sorry! Thanks.
        Hide
        Todd Lipcon added a comment -

        The auto-generated catch block around argumentsText.setText seems suspect - is there really no better way to handle this exception? Should it be rethrown as an RTE if it's truly unexpected?

        Show
        Todd Lipcon added a comment - The auto-generated catch block around argumentsText.setText seems suspect - is there really no better way to handle this exception? Should it be rethrown as an RTE if it's truly unexpected?
        Hide
        Jeff Zemerick added a comment -

        The call to getAttribute can throw a CoreException if it can't retrieve the value we're looking for, or if that value is not the type we are expecting (a String in this case). Typically, the catch block would be used to set some default value, but I did not do that since the default value in this case is just an empty string (no parameters). I don't think it's necessary to throw an RTE. When the run configuration is executed it will overwrite the existing one, so if the value was invalid for some reason it will be overwritten.

        Show
        Jeff Zemerick added a comment - The call to getAttribute can throw a CoreException if it can't retrieve the value we're looking for, or if that value is not the type we are expecting (a String in this case). Typically, the catch block would be used to set some default value, but I did not do that since the default value in this case is just an empty string (no parameters). I don't think it's necessary to throw an RTE. When the run configuration is executed it will overwrite the existing one, so if the value was invalid for some reason it will be overwritten.
        Hide
        Todd Lipcon added a comment -

        Reuploading Jeff's patch relative to svn trunk root

        Show
        Todd Lipcon added a comment - Reuploading Jeff's patch relative to svn trunk root
        Hide
        Todd Lipcon added a comment -

        Jeff: we generally require unit tests, but it doesn't look like the eclipse plugin is really testable. If you can let us know that you've built and used this enhancement that should be good enough for this area of the code. Thanks!

        Show
        Todd Lipcon added a comment - Jeff: we generally require unit tests, but it doesn't look like the eclipse plugin is really testable. If you can let us know that you've built and used this enhancement that should be good enough for this area of the code. Thanks!
        Hide
        Jeff Zemerick added a comment -

        Todd, yes, I am using it. It makes running from Eclipse much easier for me. I'll keep the tests in mind for future patches. Thanks a lot.

        Show
        Jeff Zemerick added a comment - Todd, yes, I am using it. It makes running from Eclipse much easier for me. I'll keep the tests in mind for future patches. Thanks a lot.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12479411/MAPREDUCE-2449.txt
        against trunk revision 1103921.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/253//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/253//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/253//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479411/MAPREDUCE-2449.txt against trunk revision 1103921. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/253//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/253//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/253//console This message is automatically generated.
        Hide
        Jeff Zemerick added a comment -

        No tests were included because there are no tests for the Eclipse plugin. Additionally, this is GUI functionality which would be difficult to test. It has been tested through my near-daily use of the plugin.

        Show
        Jeff Zemerick added a comment - No tests were included because there are no tests for the Eclipse plugin. Additionally, this is GUI functionality which would be difficult to test. It has been tested through my near-daily use of the plugin.
        Hide
        Todd Lipcon added a comment -

        Committed to trunk. Thanks, Jeff!

        Show
        Todd Lipcon added a comment - Committed to trunk. Thanks, Jeff!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #684 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/684/)
        MAPREDUCE-2449. Allow for command line arguments when performing "Run on Hadoop" action in Eclipse plugin. Contributed by Jeff Zemerick.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124553
        Files :

        • /hadoop/mapreduce/trunk/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java
        • /hadoop/mapreduce/trunk/CHANGES.txt
        • /hadoop/mapreduce/trunk/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/launch/HadoopApplicationLaunchShortcut.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #684 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/684/ ) MAPREDUCE-2449 . Allow for command line arguments when performing "Run on Hadoop" action in Eclipse plugin. Contributed by Jeff Zemerick. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124553 Files : /hadoop/mapreduce/trunk/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java /hadoop/mapreduce/trunk/CHANGES.txt /hadoop/mapreduce/trunk/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/launch/HadoopApplicationLaunchShortcut.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #684 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/684/)
        MAPREDUCE-2449. Allow for command line arguments when performing "Run on Hadoop" action in Eclipse plugin. Contributed by Jeff Zemerick.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124553
        Files :

        • /hadoop/mapreduce/trunk/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java
        • /hadoop/mapreduce/trunk/CHANGES.txt
        • /hadoop/mapreduce/trunk/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/launch/HadoopApplicationLaunchShortcut.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #684 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/684/ ) MAPREDUCE-2449 . Allow for command line arguments when performing "Run on Hadoop" action in Eclipse plugin. Contributed by Jeff Zemerick. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124553 Files : /hadoop/mapreduce/trunk/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java /hadoop/mapreduce/trunk/CHANGES.txt /hadoop/mapreduce/trunk/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/launch/HadoopApplicationLaunchShortcut.java

          People

          • Assignee:
            Jeff Zemerick
            Reporter:
            Jeff Zemerick
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 72h
              72h
              Remaining:
              Remaining Estimate - 72h
              72h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development