Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.

      1. MAPREDUCE-2422.patch
        53 kB
        Tom White
      2. MAPREDUCE-2422.patch
        27 kB
        Tom White
      3. MAPREDUCE-2422.patch
        26 kB
        Tom White

        Activity

        Hide
        Tom White added a comment -

        Here's a patch to remove the dependency that DistributedCache has on TrackerDistributedCacheManager.

        • Removed (deprecated, @Private) internal methods that are no longer used. TaskDistributedCacheManager and TrackerDistributedCacheManager are already being used internally.
        • Moved implementation of checkURIs back to DistributedCache, since it is a client-side user method.
        Show
        Tom White added a comment - Here's a patch to remove the dependency that DistributedCache has on TrackerDistributedCacheManager. Removed (deprecated, @Private) internal methods that are no longer used. TaskDistributedCacheManager and TrackerDistributedCacheManager are already being used internally. Moved implementation of checkURIs back to DistributedCache, since it is a client-side user method.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12475663/MAPREDUCE-2422.patch
        against trunk revision 1089686.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/156//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/156//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/156//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12475663/MAPREDUCE-2422.patch against trunk revision 1089686. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/156//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/156//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/156//console This message is automatically generated.
        Hide
        Tom White added a comment -

        Minor update to remove unused imports.

        Show
        Tom White added a comment - Minor update to remove unused imports.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12475726/MAPREDUCE-2422.patch
        against trunk revision 1089686.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/157//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/157//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/157//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12475726/MAPREDUCE-2422.patch against trunk revision 1089686. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/157//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/157//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/157//console This message is automatically generated.
        Hide
        Tom White added a comment -

        New patch to add a (@Private) ClientDistributedCacheManager, which is used by the client-side job submission process.

        Show
        Tom White added a comment - New patch to add a (@Private) ClientDistributedCacheManager, which is used by the client-side job submission process.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12477441/MAPREDUCE-2422.patch
        against trunk revision 1096649.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/186//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/186//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/186//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12477441/MAPREDUCE-2422.patch against trunk revision 1096649. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/186//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/186//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/186//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        It looks like most of these deprecated methods that are being removed were only deprecated in 0.21. As I understand it, the community has decided that we can't remove these until after the next stable release (i.e 0.21 didn't count as a release as far as API removal goes). Do you think that, instead of removing these methods, we could keep them around as simple forwarding stubs?

        Show
        Todd Lipcon added a comment - It looks like most of these deprecated methods that are being removed were only deprecated in 0.21. As I understand it, the community has decided that we can't remove these until after the next stable release (i.e 0.21 didn't count as a release as far as API removal goes). Do you think that, instead of removing these methods, we could keep them around as simple forwarding stubs?
        Hide
        Tom White added a comment -

        These methods are all internal methods, not user facing ones. They are marked as such in the javadoc (and in retrospect we should have marked them as @Private). This change would be in the 0.23 release, which seems reasonable to me.

        Show
        Tom White added a comment - These methods are all internal methods, not user facing ones. They are marked as such in the javadoc (and in retrospect we should have marked them as @Private). This change would be in the 0.23 release, which seems reasonable to me.
        Hide
        Todd Lipcon added a comment -

        OK, I looked through this in some more detail and agree with your assessment. +1

        Show
        Todd Lipcon added a comment - OK, I looked through this in some more detail and agree with your assessment. +1
        Hide
        Tom White added a comment -

        I've just committed this.

        Show
        Tom White added a comment - I've just committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #659 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/659/)
        MAPREDUCE-2422. Removed unused internal methods from DistributedCache.

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #659 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/659/ ) MAPREDUCE-2422 . Removed unused internal methods from DistributedCache.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #675 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/675/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #675 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/675/ )

          People

          • Assignee:
            Tom White
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development