Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2381

JobTracker instrumentation not consistent about error handling

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In the current code, if the class specified by the JobTracker instrumentation config property is not there, the JobTracker fails to start with a ClassNotFound. If it's there, but it can't load for whatever reason, the JobTracker continues with the default. Having two different error-handling routes is a bit confusing; I propose to move one line so that it's consistent. (On the TaskTracker instrumentation side, if any of the multiple instrumentations aren't available, the default is used.)

      The attached patch merely moves a line inside of the try block that's already there.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #684 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/684/)
        MAPREDUCE-2381. JobTracker instrumentation not consistent about error handling. Contributed by Philip Zeyliger.

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124381
        Files :

        • /hadoop/mapreduce/trunk/CHANGES.txt
        • /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/JobTracker.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #684 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/684/ ) MAPREDUCE-2381 . JobTracker instrumentation not consistent about error handling. Contributed by Philip Zeyliger. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124381 Files : /hadoop/mapreduce/trunk/CHANGES.txt /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/JobTracker.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #682 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/682/)
        MAPREDUCE-2381. JobTracker instrumentation not consistent about error handling. Contributed by Philip Zeyliger.

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124381
        Files :

        • /hadoop/mapreduce/trunk/CHANGES.txt
        • /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/JobTracker.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #682 (See https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/682/ ) MAPREDUCE-2381 . JobTracker instrumentation not consistent about error handling. Contributed by Philip Zeyliger. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124381 Files : /hadoop/mapreduce/trunk/CHANGES.txt /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/JobTracker.java
        Hide
        Tom White added a comment -

        I've just committed this. Thanks, Philip!

        Show
        Tom White added a comment - I've just committed this. Thanks, Philip!
        Hide
        Tom White added a comment -

        +1

        Show
        Tom White added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12473531/MAPREDUCE-2381.patch.txt
        against trunk revision 1080831.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/138//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/138//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/138//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12473531/MAPREDUCE-2381.patch.txt against trunk revision 1080831. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/138//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/138//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/138//console This message is automatically generated.

          People

          • Assignee:
            Philip Zeyliger
            Reporter:
            Philip Zeyliger
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development