Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2377

task-controller fails to parse configuration if it doesn't end in \n

        Details

        • Target Version/s:
        • Hadoop Flags:
          Reviewed

          Description

          If the task-controller.cfg file doesn't end in a newline, it fails to parse properly.

          1. Text File
            mr-2377-20.txt
            1 kB
            Todd Lipcon
          2. Text File
            mr-2377-0.22.patch
            1 kB
            Konstantin Shvachko

            Issue Links

            is depended upon by

            Task - A task that needs to be done. HADOOP-8357 Restore security in Hadoop 0.22 branch

            • Major - Major loss of function.
            • Resolved
            is duplicated by

            Bug - A problem which impairs or prevents the functions of the product. HADOOP-7476 task-controller can drop last char from config file

            • Trivial - Cosmetic problem like misspelt words or misaligned text.
            • Resolved

              Activity

              Ascending order - Click to sort in descending order
              Todd Lipcon created issue -
              Hide
              Permalink
              Todd Lipcon added a comment -

              This is for the task-controller after MAPREDUCE-2178

              Show
              Todd Lipcon added a comment - This is for the task-controller after MAPREDUCE-2178
              Hide
              Permalink
              Todd Lipcon added a comment -

              Patch against secure 0.20 (waiting on MR-2178 for trunk)

              Show
              Todd Lipcon added a comment - Patch against secure 0.20 (waiting on MR-2178 for trunk)
              Todd Lipcon made changes -
              Field Original Value New Value
              Attachment mr-2377-20.txt [ 12473846 ]
              Hide
              Permalink
              Eli Collins added a comment -

              +1 lgtm

              Show
              Eli Collins added a comment - +1 lgtm
              Aaron T. Myers made changes -
              Link This issue is duplicated by HADOOP-7476 [ HADOOP-7476 ]
              Hide
              Permalink
              Eli Collins added a comment -

              I've committed to branch-20-security. Leaving open for 22.

              Show
              Eli Collins added a comment - I've committed to branch-20-security. Leaving open for 22.
              Eli Collins made changes -
              Hadoop Flags Reviewed [ 10343 ]
              Fix Version/s 0.20.206.0 [ 12317960 ]
              Fix Version/s 0.22.0 [ 12314184 ]
              Target Version/s 0.22.0 [ 12314184 ]
              Priority Critical [ 2 ] Major [ 3 ]
              Component/s task-controller [ 12313272 ]
              Hide
              Permalink
              Eli Collins added a comment -

              Forgot to mention, aside from the test I also tested a build from a tarball running a couple MR jobs using the LTC.

              Show
              Eli Collins added a comment - Forgot to mention, aside from the test I also tested a build from a tarball running a couple MR jobs using the LTC.
              Arun C Murthy made changes -
              Labels critical-0.22.0
              Benoy Antony made changes -
              Link This issue is depended upon by HADOOP-8357 [ HADOOP-8357 ]
              Hide
              Permalink
              Benoy Antony added a comment -

              Patch for 0.22

              Show
              Benoy Antony added a comment - Patch for 0.22
              Benoy Antony made changes -
              Attachment mr-2376-0.22.patch [ 12526272 ]
              Konstantin Shvachko made changes -
              Attachment mr-2376-0.22.patch [ 12526272 ]
              Hide
              Permalink
              Konstantin Shvachko added a comment -

              Attachments to MAPREDUCE-2377 and MAPREDUCE-2376 were intermixed. Attaching the right one.

              Show
              Konstantin Shvachko added a comment - Attachments to MAPREDUCE-2377 and MAPREDUCE-2376 were intermixed. Attaching the right one.
              Konstantin Shvachko made changes -
              Attachment mr-2377-0.22.patch [ 12530902 ]
              Hide
              Permalink
              Konstantin Shvachko added a comment -

              I just committed this to branch 0.22.1. Thank you Todd and Benoy.
              Will close it if not needed in other versions.

              Show
              Konstantin Shvachko added a comment - I just committed this to branch 0.22.1. Thank you Todd and Benoy. Will close it if not needed in other versions.
              Konstantin Shvachko made changes -
              Assignee Benoy Antony [ benoyantony ]
              Fix Version/s 0.22.1 [ 12319242 ]
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Mapreduce-22-branch #104 (See https://builds.apache.org/job/Hadoop-Mapreduce-22-branch/104/)
              MAPREDUCE-2377. task-controller fails to parse configuration if it doesn't end in \n. Contributed by Todd Lipcon and Benoy Antony. (Revision 1346251)

              Result = SUCCESS
              shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346251
              Files :

              • /hadoop/common/branches/branch-0.22/mapreduce/CHANGES.txt
              • /hadoop/common/branches/branch-0.22/mapreduce/src/c++/task-controller/impl/configuration.c
              • /hadoop/common/branches/branch-0.22/mapreduce/src/c++/task-controller/test/test-task-controller.c
              Show
              Hudson added a comment - Integrated in Hadoop-Mapreduce-22-branch #104 (See https://builds.apache.org/job/Hadoop-Mapreduce-22-branch/104/ ) MAPREDUCE-2377 . task-controller fails to parse configuration if it doesn't end in \n. Contributed by Todd Lipcon and Benoy Antony. (Revision 1346251) Result = SUCCESS shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346251 Files : /hadoop/common/branches/branch-0.22/mapreduce/CHANGES.txt /hadoop/common/branches/branch-0.22/mapreduce/src/c++/task-controller/impl/configuration.c /hadoop/common/branches/branch-0.22/mapreduce/src/c++/task-controller/test/test-task-controller.c
              Todd Lipcon made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Todd Lipcon added a comment -

              Verified this bug is not present in the MR2 container executor, so marked as resolved.

              Show
              Todd Lipcon added a comment - Verified this bug is not present in the MR2 container executor, so marked as resolved.
              Hide
              Permalink
              Matt Foley added a comment -

              Closed upon release of Hadoop-1.1.0.

              Show
              Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.
              Matt Foley made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Benoy Antony
                  Reporter:
                  Todd Lipcon
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development