Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2365

Add counters for FileInputFormat (BYTES_READ) and FileOutputFormat (BYTES_WRITTEN)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.203.0, 0.23.0
    • Component/s: None
    • Labels:
      None

      Description

      MAP_INPUT_BYTES and MAP_OUTPUT_BYTES will be computed using the difference between FileSystem
      counters before and after each next(K,V) and collect/write op.

      In case compression is being used, these counters will represent the compressed data sizes. The uncompressed size will
      not be available.

      This is not a direct back-port of 5710. (Counters will be computed in MapTask instead of in individual RecordReaders).

      0.20.100 ->
      New API -> MAP_INPUT_BYTES will be computed using this method
      Old API -> MAP_INPUT_BYTES will remain unchanged.

      0.23 ->
      New API -> MAP_INPUT_BYTES will be computed using this method
      Old API -> MAP_INPUT_BYTES likely to use this method

      1. MR2365.patch
        51 kB
        Siddharth Seth

        Activity

        Owen O'Malley created issue -
        Owen O'Malley made changes -
        Field Original Value New Value
        Assignee Siddharth Seth [ sseth ]
        Hide
        Siddharth Seth added a comment -

        Patch forward ported to trunk

        Show
        Siddharth Seth added a comment - Patch forward ported to trunk
        Siddharth Seth made changes -
        Attachment MR2365.patch [ 12486278 ]
        Siddharth Seth made changes -
        Fix Version/s 0.20.203.0 [ 12316151 ]
        Fix Version/s 0.23.0 [ 12315570 ]
        Siddharth Seth made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12486278/MR2365.patch
        against trunk revision 1145889.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestMRCLI
        org.apache.hadoop.fs.TestFileSystem

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/463//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/463//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/463//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486278/MR2365.patch against trunk revision 1145889. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestMRCLI org.apache.hadoop.fs.TestFileSystem -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/463//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/463//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/463//console This message is automatically generated.
        Hide
        Siddharth Seth added a comment -
        Show
        Siddharth Seth added a comment - The test failures are not related. Findbugs appears to be related to MR-2680 ( https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/462//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html ).
        Hide
        Arun C Murthy added a comment -

        I just committed this. Thanks Sid!

        Show
        Arun C Murthy added a comment - I just committed this. Thanks Sid!
        Arun C Murthy made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #745 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/745/)
        MAPREDUCE-2365. Add counters to track bytes (read,written) via File(Input,Output)Format. Contributed by Siddharth Seth.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146515
        Files :

        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/ReduceTask.java
        • /hadoop/common/trunk/mapreduce/CHANGES.txt
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/MapTask.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/Counters.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/Task.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/LineRecordReader.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/output/FileOutputFormat.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/TaskCounter.java
        • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestJobCounters.java
        • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/TestMapReduceLocal.java
        • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestMiniMRDFSSort.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/TaskCounter.properties
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/SequenceFileRecordReader.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #745 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/745/ ) MAPREDUCE-2365 . Add counters to track bytes (read,written) via File(Input,Output)Format. Contributed by Siddharth Seth. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146515 Files : /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/ReduceTask.java /hadoop/common/trunk/mapreduce/CHANGES.txt /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/MapTask.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/Counters.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/Task.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/LineRecordReader.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/output/FileOutputFormat.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/TaskCounter.java /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestJobCounters.java /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/TestMapReduceLocal.java /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestMiniMRDFSSort.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/TaskCounter.properties /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/SequenceFileRecordReader.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #746 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/746/)
        MAPREDUCE-2365. Adding newer files.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146517
        Files :

        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormatCounter.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormatCounter.properties
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/output/FileOutputFormatCounter.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/output/FileOutputFormatCounter.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #746 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/746/ ) MAPREDUCE-2365 . Adding newer files. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146517 Files : /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormatCounter.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormatCounter.properties /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/output/FileOutputFormatCounter.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/output/FileOutputFormatCounter.properties
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #737 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/737/)
        MAPREDUCE-2365. Adding newer files.
        MAPREDUCE-2365. Add counters to track bytes (read,written) via File(Input,Output)Format. Contributed by Siddharth Seth.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146517
        Files :

        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormatCounter.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormatCounter.properties
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/output/FileOutputFormatCounter.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/output/FileOutputFormatCounter.properties

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146515
        Files :

        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/ReduceTask.java
        • /hadoop/common/trunk/mapreduce/CHANGES.txt
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/MapTask.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/Counters.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/Task.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/LineRecordReader.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/output/FileOutputFormat.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/TaskCounter.java
        • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestJobCounters.java
        • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/TestMapReduceLocal.java
        • /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestMiniMRDFSSort.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/TaskCounter.properties
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java
        • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/SequenceFileRecordReader.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #737 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/737/ ) MAPREDUCE-2365 . Adding newer files. MAPREDUCE-2365 . Add counters to track bytes (read,written) via File(Input,Output)Format. Contributed by Siddharth Seth. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146517 Files : /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormatCounter.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormatCounter.properties /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/output/FileOutputFormatCounter.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/output/FileOutputFormatCounter.properties acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146515 Files : /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/ReduceTask.java /hadoop/common/trunk/mapreduce/CHANGES.txt /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/MapTask.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/Counters.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/Task.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/LineRecordReader.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/output/FileOutputFormat.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/TaskCounter.java /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestJobCounters.java /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapreduce/TestMapReduceLocal.java /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestMiniMRDFSSort.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/TaskCounter.properties /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/lib/input/SequenceFileRecordReader.java
        Hide
        Owen O'Malley added a comment -

        Closing for 0.20.203.0

        Show
        Owen O'Malley added a comment - Closing for 0.20.203.0
        Owen O'Malley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Siddharth Seth
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development