Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2314

configure files that are generated as part of the released tarball need to have executable bit set

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the configure files that are packaged in a tarball are rw-rw-r-

      1. MAPREDUCE-2314.patch
        2 kB
        Roman Shaposhnik

        Activity

        Hide
        Konstantin Boudnik added a comment -

        +1 patch looks good.
        The only question (which you might not to know the answer for) is why chmod is force to be non-parallel.

        Show
        Konstantin Boudnik added a comment - +1 patch looks good. The only question (which you might not to know the answer for) is why chmod is force to be non-parallel.
        Hide
        Roman Shaposhnik added a comment -

        $ ant veryclean test-patch -Dpatch.file=/home/rvs/MAPREDUCE-2314.patch -Dscratch.dir=/tmp/mapred/scratch -Dfindbugs.home=/home/rvs/findbugs-1.3.9 -Dforrest.home=/home/rvs/src/apache-forrest-0.8
        .....

        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no new tests are needed for this patch.
        [exec] Also please list what manual steps were performed to verify this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]
        [exec] +1 system test framework. The patch passed system test framework compile.

        And given that it is a build change " -1 tests included" can be ignored

        Show
        Roman Shaposhnik added a comment - $ ant veryclean test-patch -Dpatch.file=/home/rvs/ MAPREDUCE-2314 .patch -Dscratch.dir=/tmp/mapred/scratch -Dfindbugs.home=/home/rvs/findbugs-1.3.9 -Dforrest.home=/home/rvs/src/apache-forrest-0.8 ..... [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. And given that it is a build change " -1 tests included" can be ignored
        Hide
        Roman Shaposhnik added a comment -

        To answer a chmod question – I followed the already established pattern of not doing chmods in parallel.

        Show
        Roman Shaposhnik added a comment - To answer a chmod question – I followed the already established pattern of not doing chmods in parallel.
        Hide
        Konstantin Boudnik added a comment -

        +1 patch looks good.

        Show
        Konstantin Boudnik added a comment - +1 patch looks good.
        Hide
        Konstantin Boudnik added a comment -

        I have committed this to trunk and branch-0.22. Thanks Roman!

        Show
        Konstantin Boudnik added a comment - I have committed this to trunk and branch-0.22. Thanks Roman!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #611 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/611/)
        MAPREDUCE-2314. configure files that are generated as part of the released tarball need to have executable bit set. Contributed by Roman Shaposhnik.

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #611 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/611/ ) MAPREDUCE-2314 . configure files that are generated as part of the released tarball need to have executable bit set. Contributed by Roman Shaposhnik.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-22-branch #38 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/38/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-22-branch #38 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/38/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )

          People

          • Assignee:
            Roman Shaposhnik
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development